DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Matan Azrad <matan@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	Alex Vesker <valex@nvidia.com>, Erez Shitrit <erezsh@nvidia.com>
Cc: <dev@dpdk.org>, Raslan Darawsheh <rasland@nvidia.com>
Subject: [PATCH 0/2] net/mlx5/hws: fix matcher clean up for FDB tables
Date: Wed, 9 Nov 2022 09:54:29 +0000	[thread overview]
Message-ID: <20221109095431.668926-1-dsosnowski@nvidia.com> (raw)

Before these patches, if an application was configured to run with
HW Steering and E-Switch enabled, on EAL cleanup the assertion in
mlx5_dev_hw_global_release() was triggered - PD release was unsuccessful.

Root cause of this issue was linked to an inability to destroy RTC objects
used internally in mlx5, in HW Steering implementation.
PMD was unable to destroy RTC objects, because of dangling
references to those objects. More specifically, if all matchers
connected to a single flow table were created, this flow table
was still referencing RTC objects when theye were being destroyed.

This patch series fixes that behavior.
Matcher uninitilization is updated to remove the references to RTC objects
from flow table object if the last matcher related to the flow
table was destroyed.

Erez Shitrit (2):
  net/mlx5/hws: fix order of destroying default tables
  net/mlx5/hws: fix disconnecting matcher

 drivers/net/mlx5/hws/mlx5dr_matcher.c | 35 +++++++++++++++++++++++++++
 drivers/net/mlx5/hws/mlx5dr_table.c   |  2 +-
 2 files changed, 36 insertions(+), 1 deletion(-)

-- 
2.25.1


             reply	other threads:[~2022-11-09  9:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09  9:54 Dariusz Sosnowski [this message]
2022-11-09  9:54 ` [PATCH 1/2] net/mlx5/hws: fix order of destroying default tables Dariusz Sosnowski
2022-11-09  9:54 ` [PATCH 2/2] net/mlx5/hws: fix disconnecting matcher Dariusz Sosnowski
2022-11-09 10:32 ` [PATCH 0/2] net/mlx5/hws: fix matcher clean up for FDB tables Matan Azrad
2022-11-09 16:00 ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221109095431.668926-1-dsosnowski@nvidia.com \
    --to=dsosnowski@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=erezsh@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=valex@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).