From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Matan Azrad <matan@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Alex Vesker <valex@nvidia.com>, Erez Shitrit <erezsh@nvidia.com>
Cc: <dev@dpdk.org>, Raslan Darawsheh <rasland@nvidia.com>
Subject: [PATCH 1/2] net/mlx5/hws: fix order of destroying default tables
Date: Wed, 9 Nov 2022 09:54:30 +0000 [thread overview]
Message-ID: <20221109095431.668926-2-dsosnowski@nvidia.com> (raw)
In-Reply-To: <20221109095431.668926-1-dsosnowski@nvidia.com>
From: Erez Shitrit <erezsh@nvidia.com>
This patch fixes the order dereferencing default FDB miss table and
destroying the flow table object. Flow table should be destroyed
before the dereference.
Fixes: 394cc7ba4033 ("net/mlx5/hws: add table object")
Cc: valex@nvidia.com
Signed-off-by: Erez Shitrit <erezsh@nvidia.com>
Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Reviewed-by: Alex Vesker <valex@nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/hws/mlx5dr_table.c b/drivers/net/mlx5/hws/mlx5dr_table.c
index d3f77e4780..33052abce8 100644
--- a/drivers/net/mlx5/hws/mlx5dr_table.c
+++ b/drivers/net/mlx5/hws/mlx5dr_table.c
@@ -131,8 +131,8 @@ mlx5dr_table_create_default_ft(struct mlx5dr_table *tbl)
void mlx5dr_table_destroy_default_ft(struct mlx5dr_table *tbl,
struct mlx5dr_devx_obj *ft_obj)
{
- mlx5dr_table_down_default_fdb_miss_tbl(tbl);
mlx5dr_cmd_destroy_obj(ft_obj);
+ mlx5dr_table_down_default_fdb_miss_tbl(tbl);
}
static int mlx5dr_table_init(struct mlx5dr_table *tbl)
--
2.25.1
next prev parent reply other threads:[~2022-11-09 9:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 9:54 [PATCH 0/2] net/mlx5/hws: fix matcher clean up for FDB tables Dariusz Sosnowski
2022-11-09 9:54 ` Dariusz Sosnowski [this message]
2022-11-09 9:54 ` [PATCH 2/2] net/mlx5/hws: fix disconnecting matcher Dariusz Sosnowski
2022-11-09 10:32 ` [PATCH 0/2] net/mlx5/hws: fix matcher clean up for FDB tables Matan Azrad
2022-11-09 16:00 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109095431.668926-2-dsosnowski@nvidia.com \
--to=dsosnowski@nvidia.com \
--cc=dev@dpdk.org \
--cc=erezsh@nvidia.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=valex@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).