From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: juraj.linkes@pantheon.tech, Lijuan Tu <lijuan.tu@intel.com>,
Owen Hilyard <ohilyard@iol.unh.edu>
Subject: [PATCH] devtools: set DTS directory to format check
Date: Wed, 9 Nov 2022 18:09:21 +0100 [thread overview]
Message-ID: <20221109170921.625192-1-thomas@monjalon.net> (raw)
The script was running on the current directory.
If not in the DTS directory, it would re-format every Python files.
A new positional argument is added to specify the directory to check.
In most cases, the (new) default value should be enough.
While updating argument handling,
the usage is printed in case of wrong argument.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
devtools/dts-check-format.sh | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/devtools/dts-check-format.sh b/devtools/dts-check-format.sh
index dc07150775..eb1bdd2a01 100755
--- a/devtools/dts-check-format.sh
+++ b/devtools/dts-check-format.sh
@@ -3,11 +3,10 @@
# Copyright(c) 2022 University of New Hampshire
usage() {
- echo "Run formatting and linting programs for DTS. Usage:"
-
+ echo 'Usage: $(basename $0) [options] [directory]'
+ echo 'Options:'
# Get source code comments after getopts arguments and print them both
grep -E '[a-zA-Z]+\) +#' "$0" | tr -d '#'
- exit 0
}
format=true
@@ -17,7 +16,9 @@ lint=true
while getopts "hfl" arg; do
case $arg in
h) # Display this message
+ echo 'Run formatting and linting programs for DTS.'
usage
+ exit 0
;;
f) # Don't run formatters
format=false
@@ -25,10 +26,15 @@ while getopts "hfl" arg; do
l) # Don't run linter
lint=false
;;
- *)
+ ?)
+ usage
+ exit 1
esac
done
+shift $(($OPTIND - 1))
+directory=${1:-$(dirname $0)/../dts}
+cd $directory || exit 1
errors=0
--
2.36.1
next reply other threads:[~2022-11-09 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 17:09 Thomas Monjalon [this message]
2022-11-09 17:38 ` Owen Hilyard
2022-11-10 9:27 ` Juraj Linkeš
2022-11-10 10:26 ` Thomas Monjalon
2022-11-10 10:53 ` Juraj Linkeš
2022-11-11 10:06 ` Juraj Linkeš
2022-11-11 10:12 ` Thomas Monjalon
2022-11-23 11:22 ` [PATCH v2] " Thomas Monjalon
2022-11-23 13:41 ` Juraj Linkeš
2022-11-23 15:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109170921.625192-1-thomas@monjalon.net \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=lijuan.tu@intel.com \
--cc=ohilyard@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).