DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dariusz Sosnowski <dsosnowski@nvidia.com>
To: Matan Azrad <matan@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: <dev@dpdk.org>
Subject: [PATCH v2 1/3] net/mlx5: fix log level on failed transfer proxy stop
Date: Wed, 9 Nov 2022 19:06:37 +0000	[thread overview]
Message-ID: <20221109190639.886457-2-dsosnowski@nvidia.com> (raw)
In-Reply-To: <20221109190639.886457-1-dsosnowski@nvidia.com>

This patches increases log level for error reporting when stopping
the transfer proxy port failed. Stopping can fail with EBUSY when
related representor ports are still running.

Fixes: 483181f7b6dd ("net/mlx5: support device control of representor matching")

Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
---
 drivers/net/mlx5/mlx5_trigger.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index 4b821a1076..310a84729e 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -1361,9 +1361,9 @@ mlx5_hw_proxy_port_allowed_stop(struct rte_eth_dev *dev)
 			representor_started = true;
 	}
 	if (representor_started) {
-		DRV_LOG(INFO, "Failed to stop port %u: attached representor ports"
-			      " must be stopped before stopping transfer proxy port",
-			      dev->data->port_id);
+		DRV_LOG(ERR, "Failed to stop port %u: attached representor ports"
+			     " must be stopped before stopping transfer proxy port",
+			     dev->data->port_id);
 		rte_errno = EBUSY;
 		return -rte_errno;
 	}
-- 
2.25.1


  reply	other threads:[~2022-11-09 19:08 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09 16:31 [PATCH 0/3] ethdev: document special cases of port start and stop Dariusz Sosnowski
2022-11-09 16:31 ` [PATCH 1/3] net/mlx5: fix log level on failed transfer proxy stop Dariusz Sosnowski
2022-11-09 16:31 ` [PATCH 2/3] doc: document E-Switch limitations with HWS in mlx5 PMD Dariusz Sosnowski
2022-11-09 16:31 ` [PATCH 3/3] ethdev: document special cases of port start and stop Dariusz Sosnowski
2022-11-09 19:06 ` [PATCH v2 0/3] " Dariusz Sosnowski
2022-11-09 19:06   ` Dariusz Sosnowski [this message]
2022-11-14 13:17     ` [PATCH v2 1/3] net/mlx5: fix log level on failed transfer proxy stop Slava Ovsiienko
2022-11-09 19:06   ` [PATCH v2 2/3] doc: document E-Switch limitations with HWS in mlx5 PMD Dariusz Sosnowski
2022-11-14 13:18     ` Slava Ovsiienko
2022-11-09 19:06   ` [PATCH v2 3/3] ethdev: document special cases of port start and stop Dariusz Sosnowski
2022-11-14 14:07     ` Ferruh Yigit
2022-11-14 16:12       ` Dariusz Sosnowski
2022-11-14 17:10         ` Ferruh Yigit
2022-11-14 18:22           ` Dariusz Sosnowski
2022-11-14 18:19   ` [PATCH v3 0/3] " Dariusz Sosnowski
2022-11-14 18:19     ` [PATCH v3 1/3] net/mlx5: fix log level on failed transfer proxy stop Dariusz Sosnowski
2022-11-14 18:19     ` [PATCH v3 2/3] net/mlx5: document E-Switch limitations with HWS in mlx5 PMD Dariusz Sosnowski
2022-11-15  8:49       ` Slava Ovsiienko
2022-11-14 18:19     ` [PATCH v3 3/3] ethdev: document special cases of port start and stop Dariusz Sosnowski
2022-11-14 18:32       ` Ferruh Yigit
2022-11-21 22:53     ` [PATCH v3 0/3] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221109190639.886457-2-dsosnowski@nvidia.com \
    --to=dsosnowski@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).