From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06FD4A0542; Thu, 10 Nov 2022 17:28:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D0AE40150; Thu, 10 Nov 2022 17:28:00 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id E369E400EF for ; Thu, 10 Nov 2022 17:27:59 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id v4-20020a17090a088400b00212cb0ed97eso1945787pjc.5 for ; Thu, 10 Nov 2022 08:27:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=SLtylg7iZ9VKJM75yfDhQ0sfwpyJ5hhw58227XArygU=; b=SRRr+xd/8HXzLFiBwgIpH2x3s62Y0Y7341Byxlf9/KwmNlC5QbJMGArEWZeWPb1gk5 fRd++gr2mq3XXhHt5tVsUtFjnk5ShaONrJB/v0EHonbxBG70zamPXkgmraFql2KFi8HD HTphedAyfR9Whof0axZvAljvcRJErZQapc35Clqf58ENJulFXjE6xB2/8Lpk2AD/tDr0 a3HC1vI2AmMzZGcAuVTFNd8TurFJLPhc8nvF6zTtKVq4v80c/+kbA96vxqCiE1bnj0Go cyqsdHl63lueK2hikPRjypt4pdnOwREC0CKwMvT/VuHVLjGoVJheNpAZEqDxHG82pInk l0gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SLtylg7iZ9VKJM75yfDhQ0sfwpyJ5hhw58227XArygU=; b=kt/1Imjn+PbVCRPjfAxAvhfZp7Xtx/r33OLkp7kSsc0DotgobjiQewBWztU+sPZdEW T2FOA9ulJkcnvMZFCtXYRV89unvWrGa3bUUC3Y+8g4IdDZf4x7ikep5ad3ApiV1Y8CIf ZFd4mC2OqPXvZCKbsi9nPscPp/F1zSVbiAi26vvcNbBla6nb6S0t8PTDEYc+HXw50sc9 +fk67DiYj768Rsous4rhLE05kofWXm9+pV4zVeSiq0ezkj5km6jYpejIlbMgkiw/sFO4 aCjSuI2YkoPdNBVsGH3enRbaH8bI/uxwuki1yOPOPTy1XW/fl/iruc4ndXGysCwF3UWt q+hw== X-Gm-Message-State: ACrzQf1XKjtxOxIfuCSFzFKGhqH6zG3jnJJj17wnYB6SM41Lo8gGn9Io hezna0K7HbN4ohPABjwZ2XydAQ== X-Google-Smtp-Source: AMsMyM7lIR9J3lMl8jAud8BmSmocydYZcl/Dai1CaEaX2vwa0vzsjXv6hyeURcEgEy80e2Z7qoBXmQ== X-Received: by 2002:a17:902:e74e:b0:186:f3f4:f7fc with SMTP id p14-20020a170902e74e00b00186f3f4f7fcmr64509396plf.130.1668097679021; Thu, 10 Nov 2022 08:27:59 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id d6-20020a170903230600b001782a6fbcacsm11517221plh.101.2022.11.10.08.27.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 08:27:58 -0800 (PST) Date: Thu, 10 Nov 2022 08:27:24 -0800 From: Stephen Hemminger To: Juraj =?UTF-8?B?TGlua2XFoQ==?= Cc: Honnappa Nagarahalli , Owen Hilyard , "thomas@monjalon.net" , "Lijuan Tu" , "Richardson, Bruce" , "dev@dpdk.org" Subject: Re: [PATCH v1 2/2] doc: increase python max line to 88 Message-ID: <20221110082724.1b5b8fab@hermes.local> In-Reply-To: <74ab4d2606234790928087292ef81576@pantheon.tech> References: <20221103132926.445627-1-juraj.linkes@pantheon.tech> <20221103132926.445627-3-juraj.linkes@pantheon.tech> <20221104095734.08d2599c@hermes.local> <74ab4d2606234790928087292ef81576@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 10 Nov 2022 09:15:16 +0000 Juraj Linke=C5=A1 wrote: > > -----Original Message----- > > From: Stephen Hemminger > > Sent: Friday, November 4, 2022 5:58 PM > > To: Juraj Linke=C5=A1 > > Cc: Honnappa Nagarahalli ; Owen Hilyard > > ; thomas@monjalon.net; Lijuan Tu > > ; Richardson, Bruce ; > > dev@dpdk.org > > Subject: Re: [PATCH v1 2/2] doc: increase python max line to 88 > >=20 > > On Fri, 4 Nov 2022 09:16:13 +0000 > > Juraj Linke=C5=A1 wrote: > > =20 > > > > +max_line_length =3D 88 # > > > > =20 > > +https://black.readthedocs.io/en/stable/the_black_code_style/current_st= y =20 > > > > +le.html#li =20 > >=20 > > Skip the comment, it caused your line break! =20 >=20 > The fact that the line is a bit longer does not make the line less readab= le, as the link is there to be copy-pasted (and I don't think anyone reads = the full hyperlinks - the knowledge of domain is enough). As such I think i= t's better to include the link as it serves as self-documentation (that we'= re deviating from the standard). >=20 > We could move the comment before or after the max_line_length option and = that would result in lines below 100 characters (which is what .editorconfi= g prescribes). I used that in my one of my local versions, but it was less = readable in my opinion. I'd rather break the rule and have it be more reada= ble. >=20 > Of course, not having the comment is fine, since we document it in the co= ding style guide. I just think there's no (or very little) downside and som= e upside (more than downside) in adding the comment. The choice of max line length is project specific. Referencing some other s= tyle guide doesn't seem necessary. My choice would be to use 100 like the other C cod= e.