From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BBDBA00C4; Mon, 14 Nov 2022 13:00:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 429B440150; Mon, 14 Nov 2022 13:00:16 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2043.outbound.protection.outlook.com [40.107.223.43]) by mails.dpdk.org (Postfix) with ESMTP id 4FEAF4014F for ; Mon, 14 Nov 2022 13:00:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nCyv80PtRy+SAB9IgGpbLV5LNjlMhX3lVMzFLSpO4jssIx/Ni7QjNDbQnn7+RTd/E89P0EojcJqq/vCQxKHKCF9XP2CwwlZJDJJcMmhKwQWelwYN7mQyNxUaHSas1WkvOGmVH/mRQhK7bhT5CoY7VSRJ5HFAR2YxRpWTtDp4eV9WO1ngBXHiHXZxifnP530pJ7vsIhsE4Bgzw473Hzh+/djyL38mdeUQtAVijxIilr2MG5ykV7LfFGTacFF6LjjdGF6zNFB3qTwaQBicLWnde6P8stNJcsu2ffX+8ud4HkwUeBVg083T8ap7MW9YaTsD42WBQu87yqrTj0tmtT4CrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wRnardl1oKtMUdIqgFlfY3krOyyD/miuO2Qppr1/aH4=; b=aktX0G4Pxxdcf18sThJK/jnuPgDu7cTCpxcq2QltKQIEGXR7JvIqSqcbLIX/1BPsDHbZI73j6e5YHtR01tvfSX4SyLMDZk8ycLFuo8Lmw2sVVmAkKGxbW2c9jI4uhr43NeHR7V7HE+RtvwrO/Ay04jf8qIpQ/yBcMzFnb9BLk231uYW4PJ8OGRYqKGUo4w7dDWv26cT3vtQqlCgb35RU0D/vTXEate0u9V6fbZhFLzuPUltYvjFTx9+PC8v4JPVPl+v14iwB9l7LITmVU7G7bOdIEc3QgCAYwiKOVdXioQQQh0nsd1POpRjVbho884Y5s5AgusXEpwpbuEhPTZ2nCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wRnardl1oKtMUdIqgFlfY3krOyyD/miuO2Qppr1/aH4=; b=X1q6P5kNSGPWXYdTUkL2ohSzaEN1N52ujUZ+OxyQChxccfRKTYqbjRKNA197iAFQOk6Eh+NTOGoZzaWoov+Cr2qNJFDZmPnZ1NDGEvYVvLcHGA2L/n2yRDGHhxHrx7B+c/LZtBKuSjaXo8o9YKRvXz+fcPp0j80fua/Hp9ocuVmpYBNg3ydVrZHQUx8vQunfmL82qj3djkjfQccGfTpH9diNGAvHbXnvVkA1+N9kiouHKW+cbyHXG/jdBfshHUMaQo1szrTWKzoN58qEjpH/PB9ZSy99qZDHck0Ee+YSqDUFkq4NRTJyz74Fn+/CRCEHxGywFoE4e68OVW1IrqMrdg== Received: from MW4PR04CA0222.namprd04.prod.outlook.com (2603:10b6:303:87::17) by MW4PR12MB6779.namprd12.prod.outlook.com (2603:10b6:303:20f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 12:00:12 +0000 Received: from CO1PEPF00001A61.namprd05.prod.outlook.com (2603:10b6:303:87:cafe::e9) by MW4PR04CA0222.outlook.office365.com (2603:10b6:303:87::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17 via Frontend Transport; Mon, 14 Nov 2022 12:00:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF00001A61.mail.protection.outlook.com (10.167.241.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11 via Frontend Transport; Mon, 14 Nov 2022 12:00:11 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 14 Nov 2022 04:00:01 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 14 Nov 2022 03:59:58 -0800 From: Rongwei Liu To: , , , , Aman Singh , Yuying Zhang , Ferruh Yigit , "Andrew Rybchenko" CC: , Subject: [PATCH v7] ethdev: add special flags when creating async transfer table Date: Mon, 14 Nov 2022 13:59:46 +0200 Message-ID: <20221114115946.1074787-1-rongweil@nvidia.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <51e583ea-4446-fea5-af74-dfe75d37f05c@oktetlabs.ru> References: <51e583ea-4446-fea5-af74-dfe75d37f05c@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00001A61:EE_|MW4PR12MB6779:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f268291-eecf-4b6e-1fd8-08dac637c8a4 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DHhjQZyeJwYyERINJhkDXe3IMdd5VGL+QKbQhYP/Wd2EEYw9UY/HbG4vt3bdI/J2HiNFgMa07GjEy4h42QE3RaDo09s95KTg/KVJHgvniX8SX4BcnlqDc96zm1I2JKCBj4HmZ1OLGtGi7DY8AhMYLnCiCUa0vAO7mssjUv8ZktAjWYn5QbuUkU4sU33iDetpM/NgWJkH4yscN3g6ni7FB/iyTu6NbhOAfaCGiLzkOFdGNsWZr4r17saK/3bxwaGNfg0P3wFzCQuNGynFe+yv1XHRTtqf+bro24kvDj5o9lDFqJxN21cAZMDYm43qvwqgYjcdAIivFufdZxXnZxJxhV9ce+SJ1HhBaWbpoDwIXfsgsLcoVAbvntlpEw2usT4PqCiFNtOtX4dihJSCUdJwasjL8xGpja44AJBVkHZHLzxIH85c0Vo7CEj+ZCltzq4H3PfpkGpSOIXvXX8V4CqbHmEOoRbrXxYL578nd5Q99mpYTzYoxV3uWjNem/+hsYJC69v2smofYPC1TntfXdfO4KN4MZi/EmnuN/sV3zZypbSu+oH0pIFh9w0QF/8c9m7LGhFLn2TY+dxbl69NFJnwg61gFvgNx1PyJd/GmfAULP3hzhitrE1UWDDCTsJlbc0GcaahUpsk/gyXzibgkyyiEhN18lJXRnLcDfd1n4bAxBMLwmMoLHmiozjO8Co4726TvhECdeEgpi+RcKppv2tDdn6AwaaeqVvwzjlaMbDxSgFJVqGc3vJDUvIBpKVxHa6brHCj9dnTKc6yvTLbJlTVRQ== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(39860400002)(396003)(346002)(136003)(451199015)(36840700001)(40470700004)(46966006)(26005)(6286002)(55016003)(6666004)(7696005)(107886003)(478600001)(40480700001)(54906003)(316002)(110136005)(36756003)(36860700001)(82740400003)(82310400005)(86362001)(40460700003)(336012)(186003)(426003)(1076003)(47076005)(16526019)(2616005)(7636003)(356005)(83380400001)(2906002)(8936002)(41300700001)(66899015)(8676002)(70586007)(70206006)(4326008)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 12:00:11.6952 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6f268291-eecf-4b6e-1fd8-08dac637c8a4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00001A61.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6779 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In case flow rules match only one kind of traffic in a flow table, then optimization can be done via allocation of this table. Such optimization is possible only if the application gives a hint about its usage of the table during initial configuration. The transfer domain rules may process traffic from wire or vport, which may correspond to two kinds of underlayer resources. That's why the first two hints introduced in this patch are about wire and vport traffic specialization. Wire means traffic arrives from the uplink port while vport means traffic initiated from VF/SF. There are two possible approaches for providing the hints. Using IPv4 as an example: 1. Use pattern item in both template table and flow rules. pattern_template: pattern ANY_VPORT / eth / ipv4 is 1.1.1.1 / end async flow create: pattern ANY_VPORT / eth / ipv4 is 1.1.1.2 / end "ANY_VPORT" needs to be present in each flow rule even if it's just a hint. No value to match because matching is already done by IPv4 item. 2. Add special flags into table_attr. template_table 0 create table_id 0 group 1 transfer vport_orig Approach 1 needs to specify the pattern in each flow rule which wastes memory and is not user friendly. This patch takes the 2nd approach and introduces one new member "specialize" into rte_flow_table_attr to indicate possible flow table optimization. By default, there is no hint, so the behavior of the transfer domain doesn't change. There is no guarantee that the hint will be used by the PMD. Signed-off-by: Rongwei Liu Acked-by: Ori Kam v2: Move the new field to template table attribute. v4: Mark it as optional and clear the concept. v5: Change specialize type to uint32_t. v6: Change the flags to macros and re-construct the commit log. v7: Fix build failure. --- app/test-pmd/cmdline_flow.c | 26 +++++++++++++++++++ doc/guides/prog_guide/rte_flow.rst | 15 +++++++++++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 ++- lib/ethdev/rte_flow.h | 28 +++++++++++++++++++++ 4 files changed, 71 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 88108498e0..62197f2618 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -184,6 +184,8 @@ enum index { TABLE_INGRESS, TABLE_EGRESS, TABLE_TRANSFER, + TABLE_TRANSFER_WIRE_ORIG, + TABLE_TRANSFER_VPORT_ORIG, TABLE_RULES_NUMBER, TABLE_PATTERN_TEMPLATE, TABLE_ACTIONS_TEMPLATE, @@ -1158,6 +1160,8 @@ static const enum index next_table_attr[] = { TABLE_INGRESS, TABLE_EGRESS, TABLE_TRANSFER, + TABLE_TRANSFER_WIRE_ORIG, + TABLE_TRANSFER_VPORT_ORIG, TABLE_RULES_NUMBER, TABLE_PATTERN_TEMPLATE, TABLE_ACTIONS_TEMPLATE, @@ -2933,6 +2937,18 @@ static const struct token token_list[] = { .next = NEXT(next_table_attr), .call = parse_table, }, + [TABLE_TRANSFER_WIRE_ORIG] = { + .name = "wire_orig", + .help = "affect rule direction to transfer", + .next = NEXT(next_table_attr), + .call = parse_table, + }, + [TABLE_TRANSFER_VPORT_ORIG] = { + .name = "vport_orig", + .help = "affect rule direction to transfer", + .next = NEXT(next_table_attr), + .call = parse_table, + }, [TABLE_RULES_NUMBER] = { .name = "rules_number", .help = "number of rules in table", @@ -8993,6 +9009,16 @@ parse_table(struct context *ctx, const struct token *token, case TABLE_TRANSFER: out->args.table.attr.flow_attr.transfer = 1; return len; + case TABLE_TRANSFER_WIRE_ORIG: + if (!out->args.table.attr.flow_attr.transfer) + return -1; + out->args.table.attr.specialize = RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_WIRE_ORIG; + return len; + case TABLE_TRANSFER_VPORT_ORIG: + if (!out->args.table.attr.flow_attr.transfer) + return -1; + out->args.table.attr.specialize = RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_VPORT_ORIG; + return len; default: return -1; } diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 3e6242803d..d9ca041ae4 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -3605,6 +3605,21 @@ and pattern and actions templates are created. &actions_templates, nb_actions_templ, &error); +Table Attribute: Specialize +^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +Application can help optimizing underlayer resources and insertion rate +by specializing template table. +Specialization is done by providing hints +in the template table attribute ``specialize``. + +This attribute is not mandatory for each PMD to implement. +If a hint is not supported, it will be silently ignored, +and no special optimization is done. + +If a table is specialized, the application should make sure the rules +comply with the table attribute. + Asynchronous operations ----------------------- diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 96c5ae0fe4..b3238415f4 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -3145,7 +3145,8 @@ It is bound to ``rte_flow_template_table_create()``:: flow template_table {port_id} create [table_id {id}] [group {group_id}] - [priority {level}] [ingress] [egress] [transfer] + [priority {level}] [ingress] [egress] + [transfer [vport_orig] [wire_orig]] rules_number {number} pattern_template {pattern_template_id} actions_template {actions_template_id} diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 8858b56428..c27b48c5c1 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -5186,6 +5186,29 @@ rte_flow_actions_template_destroy(uint16_t port_id, */ struct rte_flow_template_table; +/**@{@name Special optional flags for template table attribute + * Each bit is a hint for table specialization, + * offering a potential optimization at PMD layer. + * PMD can ignore the unsupported bits silently. + */ +/** + * Specialize table for transfer flows which come only from wire. + * It allows PMD not to allocate resources for non-wire originated traffic. + * This bit is not a matching criteria, just an optimization hint. + * Flow rules which match non-wire originated traffic will be missed + * if the hint is supported. + */ +#define RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_WIRE_ORIG RTE_BIT32(0) +/** + * Specialize table for transfer flows which come only from vport (e.g. VF, SF). + * It allows PMD not to allocate resources for non-vport originated traffic. + * This bit is not a matching criteria, just an optimization hint. + * Flow rules which match non-vport originated traffic will be missed + * if the hint is supported. + */ +#define RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_VPORT_ORIG RTE_BIT32(1) +/**@}*/ + /** * @warning * @b EXPERIMENTAL: this API may change without prior notice. @@ -5201,6 +5224,11 @@ struct rte_flow_template_table_attr { * Maximum number of flow rules that this table holds. */ uint32_t nb_flows; + /** + * Optional hint flags for PMD optimization. + * Value is composed with RTE_FLOW_TABLE_SPECIALIZE_*. + */ + uint32_t specialize; }; /** -- 2.27.0