* [PATCH 1/2] test/crypto-perf: fix number of sessions for cores
@ 2022-11-14 16:57 Ciara Power
2022-11-14 16:57 ` [PATCH 2/2] test/crypto-perf: replace slave with worker Ciara Power
2022-11-15 9:30 ` [EXT] [PATCH 1/2] test/crypto-perf: fix number of sessions for cores Akhil Goyal
0 siblings, 2 replies; 3+ messages in thread
From: Ciara Power @ 2022-11-14 16:57 UTC (permalink / raw)
To: dev; +Cc: kai.ji, Ciara Power, Kevin O'Sullivan
Currently the performance application creates a device session per lcore.
This was not reflected in how many session objects were available
in the mempool, when using a scheduler device.
The number of lcores is now taken into consideration when calculating
how many sessions are needed for the scheduler.
Fixes: 09fcf99dcad2 ("test/crypto-perf: fix number of scheduler sessions")
Reported-by: Kevin O'Sullivan <kevin.osullivan@intel.com>
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
app/test-crypto-perf/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index 0fe47c6caa..22f6b2b3ba 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -269,8 +269,8 @@ cperf_initialize_cryptodev(struct cperf_options *opts, uint8_t *enabled_cdevs)
uint32_t nb_slaves =
rte_cryptodev_scheduler_workers_get(cdev_id,
NULL);
- /* scheduler session header + 1 session per worker qp */
- sessions_needed = 1 + enabled_cdev_count *
+ /* scheduler session header per lcore + 1 session per worker qp */
+ sessions_needed = nb_lcores + enabled_cdev_count *
opts->nb_qps * nb_slaves;
#endif
} else
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] test/crypto-perf: replace slave with worker
2022-11-14 16:57 [PATCH 1/2] test/crypto-perf: fix number of sessions for cores Ciara Power
@ 2022-11-14 16:57 ` Ciara Power
2022-11-15 9:30 ` [EXT] [PATCH 1/2] test/crypto-perf: fix number of sessions for cores Akhil Goyal
1 sibling, 0 replies; 3+ messages in thread
From: Ciara Power @ 2022-11-14 16:57 UTC (permalink / raw)
To: dev; +Cc: kai.ji, Ciara Power
Update the use of outdated language "slaves" with "workers".
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
app/test-crypto-perf/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index 22f6b2b3ba..af5bd0d23b 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -266,12 +266,12 @@ cperf_initialize_cryptodev(struct cperf_options *opts, uint8_t *enabled_cdevs)
if (!strcmp((const char *)opts->device_type,
"crypto_scheduler")) {
#ifdef RTE_CRYPTO_SCHEDULER
- uint32_t nb_slaves =
+ uint32_t nb_workers =
rte_cryptodev_scheduler_workers_get(cdev_id,
NULL);
/* scheduler session header per lcore + 1 session per worker qp */
sessions_needed = nb_lcores + enabled_cdev_count *
- opts->nb_qps * nb_slaves;
+ opts->nb_qps * nb_workers;
#endif
} else
sessions_needed = enabled_cdev_count * opts->nb_qps;
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH 1/2] test/crypto-perf: fix number of sessions for cores
2022-11-14 16:57 [PATCH 1/2] test/crypto-perf: fix number of sessions for cores Ciara Power
2022-11-14 16:57 ` [PATCH 2/2] test/crypto-perf: replace slave with worker Ciara Power
@ 2022-11-15 9:30 ` Akhil Goyal
1 sibling, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2022-11-15 9:30 UTC (permalink / raw)
To: Ciara Power, dev; +Cc: kai.ji, Kevin O'Sullivan
> Currently the performance application creates a device session per lcore.
> This was not reflected in how many session objects were available
> in the mempool, when using a scheduler device.
>
> The number of lcores is now taken into consideration when calculating
> how many sessions are needed for the scheduler.
>
> Fixes: 09fcf99dcad2 ("test/crypto-perf: fix number of scheduler sessions")
>
> Reported-by: Kevin O'Sullivan <kevin.osullivan@intel.com>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
Series applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-15 9:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-14 16:57 [PATCH 1/2] test/crypto-perf: fix number of sessions for cores Ciara Power
2022-11-14 16:57 ` [PATCH 2/2] test/crypto-perf: replace slave with worker Ciara Power
2022-11-15 9:30 ` [EXT] [PATCH 1/2] test/crypto-perf: fix number of sessions for cores Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).