From: Suanming Mou <suanmingm@nvidia.com>
To: <david.marchand@redhat.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Cc: <dev@dpdk.org>
Subject: [PATCH] app/testpmd: fix action destruction memory leak
Date: Thu, 17 Nov 2022 10:55:37 +0200 [thread overview]
Message-ID: <20221117085537.24372-1-suanmingm@nvidia.com> (raw)
In case action handle destroy fails, the job memory was not freed
properly. This commit fixes the possible memory leak in the action
handle destruction failed case.
Fixes: c9dc03840873 ("ethdev: add indirect action async query")
Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
---
app/test-pmd/config.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 982549ffed..719bdd4261 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -2873,9 +2873,9 @@ port_queue_action_handle_destroy(portid_t port_id,
job->type = QUEUE_JOB_TYPE_ACTION_DESTROY;
job->pia = pia;
- if (pia->handle &&
- rte_flow_async_action_handle_destroy(port_id,
+ if (rte_flow_async_action_handle_destroy(port_id,
queue_id, &attr, pia->handle, job, &error)) {
+ free(job);
ret = port_flow_complain(&error);
continue;
}
--
2.25.1
next reply other threads:[~2022-11-17 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 8:55 Suanming Mou [this message]
2022-11-17 11:41 ` David Marchand
2022-11-18 10:40 ` Ferruh Yigit
2022-11-18 12:21 ` Suanming Mou
2022-11-18 15:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221117085537.24372-1-suanmingm@nvidia.com \
--to=suanmingm@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).