From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 59B65A0544;
Thu, 17 Nov 2022 11:15:22 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4092A40DDC;
Thu, 17 Nov 2022 11:15:22 +0100 (CET)
Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31])
by mails.dpdk.org (Postfix) with ESMTP id 7229240DDA
for <dev@dpdk.org>; Thu, 17 Nov 2022 11:15:21 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1668680121; x=1700216121;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=g56tZnJa0mWrZjQ0zFHK+l1GTDr2j3LXuSzh+hXBOfc=;
b=YqBkl5HIHXh06ktouxA6XQ8dSpvC+OCCC7P3+Rw7aOEwua27lmMKU1j9
QI2GcW8ixwFQOlCm0xvU180WKVK3WhSVirDMNIegLXr50kDAhpmHRKd4a
0ZO++jwiVbAYMDXxAS6sFFVDzxQbxmbSw18vP8wF/C5vUs5CcjgDzR+OZ
WbZ35xsFsVr2S4J0KgGrtJJiqGCVFCTVNDspPJyOOIvjjp37JtMAnWvRE
VTGGOrR4mYLL7oK7JDVdmCKg26mH9wyPxKLlP3qQYP2zmGSd5MoTU0OSh
oUiN/5LTIS4K4wW/zMDzZBscX3vWCnQ0ANHFd6ue3JYa+oFtpSSGv9wCR A==;
X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="374946868"
X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="374946868"
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
17 Nov 2022 02:15:20 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="884807425"
X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="884807425"
Received: from dpdk-beileix-3.sh.intel.com ([10.67.110.253])
by fmsmga006.fm.intel.com with ESMTP; 17 Nov 2022 02:15:18 -0800
From: beilei.xing@intel.com
To: jingjing.wu@intel.com
Cc: dev@dpdk.org,
yuan.peng@intel.com,
Beilei Xing <beilei.xing@intel.com>
Subject: [PATCH v2] net/idpf: fix crash when launching l3fwd
Date: Thu, 17 Nov 2022 10:15:09 +0000
Message-Id: <20221117101509.14472-1-beilei.xing@intel.com>
X-Mailer: git-send-email 2.26.2
In-Reply-To: <20221117100054.13836-1-beilei.xing@intel.com>
References: <20221117100054.13836-1-beilei.xing@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
From: Beilei Xing <beilei.xing@intel.com>
There's core dump when launching l3fwd with 1 queue 1 core. It's
because NULL pointer is used if fail to configure device.
This patch removes incorrect check during device configuration,
and checks NULL pointer when executing VIRTCHNL2_OP_DEALLOC_VECTORS.
Fixes: 549343c25db8 ("net/idpf: support device initialization")
Fixes: 70675bcc3a57 ("net/idpf: support RSS")
Fixes: 37291a68fd78 ("net/idpf: support write back based on ITR expire")
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
v2 change: Fix typo.
drivers/net/idpf/idpf_ethdev.c | 7 -------
drivers/net/idpf/idpf_vchnl.c | 3 +++
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c
index 20f088eb80..51fc97bf7b 100644
--- a/drivers/net/idpf/idpf_ethdev.c
+++ b/drivers/net/idpf/idpf_ethdev.c
@@ -372,13 +372,6 @@ idpf_dev_configure(struct rte_eth_dev *dev)
return -ENOTSUP;
}
- if ((dev->data->nb_rx_queues == 1 && conf->rxmode.mq_mode != RTE_ETH_MQ_RX_NONE) ||
- (dev->data->nb_rx_queues > 1 && conf->rxmode.mq_mode != RTE_ETH_MQ_RX_RSS)) {
- PMD_INIT_LOG(ERR, "Multi-queue packet distribution mode %d is not supported",
- conf->rxmode.mq_mode);
- return -ENOTSUP;
- }
-
if (conf->txmode.mq_mode != RTE_ETH_MQ_TX_NONE) {
PMD_INIT_LOG(ERR, "Multi-queue TX mode %d is not supported",
conf->txmode.mq_mode);
diff --git a/drivers/net/idpf/idpf_vchnl.c b/drivers/net/idpf/idpf_vchnl.c
index ac6486d4ef..88770447f8 100644
--- a/drivers/net/idpf/idpf_vchnl.c
+++ b/drivers/net/idpf/idpf_vchnl.c
@@ -1197,6 +1197,9 @@ idpf_vc_dealloc_vectors(struct idpf_vport *vport)
int err, len;
alloc_vec = vport->recv_vectors;
+ if (alloc_vec == NULL)
+ return -EINVAL;
+
vcs = &alloc_vec->vchunks;
len = sizeof(struct virtchnl2_vector_chunks) +
--
2.26.2