From: okaya@kernel.org
To: dev@dpdk.org
Cc: Sinan Kaya <okaya@kernel.org>
Subject: [PATCH 09/11] malloc: check result of malloc_elem_free
Date: Mon, 21 Nov 2022 15:40:15 -0500 [thread overview]
Message-ID: <20221121204015.1135573-10-okaya@kernel.org> (raw)
In-Reply-To: <20221121204015.1135573-1-okaya@kernel.org>
From: Sinan Kaya <okaya@kernel.org>
In malloc_heap_free result of call to malloc_elem_free is dereferenced
here and may be null.
Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
lib/eal/common/malloc_heap.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c
index 1bf2e94c83..78a540c860 100644
--- a/lib/eal/common/malloc_heap.c
+++ b/lib/eal/common/malloc_heap.c
@@ -894,6 +894,9 @@ malloc_heap_free(struct malloc_elem *elem)
/* anything after this is a bonus */
ret = 0;
+ if (!elem)
+ goto free_unlock;
+
/* ...of which we can't avail if we are in legacy mode, or if this is an
* externally allocated segment.
*/
--
2.25.1
prev parent reply other threads:[~2022-11-21 20:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 20:40 [PATCH 00/11] codeql fixes for various subsystems okaya
2022-11-21 20:40 ` [PATCH 01/11] ethdev: check return result of rte_eth_dev_info_get okaya
2022-11-21 20:40 ` [PATCH 02/11] net/tap: check if name is null okaya
2022-11-21 21:41 ` Thomas Monjalon
2022-11-21 22:03 ` Sinan Kaya
2022-11-21 22:57 ` Ferruh Yigit
2022-11-21 20:40 ` [PATCH 03/11] memzone: check result of rte_fbarray_get okaya
2022-11-21 20:40 ` [PATCH 04/11] memzone: check result of malloc_elem_from_data okaya
2022-11-21 20:40 ` [PATCH 05/11] malloc: malloc_elem_join_adjacent_free can return null okaya
2022-11-21 20:40 ` [PATCH 06/11] malloc: check result of rte_mem_virt2memseg_list okaya
2022-11-21 20:40 ` [PATCH 07/11] malloc: check result of rte_fbarray_get okaya
2022-11-21 20:40 ` [PATCH 08/11] malloc: check result of rte_mem_virt2memseg okaya
2022-11-21 20:40 ` okaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121204015.1135573-10-okaya@kernel.org \
--to=okaya@kernel.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).