From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 78522A056D;
	Mon, 21 Nov 2022 23:48:58 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 18A5842D36;
	Mon, 21 Nov 2022 23:48:58 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id C9B8740DF6
 for <dev@dpdk.org>; Mon, 21 Nov 2022 23:48:56 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 1577C20B717A; Mon, 21 Nov 2022 14:48:56 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1577C20B717A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1669070936;
 bh=sC2m/eWcO1pIIBuvGcQ6WwRv1Fpq8Wgtgsn7EweC11w=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=A+ymbYEedbaDg8F3o1zIZ4YUIZa9AClRcF8TckLb7C6jal7B2r3LCAN3SVr9XoKdW
 XCTWH8rlE7pA+99RDb2LaZV700Zbrya9YZCXntWy63LY09BsPybd0+SKZC5BgKnx9N
 H9m1XVxPWlxBfYfUutDBs8uqicAkZVweesTcKQo4=
Date: Mon, 21 Nov 2022 14:48:56 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@huawei.com>, dev@dpdk.org
Subject: Re: [PATCH] ring: build with global includes
Message-ID: <20221121224856.GB24406@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1668813728-9940-1-git-send-email-roretzla@linux.microsoft.com>
 <20221121195327.GA24406@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <d8b89ca6dee54e508cc8d3addd022d81@huawei.com>
 <7452459.EvYhyI6sBW@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7452459.EvYhyI6sBW@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote:
> 21/11/2022 22:27, Konstantin Ananyev:
> > From: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > > e.g. i don't see.
> > > 
> > > deps += ['eal']
> > > 
> > > is the dependency on eal the library or just eal headers? because if it
> > > is header only it is equivalent to telemetry i think?
> > 
> > rte_ring.c uses bunch of EAL functions:
> > rte_zmalloc, rte_memzone_*,  rte_log*, rte_mcfg*, etc.  
> 
> I think deps += ['eal'] is missing in ring meson file.

i guess that's what i'm kind of getting at... if it was there then the
patch i submitted is not required since depending on eal would drag in
global_inc.