From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 41B4FA09E5;
Wed, 23 Nov 2022 11:19:52 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 0853842D8C;
Wed, 23 Nov 2022 11:19:46 +0100 (CET)
Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net
[217.70.183.195])
by mails.dpdk.org (Postfix) with ESMTP id 9816240E5A
for <dev@dpdk.org>; Wed, 23 Nov 2022 11:19:44 +0100 (CET)
Received: (Authenticated sender: robin@jarry.cc)
by mail.gandi.net (Postfix) with ESMTPSA id 13F8C60007;
Wed, 23 Nov 2022 10:19:41 +0000 (UTC)
From: Robin Jarry <rjarry@redhat.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Jerin Jacob <jerinj@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
=?UTF-8?q?Mattias=20R=C3=B6nnblom?= <hofors@lysator.liu.se>,
=?UTF-8?q?Morten=20Br=C3=B8rup?= <mb@smartsharesystems.com>,
Robin Jarry <rjarry@redhat.com>
Subject: [RFC PATCH 2/4] eal: allow applications to report their cpu
utilization
Date: Wed, 23 Nov 2022 11:19:29 +0100
Message-Id: <20221123101931.1688238-3-rjarry@redhat.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221123101931.1688238-1-rjarry@redhat.com>
References: <20221123101931.1688238-1-rjarry@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Allow applications to register a callback that will be invoked in
rte_lcore_dump() and when requesting lcore info in the telemetry API.
The callback is expected to return a number between 0 and 100
representing the percentage of busy cycles spent over a fixed period of
time. The period of time is configured when registering the callback.
Cc: Bruce Richardson <bruce.richardson@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>
Cc: Kevin Laatz <kevin.laatz@intel.com>
Cc: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Cc: Mattias Rönnblom <hofors@lysator.liu.se>
Cc: Morten Brørup <mb@smartsharesystems.com>
Signed-off-by: Robin Jarry <rjarry@redhat.com>
---
lib/eal/common/eal_common_lcore.c | 37 ++++++++++++++++++++++++++++---
lib/eal/include/rte_lcore.h | 30 +++++++++++++++++++++++++
lib/eal/version.map | 1 +
3 files changed, 65 insertions(+), 3 deletions(-)
diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c
index 31e3965dc5ad..9a85fd8854df 100644
--- a/lib/eal/common/eal_common_lcore.c
+++ b/lib/eal/common/eal_common_lcore.c
@@ -420,14 +420,36 @@ rte_lcore_iterate(rte_lcore_iterate_cb cb, void *arg)
return ret;
}
+static rte_lcore_busy_percent_cb lcore_busy_cb;
+static unsigned int lcore_busy_period;
+
+void
+rte_lcore_register_busy_percent_cb(rte_lcore_busy_percent_cb cb, unsigned int period)
+{
+ lcore_busy_cb = cb;
+ lcore_busy_period = period;
+}
+
+static int
+lcore_busy_percent(unsigned int lcore_id)
+{
+ int percent = -1;
+ if (lcore_busy_cb)
+ percent = lcore_busy_cb(lcore_id);
+ if (percent > 100)
+ percent = 100;
+ return percent;
+}
+
static int
lcore_dump_cb(unsigned int lcore_id, void *arg)
{
struct rte_config *cfg = rte_eal_get_configuration();
char cpuset[RTE_CPU_AFFINITY_STR_LEN];
+ char busy_str[16];
const char *role;
FILE *f = arg;
- int ret;
+ int ret, busy;
switch (cfg->lcore_role[lcore_id]) {
case ROLE_RTE:
@@ -446,9 +468,16 @@ lcore_dump_cb(unsigned int lcore_id, void *arg)
ret = eal_thread_dump_affinity(&lcore_config[lcore_id].cpuset, cpuset,
sizeof(cpuset));
- fprintf(f, "lcore %u, socket %u, role %s, cpuset %s%s\n", lcore_id,
+ busy = lcore_busy_percent(lcore_id);
+ if (busy < 0) {
+ snprintf(busy_str, sizeof(busy_str), "%s", "N/A");
+ } else {
+ snprintf(busy_str, sizeof(busy_str), "%d%% last %d sec",
+ busy, lcore_busy_period);
+ }
+ fprintf(f, "lcore %u, socket %u, role %s, cpuset %s%s, busy %s\n", lcore_id,
rte_lcore_to_socket_id(lcore_id), role, cpuset,
- ret == 0 ? "" : "...");
+ ret == 0 ? "" : "...", busy_str);
return 0;
}
@@ -517,6 +546,8 @@ lcore_telemetry_info_cb(unsigned int lcore_id, void *arg)
rte_tel_data_add_dict_int(info->d, "socket", rte_lcore_to_socket_id(lcore_id));
rte_tel_data_add_dict_string(info->d, "role", role);
rte_tel_data_add_dict_string(info->d, "cpuset", cpuset);
+ rte_tel_data_add_dict_int(info->d, "busy_percent", lcore_busy_percent(lcore_id));
+ rte_tel_data_add_dict_int(info->d, "busy_period", lcore_busy_period);
return 0;
}
diff --git a/lib/eal/include/rte_lcore.h b/lib/eal/include/rte_lcore.h
index 6938c3fd7b81..b1223eaa12bf 100644
--- a/lib/eal/include/rte_lcore.h
+++ b/lib/eal/include/rte_lcore.h
@@ -328,6 +328,36 @@ typedef int (*rte_lcore_iterate_cb)(unsigned int lcore_id, void *arg);
int
rte_lcore_iterate(rte_lcore_iterate_cb cb, void *arg);
+/**
+ * Callback to allow applications to report CPU utilization.
+ *
+ * @param lcore_id
+ * The lcore to consider.
+ * @return
+ * - A number between 0 and 100 representing the percentage of busy cycles
+ * over the last period for the given lcore_id.
+ * - -1 if the information is not available or if any error occurred.
+ */
+typedef int (*rte_lcore_busy_percent_cb)(unsigned int lcore_id);
+
+/**
+ * Register a callback from an application to be called in rte_lcore_dump()
+ * and the /eal/lcore/info telemetry endpoint handler.
+ *
+ * Applications are expected to return a number between 0 and 100 representing
+ * the percentage of busy cycles over the last period for the provided lcore_id.
+ * The implementation details for computing such a ratio is specific to each
+ * application.
+ *
+ * @param cb
+ * The callback function.
+ * @param period
+ * The period in seconds over which the percentage of busy cycles will be
+ * reported by the application.
+ */
+__rte_experimental
+void rte_lcore_register_busy_percent_cb(rte_lcore_busy_percent_cb cb, unsigned int period);
+
/**
* List all lcores.
*
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 7ad12a7dc985..138537ee5835 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -440,6 +440,7 @@ EXPERIMENTAL {
rte_thread_detach;
rte_thread_equal;
rte_thread_join;
+ rte_lcore_register_busy_percent_cb;
};
INTERNAL {
--
2.38.1