From: Stephen Hemminger <stephen@networkplumber.org>
To: Rushil Gupta <rushilg@google.com>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>,
Junfeng Guo <junfeng.guo@intel.com>,
qi.z.zhang@intel.com, jingjing.wu@intel.com,
beilei.xing@intel.com, dev@dpdk.org, jeroendb@google.com,
jrkim@google.com, Xiaoyun Li <xiaoyun.li@intel.com>
Subject: Re: [PATCH] net/gve: add support for basic stats
Date: Sat, 26 Nov 2022 09:34:33 -0800 [thread overview]
Message-ID: <20221126093433.7b3b5078@hermes.local> (raw)
In-Reply-To: <CANzqiF4xfmK_hUaRFSRR+GQoN_otRPL4T+sNOtawOcZgG-rC-w@mail.gmail.com>
On Fri, 25 Nov 2022 19:16:00 -0800
Rushil Gupta <rushilg@google.com> wrote:
> > >
> > > The driver should be filling in the per-queue stats as well.
> > > q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors
> >
> >
> > Hi Stephen,
> >
> > Queue stats moved to xstats, and there is a long term goal to move all
> > queue stats from basic stats to xstats for all PMDs, and remove interim
> > 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag.
> >
> > That is why request to new PMDs is to not introduce queue stats in basic
> > stats, but in xstats.
Agree that xstats are better but:
* the current checked in version of GVE does not have driver op for xstats
* if driver fills in the q_XXX[] stats then eth_dev_get_xstats_basic will be
able to use it.
The per queue stats are limited to 256 queues and bloats the info structure,
but until an API breaking change is made to remove them, drivers should support
it.
next prev parent reply other threads:[~2022-11-26 17:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 7:33 Junfeng Guo
2022-11-24 16:59 ` Stephen Hemminger
2022-11-24 17:26 ` Ferruh Yigit
2022-11-26 3:16 ` Rushil Gupta
2022-11-26 17:34 ` Stephen Hemminger [this message]
2022-11-28 11:12 ` Ferruh Yigit
2022-11-28 17:24 ` Stephen Hemminger
2022-11-29 1:42 ` Guo, Junfeng
2022-12-07 15:09 ` Ferruh Yigit
2022-12-07 16:39 ` Stephen Hemminger
2022-12-19 19:17 ` Rushil Gupta
2022-12-19 19:38 ` Joshua Washington
2023-01-18 16:22 ` Ferruh Yigit
2023-01-31 1:51 ` Joshua Washington
2023-01-31 10:05 ` Ferruh Yigit
2023-02-02 23:00 ` Joshua Washington
2023-02-03 17:39 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221126093433.7b3b5078@hermes.local \
--to=stephen@networkplumber.org \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jeroendb@google.com \
--cc=jingjing.wu@intel.com \
--cc=jrkim@google.com \
--cc=junfeng.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rushilg@google.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).