From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 08484A0093;
Thu, 8 Dec 2022 21:22:15 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 31B4142DDE;
Thu, 8 Dec 2022 21:19:40 +0100 (CET)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
[67.231.156.173])
by mails.dpdk.org (Postfix) with ESMTP id 25FE642D40
for <dev@dpdk.org>; Thu, 8 Dec 2022 21:19:20 +0100 (CET)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
2B8Jjcg4004895 for <dev@dpdk.org>; Thu, 8 Dec 2022 12:19:19 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-type; s=pfpt0220; bh=9CvSayo1UUhX33359fcicIyNtty7QCxxs9hk8b+d6Fk=;
b=e6U/zC7Kjs4wkhkPtT/9F0gwwc5bIO5gy/gvdgSGNUtMG1mtwgfBj8CV3aPDM5oOc8IX
jyoKXSQ+qJss+hXPBCJEffmbfJTOCcR3yp0Q7i5z6obWFmleWjsYCJ6NBzFzwK8yE9eR
NGwGw75lXYdNLUKE3eFFu0eCgb4Imdu+PBX0jpMA+TchAOn80sHogE90FLLYIUfLIdtQ
HnptpcBwX5I4dgWQd3xoLF6tR9JyKWHRdgO33N77UkrpVKPE4+Q6SrUpp2j8CEzfvbXz
gZrdyD3KCa6wE7dSvsvmyDsCHGsWjmGvlAbQpa0Z6tb5uTcJPIllR24iUqxHie6isHxy ww==
Received: from dc5-exch01.marvell.com ([199.233.59.181])
by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3m86usnj1d-7
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)
for <dev@dpdk.org>; Thu, 08 Dec 2022 12:19:19 -0800
Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com
(10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;
Thu, 8 Dec 2022 12:19:16 -0800
Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com
(10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend
Transport; Thu, 8 Dec 2022 12:19:16 -0800
Received: from ml-host-33.caveonetworks.com (unknown [10.110.143.233])
by maili.marvell.com (Postfix) with ESMTP id 316ED3F710C;
Thu, 8 Dec 2022 12:18:20 -0800 (PST)
From: Srikanth Yalavarthi <syalavarthi@marvell.com>
To: Srikanth Yalavarthi <syalavarthi@marvell.com>
CC: <dev@dpdk.org>, <sshankarnara@marvell.com>, <jerinj@marvell.com>,
<aprabhu@marvell.com>
Subject: [PATCH v2 29/37] ml/cnxk: add support to get and reset device stats
Date: Thu, 8 Dec 2022 12:17:57 -0800
Message-ID: <20221208201806.21893-30-syalavarthi@marvell.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20221208201806.21893-1-syalavarthi@marvell.com>
References: <20221208200220.20267-1-syalavarthi@marvell.com>
<20221208201806.21893-1-syalavarthi@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Proofpoint-GUID: K4VZ6W7yyg2zKqqSB_DwhP3hdkochMo9
X-Proofpoint-ORIG-GUID: K4VZ6W7yyg2zKqqSB_DwhP3hdkochMo9
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
definitions=2022-12-08_11,2022-12-08_01,2022-06-22_01
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Enabled support to get and reset ML device stats. Device stats
include number of requests enqueued/dequeued and error count.
Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
drivers/ml/cnxk/cn10k_ml_ops.c | 55 ++++++++++++++++++++++++++++++++--
drivers/ml/cnxk/cn10k_ml_ops.h | 3 ++
2 files changed, 55 insertions(+), 3 deletions(-)
diff --git a/drivers/ml/cnxk/cn10k_ml_ops.c b/drivers/ml/cnxk/cn10k_ml_ops.c
index d9eea21e12..732d0a63ba 100644
--- a/drivers/ml/cnxk/cn10k_ml_ops.c
+++ b/drivers/ml/cnxk/cn10k_ml_ops.c
@@ -159,6 +159,10 @@ cn10k_ml_qp_create(const struct rte_ml_dev *dev, uint16_t qp_id, uint32_t nb_des
qp->queue.tail = 0;
qp->queue.wait_cycles = ML_CN10K_CMD_TIMEOUT * plt_tsc_hz();
qp->nb_desc = nb_desc;
+ qp->stats.enqueued_count = 0;
+ qp->stats.dequeued_count = 0;
+ qp->stats.enqueue_err_count = 0;
+ qp->stats.dequeue_err_count = 0;
/* Initialize job command */
for (i = 0; i < qp->nb_desc; i++) {
@@ -678,6 +682,38 @@ cn10k_ml_dev_queue_pair_setup(struct rte_ml_dev *dev, uint16_t queue_pair_id,
return 0;
}
+static int
+cn10k_ml_dev_stats_get(struct rte_ml_dev *dev, struct rte_ml_dev_stats *stats)
+{
+ struct cn10k_ml_qp *qp;
+ int qp_id;
+
+ for (qp_id = 0; qp_id < dev->data->nb_queue_pairs; qp_id++) {
+ qp = dev->data->queue_pairs[qp_id];
+ stats->enqueued_count += qp->stats.enqueued_count;
+ stats->dequeued_count += qp->stats.dequeued_count;
+ stats->enqueue_err_count += qp->stats.enqueue_err_count;
+ stats->dequeue_err_count += qp->stats.dequeue_err_count;
+ }
+
+ return 0;
+}
+
+static void
+cn10k_ml_dev_stats_reset(struct rte_ml_dev *dev)
+{
+ struct cn10k_ml_qp *qp;
+ int qp_id;
+
+ for (qp_id = 0; qp_id < dev->data->nb_queue_pairs; qp_id++) {
+ qp = dev->data->queue_pairs[qp_id];
+ qp->stats.enqueued_count = 0;
+ qp->stats.dequeued_count = 0;
+ qp->stats.enqueue_err_count = 0;
+ qp->stats.dequeue_err_count = 0;
+ }
+}
+
static int
cn10k_ml_dev_dump(struct rte_ml_dev *dev, FILE *fp)
{
@@ -1470,15 +1506,23 @@ static __rte_always_inline void
cn10k_ml_result_update(struct rte_ml_dev *dev, int qp_id, struct cn10k_ml_result *result,
struct rte_ml_op *op)
{
- PLT_SET_USED(dev);
- PLT_SET_USED(qp_id);
-
struct cn10k_ml_dev *mldev;
+ struct cn10k_ml_qp *qp;
if (likely(result->error_code.u64 == 0)) {
+ if (likely(qp_id >= 0)) {
+ qp = dev->data->queue_pairs[qp_id];
+ qp->stats.dequeued_count++;
+ }
+
op->impl_opaque = result->error_code.u64;
op->status = RTE_ML_OP_STATUS_SUCCESS;
} else {
+ if (likely(qp_id >= 0)) {
+ qp = dev->data->queue_pairs[qp_id];
+ qp->stats.dequeue_err_count++;
+ }
+
/* Handle driver error */
if (result->error_code.s.etype == ML_ETYPE_DRIVER) {
mldev = dev->data->dev_private;
@@ -1552,6 +1596,7 @@ cn10k_ml_enqueue_burst(struct rte_ml_dev *dev, uint16_t qp_id, struct rte_ml_op
jcmdq_full:
queue->head = head;
+ qp->stats.enqueued_count += count;
return count;
}
@@ -1700,6 +1745,10 @@ struct rte_ml_dev_ops cn10k_ml_ops = {
.dev_queue_pair_setup = cn10k_ml_dev_queue_pair_setup,
.dev_queue_pair_release = cn10k_ml_dev_queue_pair_release,
+ /* Stats ops */
+ .dev_stats_get = cn10k_ml_dev_stats_get,
+ .dev_stats_reset = cn10k_ml_dev_stats_reset,
+
/* Model ops */
.model_load = cn10k_ml_model_load,
.model_unload = cn10k_ml_model_unload,
diff --git a/drivers/ml/cnxk/cn10k_ml_ops.h b/drivers/ml/cnxk/cn10k_ml_ops.h
index 5f00cb2a60..4c38f1938a 100644
--- a/drivers/ml/cnxk/cn10k_ml_ops.h
+++ b/drivers/ml/cnxk/cn10k_ml_ops.h
@@ -58,6 +58,9 @@ struct cn10k_ml_qp {
/* Request queue */
struct cn10k_ml_queue queue;
+
+ /* Queue pair statistics */
+ struct rte_ml_dev_stats stats;
};
/* CN10K device ops */
--
2.17.1