From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id A5179A0540;
Tue, 13 Dec 2022 04:51:27 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 454DB40684;
Tue, 13 Dec 2022 04:51:27 +0100 (CET)
Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com
[209.85.215.169])
by mails.dpdk.org (Postfix) with ESMTP id 95EB340146
for <dev@dpdk.org>; Tue, 13 Dec 2022 04:51:25 +0100 (CET)
Received: by mail-pg1-f169.google.com with SMTP id q71so9602116pgq.8
for <dev@dpdk.org>; Mon, 12 Dec 2022 19:51:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20210112.gappssmtp.com; s=20210112;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=rhXF2/vPqGBVFjN4xmOnyiK+6Q3yPdaLoZw4n/AJiFo=;
b=AU0jRrOugYXZno+f7uFMyE0VO2pWGTIS3dzy6wLZCoqTzmgrw02O8RSBlQaTtZ5Nec
UGv+afp778GDMWKJyst5RLbltcRnCssr3u5BXfDX4esna/Ma30ZsUoU6Pz1l62bsCL+g
HoyJh7/apYugS5da9eeZVQyrWvc1QmGQk2SvmVOl+kNTNK4nLugqVoCDpOKf8FsfDwj0
DcsM4WCnUsu66otlQEu8i3QaE7TthLoYrfbgVC5+OTSyG2nQsEL/7ttqOZYypAp4/DBc
J0waXfdD8+5M54B8N0zOFed/Bd5q3hi3pRJWsoYVi4iaaMuipadKqp01aPSm/7dHqMC0
/lhg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=rhXF2/vPqGBVFjN4xmOnyiK+6Q3yPdaLoZw4n/AJiFo=;
b=7WN4x4fGVifEcJvABSe1s2NTd94TpUzVSV3Oji3k+JmOw9MxWTnxfoVEsqMxnD9t8n
l2hJrJG0s2QDhNFd54AFOgezB+w6IyUbFvV7UVZuvjzT3o5/+P8Y856DhLWoCCzLTkDH
oMbn7t3RvuZBRxgt5Ye1aErXkndEuJFWShH+DNWDdv/1pRT1fPLOr/hbJFXtSTXYshJs
T8K6XqXlPnEu0YEOTEU6vLfdCH6YZCnd3r1uRtDOJYc7gssqFLgl//T7xa8DRfOVV1Uo
rcHdEC3MpjTfDHyTU5PmOqk5jn1msC35/GdBGv50Cra9iHTqF4cIFec8UT3KkkOOfzLD
iPeQ==
X-Gm-Message-State: ANoB5pn330kZOqPbObn3pDnGmqULfPQ0uKnM/85QEO8vDmhZVkPBuZC+
B2mSbnweEDzn4eLxCsYbvDa5hg==
X-Google-Smtp-Source: AA0mqf6QiG3T5wdGk2gQLTm0DWdHKNGKgSnIjQBswcMLgxOXe+Qvxcrz7RFxof257J2pnC3PjYGwWA==
X-Received: by 2002:a62:1a8a:0:b0:56e:9a2c:152b with SMTP id
a132-20020a621a8a000000b0056e9a2c152bmr18922718pfa.24.1670903484608;
Mon, 12 Dec 2022 19:51:24 -0800 (PST)
Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])
by smtp.gmail.com with ESMTPSA id
h3-20020a625303000000b005609d3d3008sm6754123pfb.171.2022.12.12.19.51.24
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 12 Dec 2022 19:51:24 -0800 (PST)
Date: Mon, 12 Dec 2022 19:51:22 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ke Zhang <ke1x.zhang@intel.com>
Cc: qi.z.zhang@intel.com, yuying.zhang@intel.com, dev@dpdk.org
Subject: Re: [PATCH] net/ice: add devargs for disabling mac filter
Message-ID: <20221212195122.5b1cbd15@hermes.local>
In-Reply-To: <20221125025124.805466-1-ke1x.zhang@intel.com>
References: <20221125025124.805466-1-ke1x.zhang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Fri, 25 Nov 2022 10:51:24 +0800
Ke Zhang <ke1x.zhang@intel.com> wrote:
> diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h
> index c8311be179..0350c6584a 100644
> --- a/drivers/net/ice/ice_ethdev.h
> +++ b/drivers/net/ice/ice_ethdev.h
> @@ -563,6 +563,7 @@ struct ice_devargs {
> int safe_mode_support;
> uint8_t proto_xtr_dflt;
> int pipe_mode_support;
> + int mac_filter_disable;
Why use 4 bytes for a flag when a single bit would do.