From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CAE18A0543;
	Thu, 15 Dec 2022 18:48:27 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EB6C642C24;
	Thu, 15 Dec 2022 18:48:26 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id BC49840685
 for <dev@dpdk.org>; Thu, 15 Dec 2022 18:48:25 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 1766820B87E9; Thu, 15 Dec 2022 09:48:25 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1766820B87E9
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1671126505;
 bh=pWfgo/SzL0RSasbSWeDDnjkHhC+o3s6VYMvCDIqff5M=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=do9/QW8whIY84FUpo5vgRNmVlOpWqUhP+amGTnTParsQpB7ynMGmN6jwybh89nsFF
 yFG8blgCpajC+YcZpXZklx6V/wdei3A4cfJgKSEo9gDpxE5C1PAS+mDbjEHcLqKIu9
 XwDXzINTiEJCqWevq6fHfq3ijUPTI6hkTB3rPX9c=
Date: Thu, 15 Dec 2022 09:48:25 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Kadam, Pallavi" <pallavi.kadam@intel.com>, dev@dpdk.org,
 Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH 2/8] net/ring: build on Windows
Message-ID: <20221215174825.GA17591@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20221201014440.11896-1-stephen@networkplumber.org>
 <20221201014440.11896-3-stephen@networkplumber.org>
 <51cd4498-fb28-bcff-3ad4-1108da87ecc8@intel.com>
 <20221214192215.7adf648d@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221214192215.7adf648d@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, Dec 14, 2022 at 07:22:15PM -0800, Stephen Hemminger wrote:
> On Wed, 14 Dec 2022 15:18:08 -0800
> "Kadam, Pallavi" <pallavi.kadam@intel.com> wrote:
> 
> > Hi Stephen,
> > 
> > Thanks for enabling this support.
> > 
> > On 11/30/2022 5:44 PM, Stephen Hemminger wrote:
> > > This driver builds ok on windows, but need to modify the
> > > test meson build to skip the eventdev test on Windows.
> > >
> > > Signed-off-by: Stephen Hemminger<stephen@networkplumber.org>
> > > ---  
> > 
> > There is still a build error with clang compiler on Windows
> > as mentioned by Dmitry:
> > 
> > ../drivers/net/ring/rte_eth_ring.c:542:12: error: use of undeclared identifier 'PATH_MAX'
> >          char name[PATH_MAX];
> >                    ^
> > #include <rte_os_shim.h> is missing
> > 
> > >     
> 
> It is in the mingw version but not other compilers.

not sure if it helps but in the sludge of my memory i think you can use
MAX_PATH.

so maybe a little 
#ifndef PATH_MAX
#define PATH_MAX MAX_PATH
#endif

in the os shim?