From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6493A0543; Thu, 15 Dec 2022 19:10:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81A8F40695; Thu, 15 Dec 2022 19:10:02 +0100 (CET) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by mails.dpdk.org (Postfix) with ESMTP id 78B8340685 for ; Thu, 15 Dec 2022 19:10:01 +0100 (CET) Received: by mail-lf1-f42.google.com with SMTP id c1so16922279lfi.7 for ; Thu, 15 Dec 2022 10:10:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=OmxhbM4h/I8COPr5aPEiHlGZQj5yrp5IXDVvMXCjPIQ=; b=bvZfnPKBlVMptsbYoY7Yn00r/kAy4Nz0hoiByykuMCyJAGJUThxaGavF/rKcmABetd F5siYf1PJr7fDPOQyp/GMkvSuiM8F5uPQtDRQSxBVsdHhHWsJlDT2yo9PzgXDHHpIc6o 9DccCD3Aq84MOwOghANu2jJlFBkZO0Q5mLzEpMg3iymTVcumOz8xdV3dIeyZUpkklWL7 GMCqFMm1Qk0ioDGA4PJXL64KGkxgaAhsODC1Tqle2frRpkUGXkDa7mOfwFRBOA8hPtzP jwAZR9/PqcJAioESETVJ5YAt0SUFZck33dcYTz3MDx67H7pElFDt2TpGPWMgpnUhB/Z2 4iEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OmxhbM4h/I8COPr5aPEiHlGZQj5yrp5IXDVvMXCjPIQ=; b=yGbCpSjjRZYB/dw0c8xq/rQbxmCvasvSShvH+q76i/vYCi3q1ekpNM15/JKI/Ze6xC dePsAuh3urtFjQpa4qFuj/K+kEr/yZJBNFSy/tLU+w4kcPd8fwezoshOaSCXb2Xfpj41 LfQWSQlfXgwjY/sxNl6Mg1iLvZk/So83fAFDPE5PdbzyJmbJN0Rq5wOp8OvEVjY/dNzF 1YphUCxvrFQ97HmhsVNFq1AU6TSRnbLfXyeTiGw+XIkcDMZ2br30Ko5vH9bPmlYdnHU/ m0Vvf71zMutISJya9bABHWgVYhgN7+6gy54ExAdU02YgcX6vC96nMU/j474gXO200JGI hIOQ== X-Gm-Message-State: ANoB5pn46GKAGXsCnXRrxgEgAa7C7oUIkY1mgRlnf4U+wL7Leiaw0iDc e0GSHP7YvrnNw2EDXqBDSPI= X-Google-Smtp-Source: AA0mqf4jAxGLrd+cBpRFUk1KW3RyDCQuFGSuSzVvhTs6pEVVRZnpcULgSShCbiKfTidgSZKvdZai1A== X-Received: by 2002:a05:6512:3990:b0:4b6:d28a:2558 with SMTP id j16-20020a056512399000b004b6d28a2558mr12323553lfu.49.1671127800948; Thu, 15 Dec 2022 10:10:00 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id p3-20020ac24ec3000000b004b3b2a9f506sm1236148lfr.4.2022.12.15.10.10.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 10:10:00 -0800 (PST) Date: Thu, 15 Dec 2022 21:09:59 +0300 From: Dmitry Kozlyuk To: Tyler Retzlaff Cc: Stephen Hemminger , "Kadam, Pallavi" , dev@dpdk.org, Bruce Richardson Subject: Re: [PATCH 2/8] net/ring: build on Windows Message-ID: <20221215210959.66e303be@sovereign> In-Reply-To: <20221215174825.GA17591@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20221201014440.11896-1-stephen@networkplumber.org> <20221201014440.11896-3-stephen@networkplumber.org> <51cd4498-fb28-bcff-3ad4-1108da87ecc8@intel.com> <20221214192215.7adf648d@hermes.local> <20221215174825.GA17591@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2022-12-15 09:48 (UTC-0800), Tyler Retzlaff: > On Wed, Dec 14, 2022 at 07:22:15PM -0800, Stephen Hemminger wrote: > > On Wed, 14 Dec 2022 15:18:08 -0800 > > "Kadam, Pallavi" wrote: [...] > > > There is still a build error with clang compiler on Windows > > > as mentioned by Dmitry: > > > > > > ../drivers/net/ring/rte_eth_ring.c:542:12: error: use of undeclared identifier 'PATH_MAX' > > > char name[PATH_MAX]; > > > ^ > > > #include is missing > > > > > > > > > > > It is in the mingw version but not other compilers. > > not sure if it helps but in the sludge of my memory i think you can use > MAX_PATH. > > so maybe a little > #ifndef PATH_MAX > #define PATH_MAX MAX_PATH > #endif > > in the os shim? It is in rte_os_shim.h already (for MinGW), just needs to be included.