From: Naga Harish K S V <s.v.naga.harish.k@intel.com>
To: jerinj@marvell.com, erik.g.carrillo@intel.com,
abhinandan.gujjar@intel.com
Cc: dev@dpdk.org, jay.jayatheerthan@intel.com
Subject: [PATCH v3 1/4] eventdev/eth_rx: change eventdev reconfig logic
Date: Sun, 18 Dec 2022 23:33:12 -0600 [thread overview]
Message-ID: <20221219053315.2538180-1-s.v.naga.harish.k@intel.com> (raw)
In-Reply-To: <20221214070440.921488-1-s.v.naga.harish.k@intel.com>
When rte_event_eth_rx_adapter_create() or
rte_event_eth_rx_adapter_create_with_params() is used for creating
adapter instance, eventdev is reconfigured with additional
``rte_event_dev_config::nb_event_ports`` parameter.
This eventdev reconfig logic is enhanced to increment the
``rte_event_dev_config::nb_single_link_event_port_queues``
parameter if the adapter event port config is of type
``RTE_EVENT_PORT_CFG_SINGLE_LINK``.
With this change the application no longer need to configure the
eventdev with ``rte_event_dev_config::nb_single_link_event_port_queues``
parameter required for eth_rx adapter when the adapter is created
using above mentioned apis.
Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
---
v2:
* Fix build error
v3:
* update doxygen
---
---
.../prog_guide/event_ethernet_rx_adapter.rst | 18 ++++++++++++++++++
lib/eventdev/rte_event_eth_rx_adapter.c | 3 +++
lib/eventdev/rte_event_eth_rx_adapter.h | 13 +++++++++++++
3 files changed, 34 insertions(+)
diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
index 116c0a27c6..8fc9be0a9d 100644
--- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
+++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst
@@ -71,6 +71,24 @@ set to true. The function is passed the event device to be associated with
the adapter and port configuration for the adapter to setup an event port
if the adapter needs to use a service function.
+Event device configuration for service based adapter
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+When rte_event_eth_rx_adapter_create() or
+rte_event_eth_rx_adapter_create_with_params() is used for creating
+adapter instance, eventdev is reconfigured with additional
+``rte_event_dev_config::nb_event_ports`` parameter.
+This eventdev reconfig logic also increment the
+``rte_event_dev_config::nb_single_link_event_port_queues``
+parameter if the adapter event port config is of type
+``RTE_EVENT_PORT_CFG_SINGLE_LINK``.
+
+So the application is no longer need to configure the
+event device with ``rte_event_dev_config::nb_event_ports`` and
+``rte_event_dev_config::nb_single_link_event_port_queues``
+parameters required for eth_rx adapter when the adapter is created
+using above mentioned apis.
+
Adding Rx Queues to the Adapter Instance
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index cf7bbd4d69..34aa87379e 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -1532,6 +1532,9 @@ rxa_default_conf_cb(uint8_t id, uint8_t dev_id,
rte_event_dev_stop(dev_id);
port_id = dev_conf.nb_event_ports;
dev_conf.nb_event_ports += 1;
+ if (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_SINGLE_LINK)
+ dev_conf.nb_single_link_event_port_queues += 1;
+
ret = rte_event_dev_configure(dev_id, &dev_conf);
if (ret) {
RTE_EDEV_LOG_ERR("failed to configure event dev %u\n",
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_event_eth_rx_adapter.h
index d0e7d0092c..b7e75ff646 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.h
+++ b/lib/eventdev/rte_event_eth_rx_adapter.h
@@ -382,6 +382,19 @@ int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,
* control in configuration of the service, it should use the
* rte_event_eth_rx_adapter_create_ext() version.
*
+ * When this API is used for creating adapter instance, eventdev is
+ * reconfigured with additional ``rte_event_dev_config::nb_event_ports``
+ * parameter during service initialization. This eventdev reconfig logic also
+ * increment the ``rte_event_dev_config::nb_single_link_event_port_queues``
+ * parameter if the adapter event port config is of type
+ * ``RTE_EVENT_PORT_CFG_SINGLE_LINK``.
+ *
+ * So the application is no longer need to account for
+ * ``rte_event_dev_config::nb_event_ports`` and
+ * ``rte_event_dev_config::nb_single_link_event_port_queues``
+ * parameters required for eth Rx adapter in eventdev configure when
+ * the adapter is created with this api.
+ *
* @param id
* The identifier of the ethernet Rx event adapter.
*
--
2.25.1
next prev parent reply other threads:[~2022-12-19 5:33 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 5:55 [PATCH " Naga Harish K S V
2022-12-14 5:55 ` [PATCH 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-14 5:55 ` [PATCH 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-14 5:55 ` [PATCH 4/4] eventdev/timer: " Naga Harish K S V
2022-12-14 7:04 ` [PATCH v2 1/4] eventdev/eth_rx: " Naga Harish K S V
2022-12-14 7:04 ` [PATCH v2 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-14 7:04 ` [PATCH v2 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-19 3:51 ` Gujjar, Abhinandan S
2022-12-19 5:45 ` Naga Harish K, S V
2022-12-14 7:04 ` [PATCH v2 4/4] eventdev/timer: " Naga Harish K S V
2022-12-14 7:31 ` [PATCH v2 1/4] eventdev/eth_rx: " Jayatheerthan, Jay
2022-12-14 9:50 ` Naga Harish K, S V
2022-12-19 5:33 ` Naga Harish K S V [this message]
2022-12-19 5:33 ` [PATCH v3 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-19 5:49 ` Gujjar, Abhinandan S
2022-12-19 5:33 ` [PATCH v3 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-19 5:49 ` Gujjar, Abhinandan S
2022-12-19 5:33 ` [PATCH v3 4/4] eventdev/timer: " Naga Harish K S V
2022-12-19 5:56 ` Gujjar, Abhinandan S
2022-12-19 6:20 ` [PATCH v4] " Naga Harish K S V
2022-12-19 5:48 ` [PATCH v3 1/4] eventdev/eth_rx: " Gujjar, Abhinandan S
2022-12-19 6:28 ` [PATCH v4 " Naga Harish K S V
2022-12-19 6:28 ` [PATCH v4 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-19 6:28 ` [PATCH v4 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-19 6:28 ` [PATCH v4 4/4] eventdev/timer: " Naga Harish K S V
2022-12-19 17:18 ` Carrillo, Erik G
2022-12-20 9:14 ` Naga Harish K, S V
2022-12-20 8:12 ` [PATCH v5 1/4] eventdev/eth_rx: " Naga Harish K S V
2022-12-20 8:12 ` [PATCH v5 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-20 8:12 ` [PATCH v5 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-20 8:12 ` [PATCH v5 4/4] eventdev/timer: " Naga Harish K S V
2022-12-20 9:11 ` [PATCH v5 1/4] eventdev/eth_rx: " Naga Harish K S V
2022-12-20 9:11 ` [PATCH v5 2/4] eventdev/eth_tx: " Naga Harish K S V
2022-12-20 9:11 ` [PATCH v5 3/4] eventdev/crypto: " Naga Harish K S V
2022-12-20 9:11 ` [PATCH v5 4/4] eventdev/timer: " Naga Harish K S V
2022-12-21 6:03 ` [PATCH v5 1/4] eventdev/eth_rx: " Naga Harish K, S V
2023-01-02 5:14 ` Naga Harish K S V
2023-01-02 5:14 ` [PATCH v5 2/4] eventdev/eth_tx: " Naga Harish K S V
2023-01-02 5:14 ` [PATCH v5 3/4] eventdev/crypto: " Naga Harish K S V
2023-01-02 5:14 ` [PATCH v5 4/4] eventdev/timer: " Naga Harish K S V
2023-01-04 6:41 ` [PATCH v6 1/4] eventdev/eth_rx: " Naga Harish K S V
2023-01-04 6:41 ` [PATCH v6 2/4] eventdev/eth_tx: " Naga Harish K S V
2023-01-04 6:41 ` [PATCH v6 3/4] eventdev/crypto: " Naga Harish K S V
2023-01-04 6:41 ` [PATCH v6 4/4] eventdev/timer: " Naga Harish K S V
2023-01-12 7:06 ` Jerin Jacob
2023-01-12 16:32 ` Naga Harish K, S V
2023-01-12 16:30 ` [PATCH v7 1/4] eventdev/eth_rx: " Naga Harish K S V
2023-01-12 16:30 ` [PATCH v7 2/4] eventdev/eth_tx: " Naga Harish K S V
2023-01-12 16:30 ` [PATCH v7 3/4] eventdev/crypto: " Naga Harish K S V
2023-01-12 16:30 ` [PATCH v7 4/4] eventdev/timer: " Naga Harish K S V
2023-01-13 13:51 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221219053315.2538180-1-s.v.naga.harish.k@intel.com \
--to=s.v.naga.harish.k@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).