From: Rongwei Liu <rongweil@nvidia.com>
To: <matan@nvidia.com>, <viacheslavo@nvidia.com>, <orika@nvidia.com>,
<thomas@monjalon.net>, Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Cc: <dev@dpdk.org>, <rasland@nvidia.com>
Subject: [RFC 9/9] app/testpmd: raw encap with flex item support
Date: Wed, 21 Dec 2022 09:39:18 +0200 [thread overview]
Message-ID: <20221221073918.3581151-10-rongweil@nvidia.com> (raw)
In-Reply-To: <20221221073918.3581151-1-rongweil@nvidia.com>
Application should retrieve raw_encap buffer from
spec->pattern if it is flex item.
Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
---
app/test-pmd/cmdline_flow.c | 26 +++++++++++++++++---------
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 1158da2122..b5f13f797a 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -12540,6 +12540,7 @@ cmd_set_raw_parsed(const struct buffer *in)
uint16_t proto = 0;
uint16_t idx = in->port; /* We borrow port field as index */
int gtp_psc = -1; /* GTP PSC option index. */
+ const void *src_spec;
if (in->command == SET_SAMPLE_ACTIONS)
return cmd_set_raw_parsed_sample(in);
@@ -12563,6 +12564,7 @@ cmd_set_raw_parsed(const struct buffer *in)
item = in->args.vc.pattern + i;
if (item->spec == NULL)
item->spec = flow_item_default_mask(item);
+ src_spec = item->spec;
switch (item->type) {
case RTE_FLOW_ITEM_TYPE_ETH:
size = sizeof(struct rte_ether_hdr);
@@ -12690,9 +12692,13 @@ cmd_set_raw_parsed(const struct buffer *in)
size = sizeof(struct rte_flow_item_pfcp);
break;
case RTE_FLOW_ITEM_TYPE_FLEX:
- size = item->spec ?
- ((const struct rte_flow_item_flex *)
- item->spec)->length : 0;
+ if (item->spec != NULL) {
+ size = ((const struct rte_flow_item_flex *)item->spec)->length;
+ src_spec = ((const struct rte_flow_item_flex *)item->spec)->pattern;
+ } else {
+ size = 0;
+ src_spec = NULL;
+ }
break;
case RTE_FLOW_ITEM_TYPE_GRE_OPTION:
size = 0;
@@ -12725,12 +12731,14 @@ cmd_set_raw_parsed(const struct buffer *in)
fprintf(stderr, "Error - Not supported item\n");
goto error;
}
- *total_size += size;
- rte_memcpy(data_tail - (*total_size), item->spec, size);
- /* update some fields which cannot be set by cmdline */
- update_fields((data_tail - (*total_size)), item,
- upper_layer);
- upper_layer = proto;
+ if (size) {
+ *total_size += size;
+ rte_memcpy(data_tail - (*total_size), src_spec, size);
+ /* update some fields which cannot be set by cmdline */
+ update_fields((data_tail - (*total_size)), item,
+ upper_layer);
+ upper_layer = proto;
+ }
}
if (verbose_level & 0x1)
printf("total data size is %zu\n", (*total_size));
--
2.27.0
next prev parent reply other threads:[~2022-12-21 7:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 7:39 [RFC 0/9] add hws flex item matching and modify field Rongwei Liu
2022-12-21 7:39 ` [RFC 1/9] ethdev: add flex item modify field support Rongwei Liu
2022-12-21 7:39 ` [RFC 2/9] app/testpmd: add flex item modify field cmdline support Rongwei Liu
2022-12-21 7:39 ` [RFC 3/9] app/testpmd: pass flex handle into matching mask Rongwei Liu
2022-12-21 7:39 ` [RFC 4/9] net/mlx5: enable hws flex item create Rongwei Liu
2022-12-21 7:39 ` [RFC 5/9] net/mlx5: add IPv6 protocol as flex item input Rongwei Liu
2022-12-21 7:39 ` [RFC 6/9] net/mlx5/hws: add hws flex item matching support Rongwei Liu
2022-12-21 7:39 ` [RFC 7/9] net/mlx5/hws: add flex item modify field implementation Rongwei Liu
2022-12-21 7:39 ` [RFC 8/9] net/mlx5: return error for sws modify field Rongwei Liu
2022-12-21 7:39 ` Rongwei Liu [this message]
2022-12-21 8:39 [RFC 0/9] support flex item matching and " Rongwei Liu
2022-12-21 8:40 ` [RFC 9/9] app/testpmd: raw encap with flex item support Rongwei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221221073918.3581151-10-rongweil@nvidia.com \
--to=rongweil@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).