From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 742EDA0093; Fri, 23 Dec 2022 08:34:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 188C940698; Fri, 23 Dec 2022 08:34:31 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 5A7BF40141; Fri, 23 Dec 2022 08:34:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671780869; x=1703316869; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=LXlSe5jWmGbTF1WWewzeuoYvcJ64SCC2BaBf7x2gLKM=; b=c8GNET+iIHTqjsgkFv6YHTDPqzNnSV83oN4dbxyIu9ALCMdg02/Xa2rm M4TL0sGXXJdJDX4PYlTV55BAbUK4dBtahEcq3fLeKfbUI8yYa/bMPq43l kz1ytiIgVea3aTvs9PVRI1LouLdRZTWM1kJsWwtA3vJ9oVVn/vxXgFj2T Dypah4Uki4MnDcOuiMNcX8WFTT+1cud6LJ1ZZ3KLdXMisBfoFTGNPmEjz H+4XyqR8kHEiZz7uNbRS0XToCHwJyqRHHtS1AzyAKXY3gzy3SOjODWqri 2quoCVnAPMXxfoA2qFGxXbkSCT+wMIamzPV/zYCpBG7tIlStULJEMwd/Y w==; X-IronPort-AV: E=McAfee;i="6500,9779,10569"; a="406529669" X-IronPort-AV: E=Sophos;i="5.96,267,1665471600"; d="scan'208";a="406529669" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2022 23:34:28 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10569"; a="759276141" X-IronPort-AV: E=Sophos;i="5.96,267,1665471600"; d="scan'208";a="759276141" Received: from unknown (HELO yemj..) ([10.239.252.253]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Dec 2022 23:34:25 -0800 From: Mingjin Ye To: dev@dpdk.org Cc: qiming.yang@intel.com, stable@dpdk.org, yidingx.zhou@intel.com, Mingjin Ye , Qi Zhang , Ranjit Menon , Jie Zhou , Pallavi Kadam , Ferruh Yigit Subject: [PATCH v7] doc: add PMD known issue Date: Fri, 23 Dec 2022 15:32:41 +0800 Message-Id: <20221223073242.6783-1-mingjinx.ye@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221121025443.190608-1-mingjinx.ye@intel.com> References: <20221121025443.190608-1-mingjinx.ye@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add a known issue: Rx path dynamic routing is not supported for PMD. Fixes: de853a3bb151 ("net/ice: disable DDP package on Windows") Cc: stable@dpdk.org Signed-off-by: Mingjin Ye --- doc/guides/nics/ice.rst | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index ce075e067c..53f2e9cb71 100644 --- a/doc/guides/nics/ice.rst +++ b/doc/guides/nics/ice.rst @@ -395,3 +395,26 @@ file is used by both the kernel driver and the DPDK PMD. Windows support: The DDP package is not supported on Windows so, loading of the package is disabled on Windows. + +ice: Rx path is not supported after PF or DCF add vlan offload +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +If pmd does not enable Vlan offload during initialization, it will +automatically select Rx paths that do not support offload. Even if +Vlan offload is subsequently enabled through the API, Vlan offload +will not work because the selected Rx path does not support Vlan +offload. + +cmd_vlan_offload_parsed() goes down to the follow ethdev API functions: + - rte_eth_dev_set_vlan_strip_on_queue() + - rte_eth_dev_set_vlan_offload() +These functions add offload settings when the port is started, running, +and processing traffic. At this time, ``rte_eth_rx_queue_setup`` api is +needed to reroute rxq to the RX path with offload function. But at this +time, it is possible that the original Rx path is handling packages, so +this is not thread-safe. + +When applying offload on the PF or DCF, starting the ``testpmd`` +application, use the ``--rx-offloads`` startup parameter to force the +dpdk lib to choose the Rx path with the offload function by default. + -- 2.34.1