From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEE29A0032; Mon, 26 Dec 2022 03:54:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 536FD41181; Mon, 26 Dec 2022 03:54:28 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 9F23C40143; Mon, 26 Dec 2022 03:54:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672023267; x=1703559267; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+f2kjCdR8vYgv6cz2l0tHbPygPvTOTjL76uqsTm6+3s=; b=SZYElDJn1VJPjl5vPQQ85CjXCbqjDUmfro57lnpWU4a3w4rs+VfgtfO8 IGqfdLPrmjFndCQ17q485tVBjIjS6Q5U5zJQ1+TYM9Ab8AVAec/Q7MxXw iJAbW5dKfC2RLAwSGAX5WIJ0HJY4uo5An0CalZlOUzMCV0PDaW/nXOOO2 6s5EeeHXDc4P3ZpNQMDUY+Ht5KrlDZ48dvlp3gPyomQ3BMMlFHthZvlGe BzcnCjnE5PQXGA8wUI4lGlHVPhAam0dB9xjXOW0zmTEjnlcV+ZX66+Ija nBUGTHa+VU7xB13bJlO08eGCmvgjXofkoq2nWtThYC/PZi2qofzlXR3PO Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10571"; a="384932170" X-IronPort-AV: E=Sophos;i="5.96,274,1665471600"; d="scan'208";a="384932170" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2022 18:54:25 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10571"; a="683241416" X-IronPort-AV: E=Sophos;i="5.96,274,1665471600"; d="scan'208";a="683241416" Received: from unknown (HELO yemj..) ([10.239.252.253]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2022 18:54:22 -0800 From: Mingjin Ye To: dev@dpdk.org Cc: qiming.yang@intel.com, stable@dpdk.org, yidingx.zhou@intel.com, Mingjin Ye , Qi Zhang , Jie Zhou , Ranjit Menon , Ferruh Yigit , Pallavi Kadam Subject: [PATCH v7] doc: add PMD known issue Date: Mon, 26 Dec 2022 10:52:44 +0800 Message-Id: <20221226025244.18972-1-mingjinx.ye@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221121025443.190608-1-mingjinx.ye@intel.com> References: <20221121025443.190608-1-mingjinx.ye@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add a known issue: Rx path dynamic routing is not supported for PMD. Fixes: de853a3bb151 ("net/ice: disable DDP package on Windows") Cc: stable@dpdk.org Signed-off-by: Mingjin Ye --- doc/guides/nics/ice.rst | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index ce075e067c..01fb96101f 100644 --- a/doc/guides/nics/ice.rst +++ b/doc/guides/nics/ice.rst @@ -395,3 +395,26 @@ file is used by both the kernel driver and the DPDK PMD. Windows support: The DDP package is not supported on Windows so, loading of the package is disabled on Windows. + +ice: Rx path is not supported after PF or DCF add vlan offload +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +If pmd does not enable Vlan offload during initialization, it will +automatically select Rx paths that do not support offload. Even if +Vlan offload is subsequently enabled through the API, Vlan offload +will not work because the selected Rx path does not support Vlan +offload. + +cmd_vlan_offload_parsed() goes down to the follow ethdev API functions: + - rte_eth_dev_set_vlan_strip_on_queue() + - rte_eth_dev_set_vlan_offload() +These functions add offload settings when the port is started, running +and processing traffic. At this time, ``rte_eth_rx_queue_setup`` api is +needed to reroute rxq to the RX path with offload function. But at this +time, it is possible that the original Rx path is handling packages, so +this is not thread-safe. + +When applying offload on the PF or DCF, starting the ``testpmd`` +application, use the ``--rx-offloads`` startup parameter to force the +dpdk lib to choose the Rx path with the offload function by default. + -- 2.34.1