From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1051A04FD; Wed, 28 Dec 2022 18:01:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C813D40A7F; Wed, 28 Dec 2022 18:01:17 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id AD22840698 for ; Wed, 28 Dec 2022 18:01:16 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id b2so16540687pld.7 for ; Wed, 28 Dec 2022 09:01:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=lhWe2RWqA2Ek0XtNF5IyhZVRLjpv91K0Hkueur4KwXg=; b=ltZEl2cu2L5IUCXr4aWFIrCs1pOGQK7DQnQWFyMoWGC2NoSoIXF5ZxN487HpdJNDfM hHzE4JOVYcg/vS7iQSJ23Vz9IdUY7fSAQnaSpELHmlwxRLVk6Q61KrWSH9iOylkozYgx 1mBgLt+4VphyVnyERAcNPh/PU7ws543Lmopgk2Rmt0OrjCkymyisFFsk3tsQVzf8jqCG vvA1u1MMJry5hqaOtr8PSh41v28k3D9jQecG1dsdM5Udh3WgYEmobxigDxExl6IaFIm6 k4L8EuIYqOeTfMYo2Rt6xZ8FrGlhCLF0eTzww6nGyafMuYIkbXUo1SVgHCws19YQItev ZhQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lhWe2RWqA2Ek0XtNF5IyhZVRLjpv91K0Hkueur4KwXg=; b=WBiZvHnWFDfxV2Jrqin9wlrpg2YkwGxXxR9Ri3gbAWLycKShApHLR68DeLjgsGoqDH vsaLnBP95IMEJf0+r0fp2pIqVtMhUkQn5uMQALK2HrKVTXTfcyOe7g1wKFFBygz9CNfy fAueAn6UC77Q86q+ejVj+kygSqNQTJk2LWSqkAbnywMRVrgFXrlYbvFFNkyDJX1Ls6yR 4elqZciZEgQ+y64TI3XoJQjUTzm2BJURNPM4bZM06oefW9t34lVf0iiDK0emt1EsOd88 HRyzMUneynx+lFV5y7M/psaoADCt9t3z8BsAw7MMBXpMF1JSBAuGBja4CWb1i3KH9QW6 pJnQ== X-Gm-Message-State: AFqh2kqkq7AlW+3LZE667iLdAHuMwpV0ZB9AL4Q4PbqxrNPi58zKZh+6 jMZ1nTC7aDnMKGsvvTM4xh41yA== X-Google-Smtp-Source: AMrXdXvKVtGTLkmSQZEP0rT59RBL2gkj7cbTyhrbZAjSlxVoLYlibhthx8mHSkdGU9X20Za4mroe2A== X-Received: by 2002:a17:902:ebc9:b0:189:cb96:1dbd with SMTP id p9-20020a170902ebc900b00189cb961dbdmr29358406plg.7.1672246875884; Wed, 28 Dec 2022 09:01:15 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id 12-20020a170902e9cc00b00192820d00d0sm5470201plk.120.2022.12.28.09.01.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Dec 2022 09:01:15 -0800 (PST) Date: Wed, 28 Dec 2022 09:01:13 -0800 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: dev@dpdk.org, roretzla@linux.microsoft.com, rmody@marvell.com, timothy.mcdaniel@intel.com, matan@nvidia.com, viacheslavo@nvidia.com, ruifeng.wang@arm.com, zhoumin@loongson.cn, drc@linux.vnet.ibm.com, kda@semihalf.com, bruce.richardson@intel.com, konstantin.v.ananyev@yandex.ru Subject: Re: [PATCH v5 3/4] event/dlb2: remove superfluous rte_memcpy Message-ID: <20221228090113.1671d1fd@hermes.local> In-Reply-To: <20221228151019.101309-3-mb@smartsharesystems.com> References: <20221202153432.131023-1-mb@smartsharesystems.com> <20221228151019.101309-1-mb@smartsharesystems.com> <20221228151019.101309-3-mb@smartsharesystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 28 Dec 2022 16:10:18 +0100 Morten Br=C3=B8rup wrote: > Copying with the same src and dst address has no effect; removed to > avoid compiler warning. >=20 > Signed-off-by: Morten Br=C3=B8rup >=20 > v5: > * First patch in series. > --- > drivers/event/dlb2/dlb2.c | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c > index 60c5cd4804..03d32c779f 100644 > --- a/drivers/event/dlb2/dlb2.c > +++ b/drivers/event/dlb2/dlb2.c > @@ -215,7 +215,6 @@ static int > dlb2_hw_query_resources(struct dlb2_eventdev *dlb2) > { > struct dlb2_hw_dev *handle =3D &dlb2->qm_instance; > - struct dlb2_hw_resource_info *dlb2_info =3D &handle->info; > int num_ldb_ports; > int ret; > =20 > @@ -277,8 +276,6 @@ dlb2_hw_query_resources(struct dlb2_eventdev *dlb2) > handle->info.hw_rsrc_max.reorder_window_size =3D > dlb2->hw_rsrc_query_results.num_hist_list_entries; > =20 > - rte_memcpy(dlb2_info, &handle->info.hw_rsrc_max, sizeof(*dlb2_info)); > - > return 0; > } Please add Fixes and CC author. Fixes: e7c9971a857a ("event/dlb2: add probe-time hardware init") Cc: timothy.mcdaniel@intel.com Acked-by: Stephen Hemminger