From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72ABFA04A5; Wed, 9 Feb 2022 14:37:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFABE41143; Wed, 9 Feb 2022 14:37:58 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id C79DC40140 for ; Wed, 9 Feb 2022 14:37:57 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 53BB05C006A; Wed, 9 Feb 2022 08:37:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 09 Feb 2022 08:37:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=Xohfrqd9PKeOXQ ia7VPe49ZaHhscdh+n04W7AiqDsAU=; b=Fmtt2J8FHZsMZQ4BM9oGUtMGlo9D9e 8HR2Dr1EPGm2QcDXQpWvhoLT6/epSNeJwBVpOVWCZ+VyRon1Qr0SDQLld0BNFAYI oRLUFoMqWTg05r/lAx1ofUJ29DTI9YaRkA4RrLpAN9Mo1pkNUHvzxo2StOz02QRU p1ZfmF+U4nxB5EZwnapd4BN1cW6gVe7nUdktq6M16cyg/gwDQJdgKZlmoK5PjuvR jpSJeWTLh2hiBENXuU28rD4cwyjDvtKU0Je6WqWzyRQYSgHz5ev3FCKw6jvo6kMJ 4vgajnjPztMnZ+aIVt+f/RJ4rhlITBDFS0avaX4oIpbiM8BD9GKdfy+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Xohfrqd9PKeOXQia7VPe49ZaHhscdh+n04W7AiqDs AU=; b=bFLh060aLh5TSZd2zlVDoRbS9UxL0tB+SyS4S/Chzwq97v7P7yZ30jOWE 5YQ24BuC21HGOjEZvlJiyyG6Y2vqpqR2sM49fU8cD7fHgQYEJxJ1bSWBwfOlRaVD 5h0MFnkQ4CPr/gacPXWXCV3Eu8zaQa9+aerC/2QlM/N4Oaf28oGnNgyLOnUBQqcu /mQmkwR/Hzv5nyFtkC6d0bw3UNS79vlar6/yC8otCnIlXNdh5Nwp6mwBDLd0+LlJ HLA3notRpinSiXrAVTT8FPasygh5xhQeiT70DMw/7cTy4oyZ3tmTVSs0AGgilKYb wymcGUKr4nEhh7BbOdhrzxRx82NhA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheelgdehfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Feb 2022 08:37:56 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com, Michael Santana , Lincoln Lavoie , Owen Hilyard , Aaron Conole Subject: Re: [PATCH] ci: remove outdated default reference tag for ABI Date: Wed, 09 Feb 2022 14:37:55 +0100 Message-ID: <2022216.KlZ2vcFHjT@thomas> In-Reply-To: References: <20220208134715.796609-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 08/02/2022 16:08, Aaron Conole: > Thomas Monjalon writes: > > > The variable REF_GIT_TAG is set in the CI configuration > > like .travis.yml or .github/workflows/build.yml. > > The default value is outdated and probably unused. > > It is removed completely to avoid forgetting an update in future. > > > > Signed-off-by: Thomas Monjalon > > --- > > I think the default was there for labs that run the build script > manually. Maybe there are no such users, though. I believe the lab has > its own script for doing such ABI checks (but can't remember off the top > of my head). > > CC'd Lincoln and Owen just to confirm. > > Assuming the UNH/other lab doesn't use this feature of the linux build > script, > > Acked-by: Aaron Conole I could also remove this variable: LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6} It is confusing to see an old version here, while we use the version 1.8. If no objection, I'll send a v2.