From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34C65A00C2; Wed, 4 Jan 2023 17:18:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 23DB540FDF; Wed, 4 Jan 2023 17:18:37 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id AE0204067B for ; Wed, 4 Jan 2023 17:18:35 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id a30so7559819pfr.6 for ; Wed, 04 Jan 2023 08:18:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BsEslXqW0BQriMTQQJbppte7tC3IQN7ZyBzjbaPRIeQ=; b=UdZmLsBNyCNXCV2LWOJu3137WGKT41XY8EpKRb48Bp+oxY8Tx+IHN1v8FcZGgSiazA J8TEzl0m3Kr7/Axz7Kcdg00/CNVadPYzBP5z2IjOh6jSoL2w6ZPSIjRkbjk3V+JDWBAF 6cr0LtMi4Napnwt3nmGkkAuWDA+jM1SMl8acpPU5lzgTi4WhiDvhrRc8AN2v0f72g48u I35bBPPTaUoNntgOhBYQWheJIIl4tslKnsQJgsWv+tjP2FRfl69yhtPZizB/4XlDellH c01RY+gUu6dhBHNfZBpg85Hzl4Znr+6w1MswEgWnLXBD00SwjyFIruZGXSvw0r+X3Ck+ PSog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BsEslXqW0BQriMTQQJbppte7tC3IQN7ZyBzjbaPRIeQ=; b=i3YYaF1fHM3RR3+qktT189d2ISZRUgJ2JR1b2Veruqz5qK/j2t1L8cpH3iMEM1cQOy gKiJH2gWTcbksHQpWAouurWs1NPsStHV2MZzOtzNIpPaE1dq++NBI+p42THC3nNNtSta Bod6a5cPnRmTfDalygURq3trQzLTOctSEoEBN/85kKqKIwXSxyncvh/oS3ABz/BTKgkT dzAMIe5YZbIjuB0aVyI9P1X9vdnyUg2VsGBNi/RyMlr5VnnokUXlgzFmfM0nsubB/1jk c7XYqO3a9s2UnZIaeUoDJp99Y6tValUw9DngU/XsxurRZ8f2XdKlyku+e/0YifanloXu WSeg== X-Gm-Message-State: AFqh2kpmM3dbgxgO+Q4OeyaZh8dqRVDDEnw5PVhR4F8HYYOjII4eym9J 1bTniGI22ePyMpfEBpGd4rCqgA== X-Google-Smtp-Source: AMrXdXtm9sSrUzH4P5t6JW5/0PxRLPb0az/VBCI1nFfz4Vyw7HIyECXdRgPoD6t5XEyYVUkWecoRxw== X-Received: by 2002:aa7:972f:0:b0:581:e84f:2d00 with SMTP id k15-20020aa7972f000000b00581e84f2d00mr18440200pfg.12.1672849114765; Wed, 04 Jan 2023 08:18:34 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id i123-20020a625481000000b00574ebfdc721sm23505962pfb.16.2023.01.04.08.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 08:18:34 -0800 (PST) Date: Tue, 3 Jan 2023 19:04:50 -0800 From: Stephen Hemminger To: Ben Magistro Cc: dev@dpdk.org, ben.magistro@trinitycyber.com, stable@dpdk.org Subject: Re: [PATCH 3/6] app/dumpcap: fix preserving promiscuous mode Message-ID: <20230103190450.1f072ae4@hermes.local> In-Reply-To: <20230102162441.6205-3-koncept1@gmail.com> References: <20230102162441.6205-1-koncept1@gmail.com> <20230102162441.6205-3-koncept1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 2 Jan 2023 16:24:38 +0000 Ben Magistro wrote: > When stopping dumpcap and the main application set an interface to > promiscuous mode, it would be disabled when dumpcap performed its > cleanup. This results in a change of behavior for the main application > after running/utilizing dumpcap. The initial promiscuous mode is now > stored and compared when cleaning up allowing that to be preserved. > > Fixes: d59fb4d ("app/dumpcap: add new packet capture application") > Cc: stephen@networkplumber.org > Cc: stable@dpdk.org > > Signed-off-by: Ben Magistro What I did in the fix patch set add promisc_mode flag to existing interface array.