From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA63DA00C2; Thu, 5 Jan 2023 00:46:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 935D04067B; Thu, 5 Jan 2023 00:46:07 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 1AB7440041 for ; Thu, 5 Jan 2023 00:46:06 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 5F28E208FFD6; Wed, 4 Jan 2023 15:46:05 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5F28E208FFD6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1672875965; bh=/D3kv+Y5/YDjU9iMfY5bJ0jb3YpYJOvZC32NiqRtS1A=; h=Date:From:To:Subject:References:In-Reply-To:From; b=MwS1b0xc+r2jAhO6AW+nHn/45CTqinpuZCeN4sImHQAfwsd+5EYYPkuYyXb6x2z9n c6sgZia3+Opi4aO2oOyGgYlaIkVZgwRwp7csA2/jiskgi2c1u1I9CXivZUOBlfhRHT a13A8DzZNjoxB1WzZVkHw7663iCAfsjWgxqws3/U= Date: Wed, 4 Jan 2023 15:46:05 -0800 From: Tyler Retzlaff To: dev@dpdk.org, david.marchand@redhat.com, thomas@monjalon.net Subject: Re: [PATCH v2 0/2] eal: provide leading and trailing zero bit count Message-ID: <20230104234605.GA1159@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1669241687-18810-1-git-send-email-roretzla@linux.microsoft.com> <1669246997-30592-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1669246997-30592-1-git-send-email-roretzla@linux.microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org hi just adding a few extra folks to the to line to try and get some reviewer attention since this patch has been sitting here for a while. the change is fairly straight forward, would just like to get it cleared. feedback is appreciated! thanks On Wed, Nov 23, 2022 at 03:43:15PM -0800, Tyler Retzlaff wrote: > Provide leading and trailing zero bit count functions to abstract away > compiler specific implementations. > > Include basic unit test for new leading/trailing zero bit count functions. > > v2: > * use unsigned int instead of unsigned (checkpatches) > * match multiple include guard naming convention to rte_common.h > * add explicit extern "C" linkage to rte_bitcount.h > note: not really needed but checkpatches required > * add missing space around '-' > > Tyler Retzlaff (2): > eal: provide leading and trailing zero bit count abstraction > test/bitcount: add bitcount tests > > app/test/meson.build | 2 + > app/test/test_bitcount.c | 92 ++++++++++++++ > lib/eal/include/meson.build | 1 + > lib/eal/include/rte_bitcount.h | 265 +++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 360 insertions(+) > create mode 100644 app/test/test_bitcount.c > create mode 100644 lib/eal/include/rte_bitcount.h > > -- > 1.8.3.1