From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id AA055A00C2;
Thu, 5 Jan 2023 17:40:55 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4FD9A4067C;
Thu, 5 Jan 2023 17:40:55 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id 8DDF84021E;
Thu, 5 Jan 2023 17:40:53 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
id C2DEB208FFCD; Thu, 5 Jan 2023 08:40:52 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C2DEB208FFCD
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1672936852;
bh=Ao0EJi1njcVPzd1rljcfmVLrl1Se3RUivSDwsNUthgo=;
h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
b=rZOtV92OvDkIHfTgJh394jiBa+GzUHwFWbR5BUjH5NlYNHTlIbsXLaGZka162VuYN
tNk4VZtAr1kMJaCT7l72YVjLzE/k0Vy6/AZh/5AVIkZT1+4fFg+lvmSCWiJ2AMLTFt
8o8sgOcGAuuqMKWJaPx94EasFPwdbfuAiC4gdxGk=
Date: Thu, 5 Jan 2023 08:40:52 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Tal Shnaiderman <talshn@nvidia.com>,
stable@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Narcisa Vasile <"navasile@linux.microsoft.comnavasile"@microsoft.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Keith Wiles <keith.wiles@intel.com>
Subject: Re: [PATCH 1/3] eal/windows: fix pedantic build
Message-ID: <20230105164052.GA9408@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20230105161020.247780-1-thomas@monjalon.net>
<20230105161020.247780-2-thomas@monjalon.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230105161020.247780-2-thomas@monjalon.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Thu, Jan 05, 2023 at 05:10:18PM +0100, Thomas Monjalon wrote:
> MinGW GCC 12 shows an illegal pointer conversion
> when included in a pedantic module:
>
> lib/eal/windows/include/pthread.h:137:41: error:
> ISO C forbids conversion of object pointer to function pointer type
> [-Werror=pedantic]
> 137 | hThread = CreateThread(NULL, 0, (LPTHREAD_START_ROUTINE)threadfunc,
> | ^
>
> Fixes: e8428a9d89f1 ("eal/windows: add some basic functions and macros")
> Cc: stable@dpdk.org
>
> By using uintptr_t, the compiler is forced to accept the conversion.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>