From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4969A00C2; Thu, 5 Jan 2023 18:27:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB8D242D1A; Thu, 5 Jan 2023 18:27:14 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 2440240DFF for ; Thu, 5 Jan 2023 18:27:13 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 66F2D20B92A6; Thu, 5 Jan 2023 09:27:12 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 66F2D20B92A6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1672939632; bh=yj8jnpMcM/nhuPpFhMNeZ8QN8MDl1AanuTjiCAHwaQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nlQ7tgZtoUChsdbbkMDRzeggC8rHWlIiRfEeQAseO5y/6Km6Iy5HoL2og3R5ZsGgl SHp6WYb/fmaSIkPsi0QpRTgG9e75YV8/JGqRIpZE/l7ZzRCrE6Y+w7Oz935De+r/97 RgQbVFJO/AOOMVp0gXIFkgW1H/0qWmBaroqYYwxo= Date: Thu, 5 Jan 2023 09:27:12 -0800 From: Tyler Retzlaff To: Thomas Monjalon Cc: Morten =?iso-8859-1?Q?Br=F8rup?= , dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH v2 1/2] eal: provide leading and trailing zero bit count abstraction Message-ID: <20230105172712.GD9408@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1669241687-18810-1-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35D87520@smartserver.smartshare.dk> <20221128172756.GC28869@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <3140231.5fSG56mABF@thomas> <20230105172349.GC9408@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230105172349.GC9408@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 05, 2023 at 09:23:49AM -0800, Tyler Retzlaff wrote: > On Thu, Jan 05, 2023 at 10:04:46AM +0100, Thomas Monjalon wrote: > > 28/11/2022 18:27, Tyler Retzlaff: > > > On Mon, Nov 28, 2022 at 06:22:10PM +0100, Morten Brørup wrote: > > > > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > > > > Sent: Monday, 28 November 2022 18.14 > > > > > > > > > > On Thu, Nov 24, 2022 at 11:17:23AM +0100, Morten Brørup wrote: > > > > > > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > > > > > > Sent: Thursday, 24 November 2022 00.43 > > > > > > > > > > > > > > Provide an abstraction for leading and trailing zero bit counting > > > > > > > functions to hide compiler specific intrinsics and builtins. > > > > > > > > > > > > > > Signed-off-by: Tyler Retzlaff > > > > > > > > > > let me unpack what is being asked for here. > > > > > > > > > > > Related functions already exist in lib/eal/include/rte_common.h. > > > > > > > > > > i don't understand. are you saying these inline functions duplicate > > > > > existing bit counting functionality? if so i'll relocate any you > > > > > identify. > > > > > > > > Sorry about not being clear about my intentions with the feedback. > > > > > > > > I'm not asking for anything; I only wanted to point at the similar family of functions in rte_common.h, to make sure that you were aware of them. > > > > > > oh! not a problem. i'm very keen to catch any mistakes, thought i had > > > missed something. > > > > I think we should move all bit-related functions together. > > Please could you add another patch to your series > > moving "ms1b"/"bsf"/"fls" functions in this file? > > > > > > okay, so there is already a rte_bitops.h. i guess everything should go > there including the leading/trailing count functions instead of adding a > new header. > > i'll introduce a new patch to the series that gathers the existing > functions into rte_bitops.h and place the new functions there too. > > thanks just as a further follow up, you do understand that this is technically an api break? moving functions from rte_common.h to rte_bitops.h will make translation units that included only rte_common.h but used these functions will fail to compile without being updated to include rte_bitops.h. anyway, i'll submit v3 with this change anyway.