From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E272E42385;
	Mon,  9 Jan 2023 17:57:34 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8C13940689;
	Mon,  9 Jan 2023 17:57:34 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 6924A40150
 for <dev@dpdk.org>; Mon,  9 Jan 2023 17:57:33 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id ACB0620B92A8; Mon,  9 Jan 2023 08:57:32 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com ACB0620B92A8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1673283452;
 bh=8G4QySTr7fbGttTRgcr853Y/Xakk4oNWzRdVY4fIinA=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=VF8eIW8Rrd6eWbnIxFFU+RjMRFTgd0S3IECagILR2ckSs5R3wXv4S9imWI48OLNs3
 Fy0BgeRobgxogDPwHA1IK6hvkJJ5m8amQMkouoJoNWezLGQlmFLMQYVrgL2tVQB8V3
 JTXSCm0CVyWEAgHtx4RxWTcTvW/sGPFQyijTdqcs=
Date: Mon, 9 Jan 2023 08:57:32 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, mb@smartsharesystems.com, david.marchand@redhat.com
Subject: Re: [PATCH v3 3/3] test/bitcount: add bitcount tests
Message-ID: <20230109165732.GA7846@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1669241687-18810-1-git-send-email-roretzla@linux.microsoft.com>
 <1673042505-756-1-git-send-email-roretzla@linux.microsoft.com>
 <1673042505-756-4-git-send-email-roretzla@linux.microsoft.com>
 <2951079.mvXUDI8C0e@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2951079.mvXUDI8C0e@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Sat, Jan 07, 2023 at 09:15:27AM +0100, Thomas Monjalon wrote:
> 06/01/2023 23:01, Tyler Retzlaff:
> > basic unit test of following functions
> > 
> >     rte_clz32
> >     rte_clz64
> >     rte_ctz32
> >     rte_ctz64
> 
> This can be squashed with implementation in previous patch.
> 
> 

if you mean squashed into the patch that moves the existing functions
sure it can be, but really the addtions are a self contained change
separate from the move of the existing functions.

ordinarily i'd rather see history order be as follows.

- here is a change that just moves code (no addtions no deletions).
- here is a change that adds new apis (no moves).

you sure you want the move and additions all combined into one change?

either way confirm what you want and if needed i'll combine and push a
v4.

thanks