From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73D3E42394; Tue, 10 Jan 2023 18:05:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A47940A8B; Tue, 10 Jan 2023 18:05:03 +0100 (CET) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 8500640687 for ; Tue, 10 Jan 2023 18:05:01 +0100 (CET) Received: by mail-pj1-f45.google.com with SMTP id o13so9554350pjg.2 for ; Tue, 10 Jan 2023 09:05:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=q039oZeoLSOCCQhWLe+xEOTqRPKmMwm4cbjbdkg2FcU=; b=6q4qHHk0b8ikoOZ87rJ49CRVCqExmydL97bf9EYgmQGRA/W0ibnqXMvC5E3CJdr/nF g4ac6C8zUIc1bzwJMB+Kabnpdlo/z3B5tw4M2edIuFBapE43ibuPSL6LQFiMdh1BzsHP ozuixtZDA9KRXGzPSQFr0CkNTttoKIHIc9Y6S9Ly29Glsa3r6Yt9FBViBU+WwjnA6yr+ ysdKrjt2PbYk48wXvrrN+hWN/VeDsqsnK8Z8dd/CoI/q55jcfzhPZ1M2qtTFJNPQB1eh +60utAXu6tTlDcD04/cMpQC7Bnptdxz9TS/0/c7kiZo5623FFS259o3ADlKr50K65KYD 613g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q039oZeoLSOCCQhWLe+xEOTqRPKmMwm4cbjbdkg2FcU=; b=YDtWt7Kix8kAOmzrT7muC0jK+htfz6qTd7lIhSuW6bSVcc2Rt+gDVcL/Mxw5UZRyzB R8LAr7fxwl1XFSu/pLkfiH32g48rUsEeESGT3M8JkwvticjikrkdkiuY7Zhw6NbiIrE2 n5pSmtcTI/6zeXJRgpG9vFMvNj3AzrIXH00K/Kfi3j1Ni19UeugYEv63p3HNfTMGvUkZ 4yPIh8+XKDI/wNLbmhW9gUhXruQjHFFhG4tvqqkLgwgdZilx8X78vyWVG7ztFL8vU/+7 tnBu1nJtg9RWkCxF8BTsILttub9A6BS6LnKqmlkgkGL1tXs3fCNTp+6R2t7eFNNUElNc SEtw== X-Gm-Message-State: AFqh2kopTIvpxVIMum4XDaaGJRNR705uifOCW+Ni+UusGbSwutN9PsYH 912XzglR5cMBmLJQy9e1tZ8CVQ== X-Google-Smtp-Source: AMrXdXuCSAeYDX8jIo0fXOT+fjdwwb9s5GFm95gYmSmsGzRhtAIs0yK5X/FdjuCxI/xXYmreN+mvIA== X-Received: by 2002:a17:902:a711:b0:192:4ce1:3695 with SMTP id w17-20020a170902a71100b001924ce13695mr70405521plq.57.1673370300645; Tue, 10 Jan 2023 09:05:00 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id a14-20020a1709027e4e00b0019254c19697sm8205944pln.289.2023.01.10.09.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 09:05:00 -0800 (PST) Date: Tue, 10 Jan 2023 09:05:00 -0800 From: Stephen Hemminger To: Amit Prakash Shukla Cc: Reshma Pattan , , Subject: Re: [PATCH v1 1/3] pcapng: comment option support for epb Message-ID: <20230110090500.379b80e4@hermes.local> In-Reply-To: <20230110115847.1965096-1-amitprakashs@marvell.com> References: <20221223120235.3171516-1-amitprakashs@marvell.com> <20230110115847.1965096-1-amitprakashs@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 10 Jan 2023 17:28:45 +0530 Amit Prakash Shukla wrote: > @@ -548,6 +552,11 @@ rte_pcapng_copy(uint16_t port_id, uint32_t queue, > &hash_opt, sizeof(hash_opt)); > } > > + if (comment) { > + opt = pcapng_add_option(opt, PCAPNG_OPT_COMMENT, comment, > + strlen(comment)); > + } > + Minor style nit. Do not add bracket on single statement if clause