From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CF503423BA;
	Thu, 12 Jan 2023 22:32:17 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B578842D36;
	Thu, 12 Jan 2023 22:32:17 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id CB60942D27
 for <dev@dpdk.org>; Thu, 12 Jan 2023 22:32:16 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 23A7120DFE03; Thu, 12 Jan 2023 13:32:16 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 23A7120DFE03
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1673559136;
 bh=53dW/kr0ewhsHYQcJfmH7S8R2nepd7NAmg7aDSFLslU=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=OD2BEGdSHiESOGvc3iaT0qYBVeRNLQCIvjECb8TCuNyBFF5YD9gDQavySU/o66ytH
 /RlKZNlYYkY6ydIumiFXATNydcrbFrPpFIW/mBVRvPXMEKhr4YZ/phTb2cLln0hLkB
 j50uTfIsycFfNEoszziFjKrF2jKbfmDGuzo+9ZCc=
Date: Thu, 12 Jan 2023 13:32:16 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
 Sunil Kumar Kori <skori@marvell.com>, dev@dpdk.org,
 thomas@monjalon.net, olivier.matz@6wind.com,
 stephen@networkplumber.org, mb@smartsharesystems.com
Subject: Re: [PATCH v2 1/4] eal: add thread set name API operating on rte
 thread
Message-ID: <20230112213216.GA15377@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com>
 <1671036441-10234-1-git-send-email-roretzla@linux.microsoft.com>
 <1671036441-10234-2-git-send-email-roretzla@linux.microsoft.com>
 <CAJFAV8ziUWXKJbxZ+N8t4N3fdnLed0Tu0X0xj8BQ8UyNkeMfsw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8ziUWXKJbxZ+N8t4N3fdnLed0Tu0X0xj8BQ8UyNkeMfsw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, Jan 11, 2023 at 05:09:25PM +0100, David Marchand wrote:
> On Wed, Dec 14, 2022 at 5:47 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> > diff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c
> > index 5caaac8..89522dc 100644
> > --- a/lib/eal/common/eal_common_trace.c
> > +++ b/lib/eal/common/eal_common_trace.c
> > @@ -356,8 +356,6 @@ rte_trace_mode rte_trace_mode_get(void)
> >         /* Store the thread name */
> >         char *name = header->stream_header.thread_name;
> >         memset(name, 0, __RTE_TRACE_EMIT_STRING_LEN_MAX);
> > -       rte_thread_getname(pthread_self(), name,
> > -               __RTE_TRACE_EMIT_STRING_LEN_MAX);
> >
> >         trace->lcore_meta[count].mem = header;
> >         trace->nb_trace_mem_list++;
> 
> Note, this belongs to patch 2.

agreed, not sure how i fumbled that. since there has been no reply about
retaining rte_thread_getname as an internal api i'll just move this
change to patch 2.

> I understand we can drop the thread name retrieval helper from public
> API, but at least for the trace framework it added some info in the
> traces.
> Jerin, Sunil, what do you think? Should we keep this helper internally?
> 
> 
> -- 
> David Marchand