From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79D5A41B61; Sat, 14 Jan 2023 00:25:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1FABA40E0F; Sat, 14 Jan 2023 00:25:35 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 188FC40A87 for ; Sat, 14 Jan 2023 00:25:33 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id jl4so24925087plb.8 for ; Fri, 13 Jan 2023 15:25:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=D7Ip9jPsc/QbF/s9UmEPrPHwRNB5Mt9KC8Fg2UJ/kBs=; b=6jKZjgYlIs1lXlWrN/TzbBWJ6jjbG2B135RHZeRsJU4DTD5Yh+G5ZnURYXIpa8PIS7 cuk9i5XqFJ26iAWOUvEID0WamNGBiX7nJ6JMucbRzqdncZWUZIWDl/EnEEQCwKZCFZKv GO/y91Eugz1pNHx/WWKwESCTehQ7fBQsW6WT8MYia/8pakFzw4JSwm+sBX3A8e7CSPY+ iLTXngDTtJnma3GNmqKxT4f8AaKhpleVMdEbHbk7GdLRPAdn2UD1ekFpWjmRoMUrR/9E w7reS0gXd3HF0aOGizeg/pwRCXySRBFfnxH40zdQXleM//kcQXB9n5w7l6T1L97u2ud1 nhvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D7Ip9jPsc/QbF/s9UmEPrPHwRNB5Mt9KC8Fg2UJ/kBs=; b=LL8WRtpu/BMTGATsVAotlwu17P9G9TtE5vQSmXm8TCqCBHlrLFW0zK270oVbsfQkYj iUQA1D9YTN8Ji07tJiumdI3mKF1XzxiSmtNSceHPXU9aowqwyz+eS+mTIKwGBmuzmchN g3Ej5f+rgOn8LXaCPSQ+Fp28unMFPSze1NMu7n/a8E4Hx1jzpt3vQsALlUezQBo535Yk ttpYuAC1hbTAll0QCCgefuYD1D0spXkAu4ENifp7GDrW/eDuw/5GqIskZTYvf8/sJ9r4 p38LVU4p+2KqAM9SOHd2CSFnS5WnGigJZgiJInqh+VgmD1zuFMBH27ctxYWIQ/RRY5Bs SulQ== X-Gm-Message-State: AFqh2kpiIA3DzArFYPo318jD3lgT5JG9esgD8VuyOQGs+Rp1vNePuq/+ DYggXLPKCGdLCufrrulrFJ+vgQ== X-Google-Smtp-Source: AMrXdXsX5NSIszoC9bYRZosCritwv7sutDnp1WfN7IYHAHmrTysviP4bFxROPSeQm/+JLaXty0hWJg== X-Received: by 2002:a05:6a20:9588:b0:b2:549c:b0eb with SMTP id iu8-20020a056a20958800b000b2549cb0ebmr103265904pzb.36.1673652332974; Fri, 13 Jan 2023 15:25:32 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y186-20020a6232c3000000b00571cdbd0771sm14169495pfy.102.2023.01.13.15.25.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jan 2023 15:25:32 -0800 (PST) Date: Fri, 13 Jan 2023 15:25:30 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, Cristian Dumitrescu , Bruce Richardson , Anatoly Burakov Subject: Re: [RFC] Remove Kernel Network Interface (KNI) Message-ID: <20230113152530.634e6d1e@hermes.local> In-Reply-To: <3142342.SvYEEZNnvj@thomas> References: <20230113050313.87378-1-stephen@networkplumber.org> <2383172.OBFZWjSADL@thomas> <20230113091326.20d210c9@hermes.local> <3142342.SvYEEZNnvj@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 13 Jan 2023 19:34:24 +0100 Thomas Monjalon wrote: > 13/01/2023 18:13, Stephen Hemminger: > > On Fri, 13 Jan 2023 09:12:16 +0100 > > Thomas Monjalon wrote: > > > > > 13/01/2023 06:03, Stephen Hemminger: > > > > The Linux special network driver for kernel networking has been > > > > a long term problem for DPDK. The performance benefits of KNI > > > > are available via virtio-user and XDP, and the simpler kernel > > > > interface via TAP is also available. > > > > > > > > This driver has required lots of effort to keep up with the > > > > kernel API changes. And the overall architecture of the driver > > > > is fundamentally insecure and has unfixable locking and data > > > > race problems. No developer has been willing to do extensive > > > > tests or be the maintainer. > > > > > > > > In short, the time has come to do some early spring cleaning > > > > and remove KNI from DPDK 23.03. > > > > > > In doc/guides/rel_notes/deprecation.rst it is announced > > > to be removed in 23.11. Let's keep this RFC for later :) > > > > > > > > > > For 23.03 could we add a deprecation log message when library is > > used and when kernel module is loaded. > > We already have a message in the lib: > > int > rte_kni_init(unsigned int max_kni_ifaces __rte_unused) > { > RTE_LOG(WARNING, KNI, "WARNING: KNI is deprecated and will be removed in DPDK 23.11\n"); > > It is a good idea to add a message in the kernel module loading. > > > > No matter how much we tell users, guarantee someone will still miss it and complain :-)