From: Stephen Hemminger <stephen@networkplumber.org>
To: Vipin P R <vipinp@vmware.com>
Cc: jingjing.wu@intel.com, beilei.xing@intel.com, dev@dpdk.org,
stable@dpdk.org
Subject: Re: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address
Date: Mon, 16 Jan 2023 09:55:31 -0800 [thread overview]
Message-ID: <20230116095531.7a84ff1d@hermes.local> (raw)
In-Reply-To: <1673615963-21216-2-git-send-email-vipinp@vmware.com>
On Fri, 13 Jan 2023 13:19:23 +0000
Vipin P R <vipinp@vmware.com> wrote:
> In case of i40vf, VIRTCHNL_OP_DEL_ETH_ADDR and VIRTCHNL_OP_ADD_ETH_ADDR are unsupported.
> i40evf_execute_vf_cmd is invoked with these operations as part of i40evf_set_mc_addr_list()
>
> The cases are not handled in i40evf_execute_vf_cmd() thus hitting the default case.
> There is a retry logic of upto 200 times (2000 in iavf) with a delay of 10ms (1ms in iavf).
> This results in a needless delay of 2s in the init phase for each VNIC.
>
> The patch aims to rectify that delay.
> In fe2a571c70cc397f2ad4e280f8d084148fea5d62, i40e_ethdev_vf.c was deleted. Hence adding this in iavf_vchnl.c.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Vipin P R <vipinp@vmware.com>
> ---
> drivers/net/iavf/iavf_vchnl.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Please run checkpatch, the DPDK style is to indent with tabs not spaces.
next prev parent reply other threads:[~2023-01-16 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 13:19 [PATCH] *** Intel iavf: Return in the case of ADD/DEL ETH address *** Vipin P R
2023-01-13 13:19 ` [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address Vipin P R
2023-01-16 17:55 ` Stephen Hemminger [this message]
2023-01-17 1:54 ` Zhang, Qi Z
2023-02-07 10:42 ` Vipin P R
2023-02-13 1:31 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116095531.7a84ff1d@hermes.local \
--to=stephen@networkplumber.org \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=vipinp@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).