From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 27A32423FF;
	Tue, 17 Jan 2023 19:22:27 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CBAD342D50;
	Tue, 17 Jan 2023 19:22:08 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 3147342D54
 for <dev@dpdk.org>; Tue, 17 Jan 2023 19:22:07 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 8CD2720DFE9A; Tue, 17 Jan 2023 10:22:06 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8CD2720DFE9A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1673979726;
 bh=Zw/70qDoWL6jDXANBjME6GG3QDIdDbf459uWSZRbKwg=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=S0Ft1Du+YlNLnBdFA+/Y9KAklMTBtGe7FgqFTsjeFnBTzqBOK1XTE7+KpS67XLemC
 Av0mnKpuf6s+/kh8hGSabeUL2dr8RQxCawDCLN5ao3yokC0G5UTtv0yXBpsMTKcO5W
 KGHKK0NcKKXodtd7aSVLpcidw53lsHiiOKzpYK6c=
Date: Tue, 17 Jan 2023 10:22:06 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,
 mb@smartsharesystems.com
Subject: Re: [PATCH v4 2/4] eal: remove thread getname API
Message-ID: <20230117182206.GA8294@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com>
 <1673635923-12432-1-git-send-email-roretzla@linux.microsoft.com>
 <1673635923-12432-3-git-send-email-roretzla@linux.microsoft.com>
 <CALBAE1OBwDqqekD_jNDPqqbDCwjPjH3Qu=81mLAFhvx_0+J45w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALBAE1OBwDqqekD_jNDPqqbDCwjPjH3Qu=81mLAFhvx_0+J45w@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Jan 17, 2023 at 01:19:25PM +0530, Jerin Jacob wrote:
> On Sat, Jan 14, 2023 at 12:22 AM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
> >
> > Remove the rte_thread_getname API.  The API is __rte_experimental and
> > requires no deprecation notice.
> >
> > Fold the platform specific variants into the one place it is used as a
> > special case to retain the functionality for linux only.
> >
> 
> >  void
> >  __rte_trace_mem_per_thread_alloc(void)
> >  {
> > @@ -356,7 +369,7 @@ rte_trace_mode rte_trace_mode_get(void)
> >         /* Store the thread name */
> >         char *name = header->stream_header.thread_name;
> >         memset(name, 0, __RTE_TRACE_EMIT_STRING_LEN_MAX);
> > -       rte_thread_getname(pthread_self(), name,
> > +       rte_thread_get_name(rte_thread_self(), name,
> 
> Since it's a local function. Please change thread_get_name or so?

done