From: Gregory Etelson <getelson@nvidia.com>
To: <dev@dpdk.org>
Cc: <getelson@nvidia.com>, <matan@nvidia.com>, <rasland@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: [PATCH 5/5] mlx5dr: Definer, translate RTE quota item
Date: Wed, 18 Jan 2023 14:55:56 +0200 [thread overview]
Message-ID: <20230118125556.23622-6-getelson@nvidia.com> (raw)
In-Reply-To: <20230118125556.23622-1-getelson@nvidia.com>
MLX5 PMD implements QUOTA with Meter object.
PMD Quota action translation implicitly increments
Meter register value after HW assigns it.
Meter register values are:
HW QUOTA(HW+1) QUOTA state
RED 0 1 (01b) BLOCK
YELLOW 1 2 (10b) PASS
GREEN 2 3 (11b) PASS
Quota item checks Meter register bit 1 value to determine state:
SPEC MASK
PASS 2 (10b) 2 (10b)
BLOCK 0 (00b) 2 (10b)
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
---
drivers/net/mlx5/hws/mlx5dr_definer.c | 61 +++++++++++++++++++++++++++
1 file changed, 61 insertions(+)
diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c
index 6b98eb8c96..40ffb02be0 100644
--- a/drivers/net/mlx5/hws/mlx5dr_definer.c
+++ b/drivers/net/mlx5/hws/mlx5dr_definer.c
@@ -19,6 +19,9 @@
#define STE_UDP 0x2
#define STE_ICMP 0x3
+#define MLX5DR_DEFINER_QUOTA_BLOCK 0
+#define MLX5DR_DEFINER_QUOTA_PASS 2
+
/* Setter function based on bit offset and mask, for 32bit DW*/
#define _DR_SET_32(p, v, byte_off, bit_off, mask) \
do { \
@@ -1134,6 +1137,60 @@ mlx5dr_definer_conv_item_tag(struct mlx5dr_definer_conv_data *cd,
return 0;
}
+static void
+mlx5dr_definer_quota_set(struct mlx5dr_definer_fc *fc,
+ const void *item_data, uint8_t *tag)
+{
+ /**
+ * MLX5 PMD implements QUOTA with Meter object.
+ * PMD Quota action translation implicitly increments
+ * Meter register value after HW assigns it.
+ * Meter register values are:
+ * HW QUOTA(HW+1) QUOTA state
+ * RED 0 1 (01b) BLOCK
+ * YELLOW 1 2 (10b) PASS
+ * GREEN 2 3 (11b) PASS
+ *
+ * Quota item checks Meter register bit 1 value to determine state:
+ * SPEC MASK
+ * PASS 2 (10b) 2 (10b)
+ * BLOCK 0 (00b) 2 (10b)
+ *
+ * item_data is NULL when template quota item is non-masked:
+ * .. / quota / ..
+ */
+
+ const struct rte_flow_item_quota *quota = item_data;
+ uint32_t val;
+
+ if (quota && (quota->state == RTE_FLOW_QUOTA_STATE_BLOCK))
+ val = MLX5DR_DEFINER_QUOTA_BLOCK;
+ else
+ val = MLX5DR_DEFINER_QUOTA_PASS;
+
+ DR_SET(tag, val, fc->byte_off, fc->bit_off, fc->bit_mask);
+}
+
+static int
+mlx5dr_definer_conv_item_quota(struct mlx5dr_definer_conv_data *cd,
+ __rte_unused struct rte_flow_item *item,
+ int item_idx)
+{
+ int mtr_reg = flow_hw_get_reg_id(RTE_FLOW_ITEM_TYPE_METER_COLOR, 0);
+ struct mlx5dr_definer_fc *fc;
+
+ if (mtr_reg < 0)
+ return EINVAL;
+
+ fc = mlx5dr_definer_get_register_fc(cd, mtr_reg);
+ if (!fc)
+ return rte_errno;
+
+ fc->tag_set = &mlx5dr_definer_quota_set;
+ fc->item_idx = item_idx;
+ return 0;
+}
+
static int
mlx5dr_definer_conv_item_metadata(struct mlx5dr_definer_conv_data *cd,
struct rte_flow_item *item,
@@ -1581,6 +1638,10 @@ mlx5dr_definer_conv_items_to_hl(struct mlx5dr_context *ctx,
ret = mlx5dr_definer_conv_item_meter_color(&cd, items, i);
item_flags |= MLX5_FLOW_ITEM_METER_COLOR;
break;
+ case RTE_FLOW_ITEM_TYPE_QUOTA:
+ ret = mlx5dr_definer_conv_item_quota(&cd, items, i);
+ item_flags |= MLX5_FLOW_ITEM_QUOTA;
+ break;
default:
DR_LOG(ERR, "Unsupported item type %d", items->type);
rte_errno = ENOTSUP;
--
2.34.1
next prev parent reply other threads:[~2023-01-18 12:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 12:55 [PATCH 0/5] net/mlx5: add indirect QUOTA create/query/modify Gregory Etelson
2023-01-18 12:55 ` [PATCH 1/5] net/mlx5: update query fields in async job structure Gregory Etelson
2023-01-18 12:55 ` [PATCH 2/5] net/mlx5: remove code duplication Gregory Etelson
2023-01-18 12:55 ` [PATCH 3/5] common/mlx5: update MTR ASO definitions Gregory Etelson
2023-01-18 12:55 ` [PATCH 4/5] net/mlx5: add indirect QUOTA create/query/modify Gregory Etelson
2023-01-18 12:55 ` Gregory Etelson [this message]
2023-03-08 2:58 ` [PATCH 0/5] " Suanming Mou
2023-03-08 17:01 ` [PATCH v2 " Gregory Etelson
2023-03-08 17:01 ` [PATCH v2 1/5] net/mlx5: update query fields in async job structure Gregory Etelson
2023-03-08 17:01 ` [PATCH v2 2/5] net/mlx5: remove code duplication Gregory Etelson
2023-03-08 17:01 ` [PATCH v2 3/5] common/mlx5: update MTR ASO definitions Gregory Etelson
2023-03-08 17:01 ` [PATCH v2 4/5] net/mlx5: add indirect QUOTA create/query/modify Gregory Etelson
2023-03-08 17:01 ` [PATCH v2 5/5] mlx5dr: Definer, translate RTE quota item Gregory Etelson
2023-05-07 7:39 ` [PATCH v3 0/5] net/mlx5: support indirect quota flow action Gregory Etelson
2023-05-07 7:39 ` [PATCH v3 1/5] net/mlx5: update query fields in async job structure Gregory Etelson
2023-05-07 7:39 ` [PATCH v3 2/5] net/mlx5: remove code duplication Gregory Etelson
2023-05-07 7:39 ` [PATCH v3 3/5] common/mlx5: update MTR ASO definitions Gregory Etelson
2023-05-07 7:39 ` [PATCH v3 4/5] net/mlx5: add indirect QUOTA create/query/modify Gregory Etelson
2023-05-07 7:39 ` [PATCH v3 5/5] mlx5dr: Definer, translate RTE quota item Gregory Etelson
2023-05-25 14:18 ` [PATCH v3 0/5] net/mlx5: support indirect quota flow action Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230118125556.23622-6-getelson@nvidia.com \
--to=getelson@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).