From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F172C42412; Thu, 19 Jan 2023 00:13:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8C20940223; Thu, 19 Jan 2023 00:13:17 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 4C3B9400D6 for ; Thu, 19 Jan 2023 00:13:16 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id d8so615548pjc.3 for ; Wed, 18 Jan 2023 15:13:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=NL/9hh6XfHvtouFbOcW3ivEvNAXyOUSf1lal08wfVwk=; b=PjxlGSdI+YP4oib9SOcwyejWcK7vyU3Mh2V5KgN7IdBN39+7AcHVFnh4dWSFj8pCUR AEex9gAltQEpe4IWaQVRViUXax/HmP/q05WNKo4IuQEpyEnnrYLT1ox+/MEWHnlRJu/F p7bNgpC9nIJrQ/drxUyLl8DlEowqnA9RrFj1PsgoeBKnfc+sWjMz+sNgD4PutXuyVfD4 Vf8iVTtYpNa7C4ZvXjo5mgnMmf/mTEvaBhyMiJiAobGvwji5LC6hhbVmNJqLQFCeYggR F+YL3lGzaHlsWFJzofVFhMQMmZ2HAue7eoCbeNFgqHJ7J1IpU1RNXoxdxi9ItL3oeNvu d1nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NL/9hh6XfHvtouFbOcW3ivEvNAXyOUSf1lal08wfVwk=; b=igICWhaqVDsYLWXW6rVL28AsEhsY7t4eRPpp/+0UIUK4jD2H1O9IEpBSenrKxg48uT 7szJADFoDpC0tzDRhPaJS7jaEZ17OeQFVW2gq638ebxCLmrvc02NCWwP9QnvmyeNV45H GsLDtKeg+d9kfr3RPXnWiufgC7RD0c9kSQc0wpr8qKebJTfKNQ1lArVYjm3Zvt51auSw Px23hYVQsDhyH3HLZ7vdhrwGb+XPV+GnBLrC1SQTj3sA2C5orW1htNa/z92Jou6aSxu3 xnWfpK+e1RevGz+SvrUCoUhFgjIPRTg5xd8AgYpr16mI7/AcKU1/WiokabHBXYhtzHnd TuFQ== X-Gm-Message-State: AFqh2krE9/mmBJ2S7nGGLifoTV9Ga60bUtfTr+1h0Zbz7kX9kBqf8iM5 G+WB4kCewk1e3QH0ehEZZAmFcQ== X-Google-Smtp-Source: AMrXdXtrHVj1SlsDqDvyWKD6SuYa6D1OzX5L5ZsnBmC5LSXriH8O6MPWybgvKG3hQeLO4UbJv+9Cgw== X-Received: by 2002:a05:6a21:6d92:b0:b0:3e0f:508d with SMTP id wl18-20020a056a216d9200b000b03e0f508dmr11243099pzb.55.1674083595335; Wed, 18 Jan 2023 15:13:15 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id l16-20020a170902f69000b00177efb56475sm23661727plg.85.2023.01.18.15.13.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Jan 2023 15:13:15 -0800 (PST) Date: Wed, 18 Jan 2023 15:13:12 -0800 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com, jerinjacobk@gmail.com, mb@smartsharesystems.com Subject: Re: [PATCH v6 1/5] eal: add thread set name API operating on rte thread Message-ID: <20230118151312.5659939c@hermes.local> In-Reply-To: <1674071646-6854-2-git-send-email-roretzla@linux.microsoft.com> References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com> <1674071646-6854-1-git-send-email-roretzla@linux.microsoft.com> <1674071646-6854-2-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 18 Jan 2023 11:54:02 -0800 Tyler Retzlaff wrote: > + if (name != NULL) > + rte_thread_set_name((rte_thread_t){(uintptr_t)*thread}, name) Do we really need so many casts here? Looks like the wrong type was passed in the first place?