From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9629E4241E; Thu, 19 Jan 2023 17:48:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89BB242D65; Thu, 19 Jan 2023 17:48:04 +0100 (CET) Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by mails.dpdk.org (Postfix) with ESMTP id 42F62400D5 for ; Thu, 19 Jan 2023 17:48:03 +0100 (CET) Received: by mail-pg1-f174.google.com with SMTP id q9so1983216pgq.5 for ; Thu, 19 Jan 2023 08:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=VUJFC6Pmfrw/LyLlZJYTZxrdnpYJRoJVz6eyK21Xvt4=; b=65PSxCrOFGciSLviNLchYuNqNrDSwocnI/ENAYC/cCKl9qL19ZN/JmV0Q0sF9rghQJ kNWMhT+NeSW2fnO1UAnxRfmkZjEeId0TV0Yf1p8flvUwppIMop3d3heBldGZsQUV4MVi rG2xrzGwRzESHDahpMCS4l3s6kG+xbsO/QNY16ueus3znsOLzJOtyDejiQfDZgheEuqS LndvSh39Che2PqQE5A0Rg9UR15w0JHaMz+H6BETqM4k/6WO62aVdHJhNgLZU6MuDdC3s RQD/Rmw46S3hoka2PCf7z7YmuxborwPy3IEVs/mfw0LyiNayYQykugOjX4m/TQF2XvUD nNfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VUJFC6Pmfrw/LyLlZJYTZxrdnpYJRoJVz6eyK21Xvt4=; b=jp7YF1drNZCqR3ETuxwGUl/Z6LEgNImhxpsfWC6fNvXxMvSnYLh+gRBtmYSNWP35s1 wbrCwN8iTZwAMaE/R/17tNBVA6MrA18P336OeOVs0/079q1b1G91yX1y1F89tBZlrkS+ RHXv0OOiclUVUmy3aXQT4rqRCtrYFt0vo9lwQ8LbKow1+K3NgreNJ8DQA+oI7TDghu5x MHEYi4n/Hthy1N7C+fj4TZm9mDtvL/klo9kAX/Y/1wRXX7mBQkisjD2wmiM57zUPecMd 8UBuUcY/MDF0/f1aP3+CiZODVm0peps0rkARjkq+qTn3MDOt3GpWJVJ4+IyPjzNiuZSA b1XQ== X-Gm-Message-State: AFqh2kr4OxGghnJ7KKP2/vCzUysT7HaJYL1IgGn/gvhA+Z7PvWVx5nYC RDvwHeJtKQXNRIlMRAbsI/3OoA== X-Google-Smtp-Source: AMrXdXv1fYYSdlPcGy/V527xQ+RfmE/0kSjfsKw4XUlKyLW/XIwGSAiNiKsUCmKdcgnq26WIwXc9ng== X-Received: by 2002:aa7:865a:0:b0:582:13b6:d2da with SMTP id a26-20020aa7865a000000b0058213b6d2damr12529476pfo.5.1674146882478; Thu, 19 Jan 2023 08:48:02 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id c205-20020a624ed6000000b00580a0bb411fsm3467625pfb.174.2023.01.19.08.48.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jan 2023 08:48:02 -0800 (PST) Date: Thu, 19 Jan 2023 08:48:00 -0800 From: Stephen Hemminger To: Amit Prakash Shukla Cc: Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , "dev@dpdk.org" Subject: Re: [EXT] Re: [PATCH v2 2/3] graph: pcap capture for graph nodes Message-ID: <20230119084800.7307063b@hermes.local> In-Reply-To: References: <20230110115847.1965096-1-amitprakashs@marvell.com> <20230111085343.2058993-1-amitprakashs@marvell.com> <20230111085343.2058993-2-amitprakashs@marvell.com> <20230111080710.0a6f1fb8@hermes.local> <20230112083024.17c68431@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 19 Jan 2023 14:37:49 +0000 Amit Prakash Shukla wrote: > > > > One other option is to add a new custom block type or options in pcapng. > > Keep comment as a string, since that is what wireshark etc no how to handle. > > Also, packet id data might be useful for graph. > > I gave a try by adding a support for custom options in libpcapng, but it seems wireshark does not support PEN in custom options as of now. > Wireshark was not dissecting dummy PEN that was passed in custom option. Wireshark is not too difficult to add new types to. I added support for RSS hash option to wireshark. You might get good feedback on this from others. Maybe discuss on the wireshark or pcapng mailing list.