DPDK patches and discussions
 help / color / mirror / Atom feed
From: okaya@kernel.org
To: Thomas Monjalon <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@amd.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org, Sinan Kaya <okaya@kernel.org>
Subject: [PATCH v3 01/10] ethdev: check return result of rte_eth_dev_info_get
Date: Thu, 19 Jan 2023 23:41:31 -0500	[thread overview]
Message-ID: <20230120044140.95975-2-okaya@kernel.org> (raw)
In-Reply-To: <20230120044140.95975-1-okaya@kernel.org>

From: Sinan Kaya <okaya@kernel.org>

rte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get
is not checked, potentially leaving dev_info uninitialized.

Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
 lib/ethdev/rte_class_eth.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/ethdev/rte_class_eth.c b/lib/ethdev/rte_class_eth.c
index 838b3a8f9f..559ce22491 100644
--- a/lib/ethdev/rte_class_eth.c
+++ b/lib/ethdev/rte_class_eth.c
@@ -50,8 +50,10 @@ eth_mac_cmp(const char *key __rte_unused,
 	if (rte_ether_unformat_addr(value, &mac) < 0)
 		return -1; /* invalid devargs value */
 
+	if (rte_eth_dev_info_get(data->port_id, &dev_info) < 0)
+		return -1;
+
 	/* Return 0 if devargs MAC is matching one of the device MACs. */
-	rte_eth_dev_info_get(data->port_id, &dev_info);
 	for (index = 0; index < dev_info.max_mac_addrs; index++)
 		if (rte_is_same_ether_addr(&mac, &data->mac_addrs[index]))
 			return 0;
-- 
2.25.1


  reply	other threads:[~2023-01-20  4:42 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20  4:41 [PATCH v3 00/10] codeql fixes for various subsystems okaya
2023-01-20  4:41 ` okaya [this message]
2023-01-20 10:21   ` [PATCH v3 01/10] ethdev: check return result of rte_eth_dev_info_get Morten Brørup
2023-01-20  4:41 ` [PATCH v3 02/10] memzone: check result of rte_fbarray_get okaya
2023-01-20  4:41 ` [PATCH v3 03/10] memzone: check result of malloc_elem_from_data okaya
2023-01-20  4:41 ` [PATCH v3 04/10] malloc: malloc_elem_join_adjacent_free can return null okaya
2023-01-20  4:41 ` [PATCH v3 05/10] malloc: check result of rte_mem_virt2memseg_list okaya
2023-01-20  4:41 ` [PATCH v3 06/10] malloc: check result of rte_fbarray_get okaya
2023-01-20  4:41 ` [PATCH v3 07/10] malloc: check result of rte_mem_virt2memseg okaya
2023-01-20  4:41 ` [PATCH v3 08/10] malloc: check result of malloc_elem_free okaya
2023-01-20  4:41 ` [PATCH v3 09/10] malloc: check result of elem_start_pt okaya
2023-01-20  4:41 ` [PATCH v3 10/10] bus/vdev: check result of rte_vdev_device_name okaya
2023-01-20 16:47   ` Stephen Hemminger
2023-01-22 20:51     ` Thomas Monjalon
2023-02-06 16:01       ` Sinan Kaya
2023-02-06 18:46         ` Thomas Monjalon
2023-02-06 16:00 ` [PATCH v3 00/10] codeql fixes for various subsystems Sinan Kaya
2023-07-06 22:43 ` Stephen Hemminger
2023-07-10 15:18   ` Sinan Kaya
2023-07-10 17:07 ` [PATCH v4 0/5] fixes for problems found by codeql analyzer Stephen Hemminger
2023-07-10 17:07   ` [PATCH v4 1/5] mailmap: add Sinan Stephen Hemminger
2023-07-10 17:07   ` [PATCH v4 2/5] ethdev: check return result of rte_eth_dev_info_get Stephen Hemminger
2023-12-16 10:06     ` Andrew Rybchenko
2023-12-16 10:08       ` Andrew Rybchenko
2023-07-10 17:07   ` [PATCH v4 3/5] memzone: check result of rte_fbarray_get and malloc_elem_from_data Stephen Hemminger
2023-07-10 17:07   ` [PATCH v4 4/5] malloc: codeql fixes Stephen Hemminger
2023-07-10 17:08   ` [PATCH v4 5/5] bus/vdev: check result of rte_vdev_device_name Stephen Hemminger
2023-12-16 10:10     ` Andrew Rybchenko
2023-07-11  1:37   ` [PATCH v4 0/5] fixes for problems found by codeql analyzer fengchengwen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230120044140.95975-2-okaya@kernel.org \
    --to=okaya@kernel.org \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).