From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA8074243C; Fri, 20 Jan 2023 23:14:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64BEB40E5A; Fri, 20 Jan 2023 23:14:21 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 6372A4067E for ; Fri, 20 Jan 2023 23:14:19 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 64A3220E0A2B; Fri, 20 Jan 2023 14:14:18 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 64A3220E0A2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1674252858; bh=0Z1Pd9ZgETQpMuq/v4IiRkm+1iH19t2UY2MVFhu3v58=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lNT1tu+VZPLyzoLSmrlFoKrL90SYMULYsBgpjCRnTd3AAMDmqwSWKThq8OcT9jkb9 lQWpp0duP67Urihxx3PMEb53wBrPBvH6Zv43c0x0fvhcW/z15QSo1YXXDaEcQNbXEV vl9YkZSw7VoIiDcoliqeYOGfgFAk4wX1vA9KYQRE= Date: Fri, 20 Jan 2023 14:14:18 -0800 From: Tyler Retzlaff To: dev@dpdk.org Cc: thomas@monjalon.net, mb@smartsharesystems.com, bruce.richardson@intel.com, ferruh.yigit@amd.com, david.marchand@redhat.com Subject: Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count abstraction Message-ID: <20230120221418.GA9231@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1669241687-18810-1-git-send-email-roretzla@linux.microsoft.com> <1673380001-16558-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1673380001-16558-1-git-send-email-roretzla@linux.microsoft.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org hi folks, i think this one can probably be merged? Series-acked-by: Morten Brørup Series-acked-by: Bruce Richardson patch 1/2 Acked-by: Ferruh Yigit thanks! On Tue, Jan 10, 2023 at 11:46:39AM -0800, Tyler Retzlaff wrote: > v6: > * remove stray #include > > v5: > * fix implementation of msvc versions of rte_clz{32,64} > incorrect use of _BitscanReverse{,64} index. > * fix and expand unit test to exercise full range of counting > over uint{32,64}_t input values. (which would have caught > above mistake). > * reduce commit title length > * correct commit author > > v4: > * combine unit test commit into function addition commit > > v3: > * rename to use 32/64 instead of l/ll suffixes > * add new functions to rte_bitops.h instead of new header > * move other bit functions from rte_common.h to rte_bitops.h > > v2: > * use unsigned int instead of unsigned (checkpatches) > * match multiple include guard naming convention to rte_common.h > * add explicit extern "C" linkage to rte_bitcount.h > note: not really needed but checkpatches required > * add missing space around '-' > > Tyler Retzlaff (2): > eal: move bit operation common to bitops header > eal: provide leading and trailing zero bit count abstraction > > app/test/meson.build | 2 + > app/test/test_bitcount.c | 93 ++++++++ > app/test/test_common.c | 1 + > lib/eal/common/rte_reciprocal.c | 1 + > lib/eal/include/rte_bitops.h | 460 ++++++++++++++++++++++++++++++++++++++++ > lib/eal/include/rte_common.h | 293 ------------------------- > 6 files changed, 557 insertions(+), 293 deletions(-) > create mode 100644 app/test/test_bitcount.c > > -- > > Series-acked-by: Morten Brørup > Series-acked-by: Bruce Richardson