From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DC444246D; Mon, 23 Jan 2023 19:57:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A35840150; Mon, 23 Jan 2023 19:57:24 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id D3CC9400EF for ; Mon, 23 Jan 2023 19:57:21 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 1785320E1ABC; Mon, 23 Jan 2023 10:57:21 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1785320E1ABC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1674500241; bh=FTxtFQqYiHNVimIzrm9uXp99W5Ti5ED6/eloRGucldk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e3vUi5MmiNvS03FEMTRr1CQREBsoMCZtFEinCBLRLd28YYBMGJKftJOeoMZhQjxgo 489I9QX5AGr9m6mZz6YNaLEwm3qmtXqFXhrFtS+jt9mHAb/uqhSOeWlFiWgtC9GhXF /FxDyTe7UPY7YEMUTfM61BHz5r5JkPmDnY5qSXK0= Date: Mon, 23 Jan 2023 10:57:21 -0800 From: Tyler Retzlaff To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, jerinjacobk@gmail.com, mb@smartsharesystems.com Subject: Re: [PATCH v6 0/5] add rte_thread_set_name API for rte_thread_t Message-ID: <20230123185721.GA11484@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com> <1674071646-6854-1-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Jan 22, 2023 at 02:55:18PM +0100, David Marchand wrote: > On Wed, Jan 18, 2023 at 8:54 PM Tyler Retzlaff > wrote: > > > > Replace the rte_thread_setname API which operates on pthread_t with > > rte_thread_set_name that operates on rte_thread_t. > > > > We should try to align tracing output from the EAL for all platforms > > but in this case we are retaining an exception for linux as requested > > from the community. > > > > v6: > > * clean up commit descriptions > > * add patch to set worker thread name on windows > > * remove __rte_deprecated from rte_thread_setname > > The unit tests are failing in the UNH Windows env though it was fine with v5. > https://lab.dpdk.org/results/dashboard/patchsets/25031/ > > 1/91 DPDK:fast-tests / acl_autotest FAIL > 1.05s (exit status 3221225477 or signal 3221225349 SIGinvalid) > 06:02:25 MALLOC_PERTURB_=92 DPDK_TEST=acl_autotest > C:\Users\builder\jenkins\workspace\Generic-VM-Unit-Test-DPDK\dpdk\build\app\test\dpdk-test.exe > ----------------------------------- output ----------------------------------- > stderr: > EAL: Detected CPU lcores: 4 > > EAL: Detected NUMA nodes: 1 > > EAL: Multi-process support is requested, but not available. > > ------------------------------------------------------------------------------ > > Could you have a look? it's a bug in the windows implementation, v7 will be submitted to fix it. thankfully you asked for the eal worker thread initialization to be made consistent with freebsd/linux. it was that change that caused the failure to be exposed in this revision of the series. thank you.