From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A61F842476; Tue, 24 Jan 2023 11:47:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4346F40150; Tue, 24 Jan 2023 11:47:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AC79C400EF for ; Tue, 24 Jan 2023 11:47:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674557274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZLm6y81TOtemt04Q5vprD6egGjk+T5x3WamViuf8YZ0=; b=aB1I3bi/V4VSOJCa4L/VJNfc5Le8s4wRDrNP8RMCeQUPZ8WtDHwF0CMZ7ytrs+FqOXkx1V 4spFiMriuU4nGT0ywBAowcc7Z45uPXwQ81WiDf695yVIs56FVwuwJGO0+aYt6u9saEbdwV WKxdbf0IVPYh4MvtvindHwUSn1YhVfc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-221-heM0vQy6OCaJhOoWJvlUmw-1; Tue, 24 Jan 2023 05:47:51 -0500 X-MC-Unique: heM0vQy6OCaJhOoWJvlUmw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id ADC4B858F09; Tue, 24 Jan 2023 10:47:50 +0000 (UTC) Received: from dmarchan.redhat.com (ovpn-192-67.brq.redhat.com [10.40.192.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90225492B02; Tue, 24 Jan 2023 10:47:49 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Ferruh Yigit , Aman Singh , Yuying Zhang , Robin Jarry Subject: [PATCH 0/6] Testpmd code cleanup Date: Tue, 24 Jan 2023 11:47:36 +0100 Message-Id: <20230124104742.1265439-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Here is a series to reduce code duplication in testpmd. This work started from looking at Robin series on reporting lcore busy cycles in telemetry, which is then added in testpmd [1]. While looking at the forward engines code, I saw way too much duplicated code. Warning: this is only compile tested. 1: https://patchwork.dpdk.org/project/dpdk/patch/20230119150656.418404-5-rjarry@redhat.com/ -- David Marchand David Marchand (6): app/testpmd: factorize core cycles record app/testpmd: don't send unprepared packets app/testpmd: bulk free mbufs app/testpmd: factorize fwd engine init app/testpmd: factorize fwd engine Rx app/testpmd: factorize fwd engine Tx app/test-pmd/5tswap.c | 54 ++-------------- app/test-pmd/csumonly.c | 61 +++--------------- app/test-pmd/flowgen.c | 55 ++-------------- app/test-pmd/icmpecho.c | 60 +++--------------- app/test-pmd/ieee1588fwd.c | 35 ++++------- app/test-pmd/iofwd.c | 54 ++-------------- app/test-pmd/macfwd.c | 53 ++-------------- app/test-pmd/macswap.c | 58 +++-------------- app/test-pmd/noisy_vnf.c | 115 +++++++++------------------------- app/test-pmd/rxonly.c | 18 ++---- app/test-pmd/shared_rxq_fwd.c | 14 ++--- app/test-pmd/testpmd.c | 26 ++++++-- app/test-pmd/testpmd.h | 46 +++++++++++++- app/test-pmd/txonly.c | 45 ++++--------- 14 files changed, 173 insertions(+), 521 deletions(-) -- 2.39.1