From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F251F4247D; Tue, 24 Jan 2023 16:33:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FA6D40150; Tue, 24 Jan 2023 16:33:06 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 5DA37400EF for ; Tue, 24 Jan 2023 16:33:05 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 9D99420E2D2B; Tue, 24 Jan 2023 07:33:04 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9D99420E2D2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1674574384; bh=U/BvymDV6ypk8hfLi0fgb6zDFa7z93Fp4hE0WvSAwD8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LA5wWmmOgWc2+/Nwycp7HG0FsjwLEaxsf5WPFTTskA568P9Q9izdBBOjIHycMcJ84 2aV19woLFRco5Xo5EbxphbGGCsnixY13OfdB7APpBxvwC8JMkXhNQwg1hnnuDeYxJF rx/jbMOO/r2ehTi4jCay0Eycrbw0a48aHw6EY08I= Date: Tue, 24 Jan 2023 07:33:04 -0800 From: Tyler Retzlaff To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, jerinjacobk@gmail.com, mb@smartsharesystems.com Subject: Re: [PATCH v7 3/5] eal: set thread name on Windows worker threads Message-ID: <20230124153304.GA23027@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com> <1674502774-20253-1-git-send-email-roretzla@linux.microsoft.com> <1674502774-20253-4-git-send-email-roretzla@linux.microsoft.com> <3854099.WbyNdk4fJJ@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3854099.WbyNdk4fJJ@thomas> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 24, 2023 at 04:25:34PM +0100, Thomas Monjalon wrote: > 23/01/2023 20:39, Tyler Retzlaff: > > Bring Windows EAL worker thread initialization in line with linux & > > freebsd by setting the worker thread name using the new > > platform agnostic rte_thread_set_name API. > > > > Signed-off-by: Tyler Retzlaff > > > > Acked-by: Morten Brørup > > > > --- > > lib/eal/windows/eal.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c > > index b9f95ed..e561f87 100644 > > --- a/lib/eal/windows/eal.c > > +++ b/lib/eal/windows/eal.c > > @@ -282,6 +282,7 @@ enum rte_proc_type_t > > enum rte_iova_mode iova_mode; > > int ret; > > char cpuset[RTE_CPU_AFFINITY_STR_LEN]; > > + char thread_name[RTE_MAX_THREAD_NAME_LEN]; > > > > eal_log_init(NULL, 0); > > > > @@ -437,6 +438,12 @@ enum rte_proc_type_t > > if (rte_thread_create(&lcore_config[i].thread_id, NULL, > > eal_thread_loop, (void *)(uintptr_t)i) != 0) > > rte_panic("Cannot create thread\n"); > > + > > + /* Set thread_name for aid in debugging. */ > > No need of underscore in "thread name". The variable name was copied from linux/eal.c and matches freebsd/eal.c do you still want me to remove the underscore? It will require another revision of the series. > > > + snprintf(thread_name, sizeof(thread_name), > > + "rte-worker-%d", i); > > + rte_thread_set_name(lcore_config[i].thread_id, thread_name); > > Thanks for making implementations more uniform. my pleasure.