From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C5A614247D;
	Tue, 24 Jan 2023 16:33:38 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B86A240684;
	Tue, 24 Jan 2023 16:33:38 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 7A64E400EF
 for <dev@dpdk.org>; Tue, 24 Jan 2023 16:33:37 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id CEA7320E2D2B; Tue, 24 Jan 2023 07:33:36 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CEA7320E2D2B
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1674574416;
 bh=gBq3k/XAMF1eJucvEMcP8ZcKxlyyxfvStEN56l9ghZg=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=dOFS7J13rvSutRvD65nZO0wh7WcrMBwmi9nMnbf5n28C0+EIUcGMpN7GUDgy9NYrb
 SraFd47+KgLRpDVynOZefj7mu7X9kykHwFirGUJFBsp4B4hxX2Ka55tDWFH4L1C9rQ
 CwRPcYSL9FHfcUpnGDZe4M1GAv2e04+74j09cZLU=
Date: Tue, 24 Jan 2023 07:33:36 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.marchand@redhat.com, jerinjacobk@gmail.com,
 mb@smartsharesystems.com
Subject: Re: [PATCH v7 2/5] eal: remove thread getname API
Message-ID: <20230124153336.GB23027@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com>
 <1674502774-20253-1-git-send-email-roretzla@linux.microsoft.com>
 <1674502774-20253-3-git-send-email-roretzla@linux.microsoft.com>
 <4488102.Fh7cpCN91P@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <4488102.Fh7cpCN91P@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Jan 24, 2023 at 04:24:04PM +0100, Thomas Monjalon wrote:
> 23/01/2023 20:39, Tyler Retzlaff:
> > Remove the rte_thread_getname API. The API is __rte_experimental and
> > requires no deprecation notice.
> 
> You should give a justification in this commit log,
> and note the removal in the release notes (removed items).
> 
> > Fold the platform specific variants into the one place it is used as a
> > special case to retain the functionality for linux only.
> > 
> > Adjust the function as follows.
> > 
> > * reduce scope where thread_get_name can be used to eal_common_trace.c
> > * change the return type to void since the return value is not
> >   consistent reportable depending on glibc version.
> > * change the thread id type to be rte_thread_t.
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > 
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> 
> Note: no space before acks.
> 

noted, will make the adjustment in the future.

thanks for letting me know.