From: Robin Jarry <rjarry@redhat.com>
To: dev@dpdk.org
Cc: Robin Jarry <rjarry@redhat.com>
Subject: [PATCH v7 0/5] lcore telemetry improvements
Date: Thu, 26 Jan 2023 16:20:40 +0100 [thread overview]
Message-ID: <20230126152045.1036904-1-rjarry@redhat.com> (raw)
This is a follow up on previous work by Kevin Laatz:
http://patches.dpdk.org/project/dpdk/list/?series=24658&state=*
This series is aimed at allowing DPDK applications to expose their CPU
usage stats in the DPDK telemetry under /eal/lcore/info. This is a much
more basic and naive approach which leaves the cpu cycles accounting
completely up to the application.
For reference, I have implemented a draft patch in OvS to use
rte_lcore_register_usage_cb() and report the already available busy
cycles information.
https://github.com/rjarry/ovs/commit/643e672fe388e348ea7ccbbda6f5a87a066fd919
Changes since v6:
- Added release notes entry
- Moved lcore role enum to name conversion in a function for reuse
- Moved rte_lcore_register_usage_cb in a 23.03 block of eal/version.map
- Style & indentation fixes
- Use asprintf to format busy/total cycles in lcore_dump_cb
Changes since v5:
- Added/rephrased some inline comments to address reviews.
- Added a new commit that adds the /eal/lcore/usage endpoint as
suggested by Kevin and Morten.
Robin Jarry (5):
eal: add lcore info in telemetry
eal: report applications lcore usage
app/testpmd: add dump command for lcores
app/testpmd: report lcore usage
eal: add lcore usage telemetry endpoint
app/test-pmd/5tswap.c | 5 +-
app/test-pmd/cmdline.c | 3 +
app/test-pmd/csumonly.c | 6 +-
app/test-pmd/flowgen.c | 2 +-
app/test-pmd/icmpecho.c | 6 +-
app/test-pmd/iofwd.c | 5 +-
app/test-pmd/macfwd.c | 5 +-
app/test-pmd/macswap.c | 5 +-
app/test-pmd/noisy_vnf.c | 4 +
app/test-pmd/rxonly.c | 5 +-
app/test-pmd/shared_rxq_fwd.c | 5 +-
app/test-pmd/testpmd.c | 40 +++-
app/test-pmd/testpmd.h | 14 +-
app/test-pmd/txonly.c | 7 +-
doc/guides/rel_notes/release_23_03.rst | 8 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +
lib/eal/common/eal_common_lcore.c | 227 ++++++++++++++++++--
lib/eal/include/rte_lcore.h | 35 +++
lib/eal/version.map | 3 +
19 files changed, 347 insertions(+), 45 deletions(-)
--
2.39.1
next reply other threads:[~2023-01-26 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 15:20 Robin Jarry [this message]
2023-01-26 15:20 ` [PATCH v7 1/5] eal: add lcore info in telemetry Robin Jarry
2023-01-26 17:03 ` Stephen Hemminger
2023-01-31 9:40 ` Robin Jarry
2023-01-31 16:41 ` Stephen Hemminger
2023-01-26 15:20 ` [PATCH v7 2/5] eal: report applications lcore usage Robin Jarry
2023-01-26 15:20 ` [PATCH v7 3/5] app/testpmd: add dump command for lcores Robin Jarry
2023-01-26 15:20 ` [PATCH v7 4/5] app/testpmd: report lcore usage Robin Jarry
2023-01-26 15:20 ` [PATCH v7 5/5] eal: add lcore usage telemetry endpoint Robin Jarry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126152045.1036904-1-rjarry@redhat.com \
--to=rjarry@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).