From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC1A3424AA; Sat, 28 Jan 2023 18:21:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EFE340143; Sat, 28 Jan 2023 18:21:22 +0100 (CET) Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id DB0D54003F for <dev@dpdk.org>; Sat, 28 Jan 2023 18:21:20 +0100 (CET) Received: by mail-pj1-f50.google.com with SMTP id m7-20020a17090a71c700b0022c0c070f2eso10931547pjs.4 for <dev@dpdk.org>; Sat, 28 Jan 2023 09:21:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=hrelgXtxkyWx+iKBGzRvYlpg5lIDVzKla6O96P8mN+U=; b=68a3D9gVGJXAuWPGYQrGj+2XdlEckCUx84ktWRnnv8EJlICUivRKZHzAkrLiLoZ5o9 ArJiiGYSLOwRuUQzwXU/TyOJbkeNWKJ6s6E4VWzkU/NE0Cg9+2q9+qlYPptNBhSOxBEH 4gfetkBz8YFf0d557sVlEWH77vg/kJ8kkiLOezj83G4DtX5DaXXFOsN7EWBrt63vNkPb MsbGRAXA+QOqZFQRedbtGK/R3lvOsJx2dRzUuSwMAV3Sy6FsNwrf01L0YK9NvLwbQurX DQ8u71p+q7bR8zfsn7eSxlgUKx3G5bPuxriIoP6wF2haHLpWoUJSPmq0/miXt2YY690z E3mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hrelgXtxkyWx+iKBGzRvYlpg5lIDVzKla6O96P8mN+U=; b=Qr0W7SpTzlIqHePW59qXattsNm3wRPaEdeCutqRpCpDBEdMek5JbKDWpeEajDMdAnx QiDp6GzpBCq4kaIqNaIupIyGJQj1r3iOU8s5mb9cQFZEPAEu9yfBuekPBiM8ly13l/34 eimt/bJ+loHhy9mrBi0DoqajR0e7HWb+5dw2U4GktZvdrgB2356KCV/rayLmS1uF/i1i pHfUnjVzXUoEZQJV/yguK6I6tr8yAo0Ffu/lb+maW7qNqg6ZQR7Zu1wrnbENNJwE0oLX aiWWEHSWC/H+nq+dpFn5lEKoA65YAOg37fm+UGT5qKWNes1UH4jc8N9vYiAxxhg6Npyn 04+Q== X-Gm-Message-State: AFqh2kpZqlGhO6FXl7Wa/Y6+3KUUchPv8QW3fDd78O/3qt5OIm9gDSGE LsayUmSxnOR0bac84s2sQ8hC+w== X-Google-Smtp-Source: AMrXdXt4Whu3uT/1Nhmy8bjJDy5a267pdYWsWQfG0c/GWVOatvZJapvbmoVAf2F+r9Z4kIL9LlKjGg== X-Received: by 2002:a17:903:22c4:b0:195:32b3:260f with SMTP id y4-20020a17090322c400b0019532b3260fmr39188401plg.16.1674926480008; Sat, 28 Jan 2023 09:21:20 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id v8-20020a17090331c800b001769e6d4fafsm4788215ple.57.2023.01.28.09.21.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Jan 2023 09:21:19 -0800 (PST) Date: Sat, 28 Jan 2023 09:21:18 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Jerin Jacob <jerinjacobk@gmail.com> Cc: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>, "jerinj@marvell.com" <jerinj@marvell.com>, "Carrillo, Erik G" <erik.g.carrillo@intel.com>, "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com> Subject: Re: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs Message-ID: <20230128092118.6db74a29@hermes.local> In-Reply-To: <CALBAE1PZi7rH3pWmXjQXJmQk==JiCinN7YQzXdxF-0cuS1NxeQ@mail.gmail.com> References: <20230107161852.3708690-1-s.v.naga.harish.k@intel.com> <20230123180458.486189-1-s.v.naga.harish.k@intel.com> <CALBAE1PS+oCGVUpgA5YsoZa69=b8vVdin3Oi0gnfk3R+8A5TAQ@mail.gmail.com> <DM6PR11MB38683878BAEF49C1B4DEB444A1C99@DM6PR11MB3868.namprd11.prod.outlook.com> <CALBAE1M5efc_s1jd+1_+fj-b2n4=QLnLfgNBD8ZoJa6Ku7BxHw@mail.gmail.com> <DM6PR11MB3868D656E9B81916AAE1C425A1CE9@DM6PR11MB3868.namprd11.prod.outlook.com> <CALBAE1PJ6Z3_YxVot2VLCj+rJcK_3MndA2pb=fs7aRiZQBEfRA@mail.gmail.com> <DM6PR11MB38686DA2E1A4332F4B9FF849A1CE9@DM6PR11MB3868.namprd11.prod.outlook.com> <CALBAE1PZi7rH3pWmXjQXJmQk==JiCinN7YQzXdxF-0cuS1NxeQ@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Sat, 28 Jan 2023 16:23:45 +0530 Jerin Jacob <jerinjacobk@gmail.com> wrote: > > > > > > Yes. No need recompile if ABI not breaking. > > > > > > > When some of the reserved fields are used in the future, the application > > > also may need to be recompiled along with DPDK right? > > > > As the application also may need to use the newly consumed reserved > > > fields? > > > > > > The problematic case is: > > > > > > Adapter implementation of 23.07(Assuming there is change params) field > > > needs to work with application of 23.03. > > > rte_event_eth_rx_adapter_runtime_params_init() will sove that. > > > > > First off, reserved fields are a problematic design choice IMHO (see YAGNI). Second. any reserved fields can not be used in future unless the original code enforced that all reserved fields are zero. Same is true for holes in structs which some times get reused. You can't use a reserved field without breaking ABI unless the previous code enforced that the field must be zero.