From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C93341B86; Tue, 31 Jan 2023 03:55:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76D8D410E6; Tue, 31 Jan 2023 03:55:57 +0100 (CET) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id 66E7340EF0 for ; Tue, 31 Jan 2023 03:55:56 +0100 (CET) Received: by mail-pf1-f172.google.com with SMTP id c124so9260436pfb.8 for ; Mon, 30 Jan 2023 18:55:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=0ikr7zxlMuV2iB3MQ9+mub5sLZo03ow7o8nosOmGhPQ=; b=Cm5UOeKuXj9OVn6cu09RNQaTNLC0/ZRD8Zt2g0K40QQ9ZMYSuJyrZLC08lfur1Sca4 bzMhPD/dals6JZF1FLIPAiUdowPRYPjxzoFNoaTiBKf2rXn9m35FoaBdEqoTL3LfDqkx 6+WqGhlDaZujeMCUVfii5/R4ojo1SlZf4xPhiWgpb/uaB57TZeOaELJ0zRqDIlj3W10N e1+etNIHB4l4v/D0fohwoKlmrldH8KB7v59YXiZOrhtTLDteA62ivkz6KZibw7PuU8+l 8zydFhjI/trLT3nBNWv1+JkLGQyPvMvqGNrKD4ptcUNBcZ+G71KIKsAgk5zkyKRZ1bDh Ts4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0ikr7zxlMuV2iB3MQ9+mub5sLZo03ow7o8nosOmGhPQ=; b=d+JqAIW7PNNt1C1A9KN8csjltj38Kzkd1xx2lisJS2SzIH1ztTFbSSKCo6vi8T1Nis NK9Sd8IkHO5MwwvF+cHNbrzZlDBRgjegVczIJTQEERS+PXl0vLIHBB7SLPs5QG6YltHi 14UZ8l3zeSXNFO3NXatqe/XaII3FCs5rJBT9sGDvFu7trCawL7eiowV0onbOtkUMtYwX gKbcMN5sQ/8kBARtUpgGHQjX4UG8srBLfK1nwYxExTz8VhQSpD5AhRoQQSa8eFGKF/S6 yCGC/NRV0vm00jhYJlXTm1KnybtluuAT2NbC++UcyDifhG6ksmoJnwfzDvFn7RiUZ31n WNZA== X-Gm-Message-State: AFqh2krEkbDn+OPaprzzrR2oaVe01400XidMmppdHboYs/ojWz3F/Ga+ 0kcCXGBEPfvRfEuj7OKbn23uDg== X-Google-Smtp-Source: AMrXdXsCxU1Tv/07PpTWM1jiWvIRmsTsFJd05XrU5of8k7UjaF3IMMmi/m42Ju99C0M1RQT60kWt2g== X-Received: by 2002:a62:1d12:0:b0:56c:232e:395e with SMTP id d18-20020a621d12000000b0056c232e395emr50181477pfd.15.1675133755603; Mon, 30 Jan 2023 18:55:55 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id 74-20020a62164d000000b0058b59c81a29sm8013567pfw.220.2023.01.30.18.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 18:55:55 -0800 (PST) Date: Mon, 30 Jan 2023 18:55:53 -0800 From: Stephen Hemminger To: Rongwei Liu Cc: Matan Azrad , Slava Ovsiienko , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko , Olivier Matz , "dev@dpdk.org" , Raslan Darawsheh Subject: Re: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition Message-ID: <20230130185553.2b97153f@hermes.local> In-Reply-To: References: <5da6632a-0976-dc1f-facb-f778c8aad8e6@oktetlabs.ru> <20230130035941.1495874-1-rongweil@nvidia.com> <20230130035941.1495874-2-rongweil@nvidia.com> <20230130084746.101226e2@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 31 Jan 2023 02:27:56 +0000 Rongwei Liu wrote: > HI Stephen > > BR > Rongwei > > > -----Original Message----- > > From: Stephen Hemminger > > Sent: Tuesday, January 31, 2023 00:48 > > To: Rongwei Liu > > Cc: Matan Azrad ; Slava Ovsiienko > > ; Ori Kam ; NBU-Contact- > > Thomas Monjalon (EXTERNAL) ; Aman Singh > > ; Yuying Zhang ; > > Ferruh Yigit ; Andrew Rybchenko > > ; Olivier Matz ; > > dev@dpdk.org; Raslan Darawsheh > > Subject: Re: [PATCH v3 1/8] ethdev: add IPv6 routing extension header > > definition > > > > External email: Use caution opening links or attachments > > > > > > On Mon, 30 Jan 2023 05:59:33 +0200 > > Rongwei Liu wrote: > > > > > > > > +/** > > > + * IPv6 Routing Extension Header > > > + */ > > > +struct rte_ipv6_routing_ext { > > > + uint8_t next_hdr; /**< Protocol, next header. */ > > > + uint8_t hdr_len; /**< Header length. */ > > > + uint8_t type; /**< Extension header type. */ > > > + uint8_t segments_left; /**< Valid segments number. */ > > > + __extension__ > > > + union { > > > + rte_be32_t flags; > > > + struct { > > > + uint8_t last_entry; /**< The last_entry field of SRH */ > > > + uint8_t flag; /**< Packet flag. */ > > > + rte_be16_t tag; /**< Packet tag. */ > > > + }; > > > + }; > > > + __extension__ > > > + rte_be32_t segments[0]; /**< Each hop IPv6 address. */ > > > > Use flex array rather than zero size. > > Zero size arrays cause warnings with later compilers. > Using flex array helps improve this network header definition but caused warning in the rte_flow_item_** > struct rte_flow_item_ipv6_routing_ext { > struct rte_ipv6_routing_ext hdr; > }; > "invalid use of structure with flexible array member [-Werror=pedantic]" Not sure, only Nvidia/Mellanox messes with pedantic