From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D19AC41B83;
	Mon, 30 Jan 2023 21:34:55 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5C0C040C35;
	Mon, 30 Jan 2023 21:34:55 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 87AE040698
 for <dev@dpdk.org>; Mon, 30 Jan 2023 21:34:54 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id B8DA120E9F90; Mon, 30 Jan 2023 12:34:53 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B8DA120E9F90
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1675110893;
 bh=+p0YwKOwGbCESoK6ZsURYaVBJEAxfSbmZxLBy+skcY0=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=qOCkQ8zBJPCdPycFc8qz+QNBwWB4NftO2EV+SdSvzQSIS0G/I1S4uajDWeZ1ZxgVS
 /5WckJWjM2WXxq0s+MNUJ1s0N77v5txKRlRV0Mz6AA2R7bok0HBS174l/MedsHVC3p
 S3fjRXjxh2Z9zL6Q5hW+0S6WWp0w8+5+REdp5ewI=
Date: Mon, 30 Jan 2023 12:34:53 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org,
 jerinjacobk@gmail.com, mb@smartsharesystems.com
Subject: Re: [PATCH v10 4/4] eal: deprecation notice for rte thread setname API
Message-ID: <20230130203453.GA29828@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com>
 <1674583941-16964-1-git-send-email-roretzla@linux.microsoft.com>
 <1674583941-16964-5-git-send-email-roretzla@linux.microsoft.com>
 <2954281.hTDNKPQEx9@thomas>
 <CAJFAV8wBQmXThmw6kOwNVcdEspfP7b2q=8CXrNKfvJL1Dgrt8w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJFAV8wBQmXThmw6kOwNVcdEspfP7b2q=8CXrNKfvJL1Dgrt8w@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Jan 30, 2023 at 05:19:20PM +0100, David Marchand wrote:
> On Mon, Jan 30, 2023 at 4:47 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > Hi,
> >
> > The title should start with a verb.
> > I suppose it can be fixed while merging with a title like:
> > doc: announce deprecation of thread naming function
> 
> Yes, I will handle it.
> 
> > 24/01/2023 19:12, Tyler Retzlaff:
> > > Notify deprecation of rte_thread_setname API, it will be removed as it
> > > exposes platform-specific thread details. The functionality it provided
> > > is now available via the new rte_lcore_set_name API.
> > >
> > > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > > Acked-by: Morten Brørup <mb@smartsharesystems.com>
> > > Acked-by: David Marchand <david.marchand@redhat.com>
> > > ---
> > > +* eal: The function ``rte_thread_setname`` is planned to be deprecated
> > > +  starting with the 23.07 release subject to the replacement API
> > > +  rte_thread_set_name being marked as stable and planned to be removed
> > > +  by the 23.11 release.
> >
> > Minor: it would be clearer if adding some commas after "release" and "stable".
> 
> And this too.
> 
> >
> >
> > For the series,
> > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Thanks.

thank you both, i'll rebase the rte_ctrl_thread_create patch series once
this is merged to get it moving forward again.