From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2786B41BAE;
	Thu,  2 Feb 2023 16:57:36 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1478D42D20;
	Thu,  2 Feb 2023 16:57:36 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 8ABEF40EDC
 for <dev@dpdk.org>; Thu,  2 Feb 2023 16:57:34 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id EA91C20B74F7; Thu,  2 Feb 2023 07:57:33 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EA91C20B74F7
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1675353453;
 bh=2+XwUl0p0R3r+cmb+TpdOrev2PWkttFH/GW9fDKKlDU=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=jaPWNr7S4t1UFS2S3akkTyGo3an9/886wu1APOvAGJginGYl/SLhQOA8Q42/UDD9y
 vjPTuzkijBPLwWoex3vhto++j/S1W7575jOC9Tc2J/kXTrUrU5rNXaem3N1cQ7AR4A
 QlvplfuHm4VogrXMZ6qKxLg0TLkznLoJoRqas+C8=
Date: Thu, 2 Feb 2023 07:57:33 -0800
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, mb@smartsharesystems.com,
 bruce.richardson@intel.com, ferruh.yigit@amd.com
Subject: Re: [PATCH v6 0/2] eal: provide leading and trailing zero bit count
 abstraction
Message-ID: <20230202155733.GB20115@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1669241687-18810-1-git-send-email-roretzla@linux.microsoft.com>
 <1673380001-16558-1-git-send-email-roretzla@linux.microsoft.com>
 <20230120221418.GA9231@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <CAJFAV8xRFfuCH7dGy=3KW50n-x2xidpfr0uDqM0j1im7-y6DFg@mail.gmail.com>
 <CAJFAV8zub9mt51hhsd3+6orm6sRppKJiEWNC6TeCBmkOAxTaEQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJFAV8zub9mt51hhsd3+6orm6sRppKJiEWNC6TeCBmkOAxTaEQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, Feb 02, 2023 at 11:56:41AM +0100, David Marchand wrote:
> On Thu, Feb 2, 2023 at 10:14 AM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > Hello Tyler,
> >
> > On Fri, Jan 20, 2023 at 11:14 PM Tyler Retzlaff
> > <roretzla@linux.microsoft.com> wrote:
> > >
> > > hi folks,
> > >
> > > i think this one can probably be merged?
> > >
> > > Series-acked-by: Morten Brørup <mb@smartsharesystems.com>
> > > Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > > patch 1/2 Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
> >
> > I like the cleanup of rte_common.h and additional unit tests, but the
> > MSVC bits don't belong here.
> > Please move them in your MSVC enablement series
> > https://patchwork.dpdk.org/project/dpdk/list/?series=26662&state=%2A&archive=both.
> 
> Addendum, running the series through my checks, I can see that
> test_bitcount.c is left unattended wrt the MAINTAINERS file.
> app/test/test_bitcount.c must be put under the "EAL API and common
> code" section.

is this an automated check i should have run prior to submission?

either way i'll fix that up, sorry for the mistake.

> 
> Thanks.
> -- 
> David Marchand