DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hamdan Igbaria <hamdani@nvidia.com>
To: <hamdani@nvidia.com>, <viacheslavo@nvidia.com>,
	<thomas@monjalon.net>, <suanmingm@nvidia.com>,
	Matan Azrad <matan@nvidia.com>
Cc: <dev@dpdk.org>, <orika@nvidia.com>, <valex@nvidia.com>
Subject: [v2 1/5] net/mlx5/hws: fix alias_rtc_0 print location in debug dump
Date: Thu, 2 Feb 2023 18:02:55 +0200	[thread overview]
Message-ID: <20230202160259.834707-1-hamdani@nvidia.com> (raw)
In-Reply-To: <20230126160309.584967-1-hamdani@nvidia.com>

Fix alias_rtc_0 print location in debug dump, move it to
the end of matcher dumped info instead of the middle, to
keep the dump compatibility.

Fixes: dd2845361a58 ("net/mlx5/hws: add debug details for cross gvmi")
Signed-off-by: Hamdan Igbaria <hamdani@nvidia.com>
---
 drivers/net/mlx5/hws/mlx5dr_debug.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/mlx5/hws/mlx5dr_debug.c b/drivers/net/mlx5/hws/mlx5dr_debug.c
index 0815327b18..4bbdb767ee 100644
--- a/drivers/net/mlx5/hws/mlx5dr_debug.c
+++ b/drivers/net/mlx5/hws/mlx5dr_debug.c
@@ -208,13 +208,11 @@ static int mlx5dr_debug_dump_matcher(FILE *f, struct mlx5dr_matcher *matcher)
 		ste_1 = NULL;
 	}
 
-	ret = fprintf(f, ",%d,%d,%d,%d,%d",
+	ret = fprintf(f, ",%d,%d,%d,%d",
 		      matcher->match_ste.rtc_0 ? matcher->match_ste.rtc_0->id : 0,
 		      ste_0 ? (int)ste_0->id : -1,
 		      matcher->match_ste.rtc_1 ? matcher->match_ste.rtc_1->id : 0,
-		      ste_1 ? (int)ste_1->id : -1,
-		      is_shared && !is_root ?
-		      matcher->match_ste.aliased_rtc_0->id : 0);
+		      ste_1 ? (int)ste_1->id : -1);
 	if (ret < 0)
 		goto out_err;
 
@@ -229,11 +227,13 @@ static int mlx5dr_debug_dump_matcher(FILE *f, struct mlx5dr_matcher *matcher)
 		ste_1 = NULL;
 	}
 
-	ret = fprintf(f, ",%d,%d,%d,%d\n",
+	ret = fprintf(f, ",%d,%d,%d,%d,%d\n",
 		      matcher->action_ste.rtc_0 ? matcher->action_ste.rtc_0->id : 0,
 		      ste_0 ? (int)ste_0->id : -1,
 		      matcher->action_ste.rtc_1 ? matcher->action_ste.rtc_1->id : 0,
-		      ste_1 ? (int)ste_1->id : -1);
+		      ste_1 ? (int)ste_1->id : -1,
+		      is_shared && !is_root ?
+		      matcher->match_ste.aliased_rtc_0->id : 0);
 	if (ret < 0)
 		goto out_err;
 
-- 
2.31.1


  parent reply	other threads:[~2023-02-02 16:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 16:03 [PATCH " Hamdan Igbaria
2023-01-26 16:03 ` [PATCH 2/5] net/mlx5/hws: change STC array size to 32K Hamdan Igbaria
2023-01-26 16:03 ` [PATCH 3/5] net/mlx5/hws: support STC info dump Hamdan Igbaria
2023-01-26 16:03 ` [PATCH 4/5] net/mlx5/hws: support IP version matching for non relaxed Hamdan Igbaria
2023-01-26 16:03 ` [PATCH 5/5] net/mlx5: support HW steering debug dump Hamdan Igbaria
2023-02-02 16:02 ` Hamdan Igbaria [this message]
2023-02-02 16:02   ` [v2 2/5] net/mlx5/hws: change STC array size to 32K Hamdan Igbaria
2023-02-02 16:02   ` [v2 3/5] net/mlx5/hws: support STC info dump Hamdan Igbaria
2023-02-02 16:02   ` [v2 4/5] net/mlx5/hws: support IP version matching for non relaxed Hamdan Igbaria
2023-02-02 16:02   ` [v2 5/5] net/mlx5: support HW steering debug dump Hamdan Igbaria
2023-02-12 11:50   ` [v2 1/5] net/mlx5/hws: fix alias_rtc_0 print location in " Matan Azrad
2023-02-14  8:28   ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230202160259.834707-1-hamdani@nvidia.com \
    --to=hamdani@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=suanmingm@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=valex@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).