From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 86ECA41BB7;
Fri, 3 Feb 2023 06:08:18 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 8CED9427EE;
Fri, 3 Feb 2023 06:08:12 +0100 (CET)
Received: from NAM11-DM6-obe.outbound.protection.outlook.com
(mail-dm6nam11on2055.outbound.protection.outlook.com [40.107.223.55])
by mails.dpdk.org (Postfix) with ESMTP id 8787F4014F
for <dev@dpdk.org>; Fri, 3 Feb 2023 06:08:11 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=JcRIHE31DlUGAWddkMSCHkgVFIFOQduQhbmgbyQpicYVwNFYtYlIve4smaShTzE4POHtwuyt818A6TMAEV8iNicJIC8R1EAJKFTWToJuaJGD9BAc9UPC/pLrfUXr7d/tdKaum/7xY8QT6QskyNc3mKj6DgjtJPXIvxFa8diukdMpBKvJbrRkcFD8hqL6B/KUWtmL0HuDbLS1F375bcGYPpFdbSMc5256SBwPv1GTg3sD4Tg4+3XmhBOePKqI+lrFkPVwAoLGtcqT5RxS0qlI0u3bzZvq89W0Z1WiNXpAWkJ87jXdQlIuWseANIQeh291RfFIas6kFVr7J6BUPlEpJA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=doF56qEzNR4/S0ghLlRb6o3Bv4ppK4Znv7FD/hyxZRw=;
b=d/1bv5Rvu5JzHjGN55IGbYO9+QEhz2YTtvgSSvM7t7rK3MlLmvt8OXwxu1EUPjLAA5zi5zVXN1pWOQ4YjDHV82KR2qbXWfEqVaGj2sVEupKFpUSgBGLCyyjhOu/jKKDF7P6P1UCrpdWZ6YhIs176LCGMU6pJC33dzuIvRpoKlh/fUs/DrLl4wV8fOYhKQn3ZvBTA62OAfC7HBhMEeD60avvEUZrs3m3kDgvQ0pXpAP/XwuWjQoB9s5HUB8XeRJY4BEOHf593w2cYpllTXuK9vzoPuqhlpc2T6c9naLqX83760DEvHLWhHsjEcGguKyFUrlaSmPT+J3WC1nDTB+Hj4Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is
216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;
dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;
dkim=none (message not signed); arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;
s=selector2;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=doF56qEzNR4/S0ghLlRb6o3Bv4ppK4Znv7FD/hyxZRw=;
b=STdayPyoU3KIHOyZd2+FMqDJ8a7ouxpJ/UdzhZXqHYJehy9WMwZ9bU6Y+mZGOEQwPcdRDhOwUeS7Gg/hfWtXS4AlqJJ2Iv7TPTWaN4ncSRgIuJXKXL0/C5V9f3LiIEvuVDNsWMDYNPvexEbCDdcLJ2Xt5r6giwibedChnG0TQhqQt6pwgNibdW5/uGmm8mjqpiMvoAvQwPa/z8Yz522zQkIvaKxCTPejLWyA5DU7wBqF+BYR4JSNPJloZx133uFRBuZLng/+ZuJFfW08Hw9Oif+D/SueK32QiBQYc1rBSodJjul+/Ylzz791AWUkvGx9ks8zXbOpPtH14UnjLStrtw==
Received: from BN0PR04CA0121.namprd04.prod.outlook.com (2603:10b6:408:ed::6)
by DM4PR12MB8521.namprd12.prod.outlook.com (2603:10b6:8:17e::6) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Fri, 3 Feb
2023 05:08:09 +0000
Received: from BN8NAM11FT116.eop-nam11.prod.protection.outlook.com
(2603:10b6:408:ed:cafe::aa) by BN0PR04CA0121.outlook.office365.com
(2603:10b6:408:ed::6) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27 via Frontend
Transport; Fri, 3 Feb 2023 05:08:09 +0000
X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160)
smtp.mailfrom=nvidia.com;
dkim=none (message not signed)
header.d=none;dmarc=pass action=none header.from=nvidia.com;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
216.228.117.160 as permitted sender) receiver=protection.outlook.com;
client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C
Received: from mail.nvidia.com (216.228.117.160) by
BN8NAM11FT116.mail.protection.outlook.com (10.13.176.67) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.6064.27 via Frontend Transport; Fri, 3 Feb 2023 05:08:09 +0000
Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com
(10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 2 Feb 2023
21:07:53 -0800
Received: from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com
(10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 2 Feb 2023
21:07:50 -0800
From: Jiawei Wang <jiaweiw@nvidia.com>
To: <viacheslavo@nvidia.com>, <orika@nvidia.com>, <thomas@monjalon.net>, "Aman
Singh" <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>,
Ferruh Yigit <ferruh.yigit@amd.com>, Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru>
CC: <dev@dpdk.org>, <rasland@nvidia.com>
Subject: [PATCH v3 2/2] ethdev: add PHY affinity match item
Date: Fri, 3 Feb 2023 07:07:16 +0200
Message-ID: <20230203050717.46914-3-jiaweiw@nvidia.com>
X-Mailer: git-send-email 2.18.1
In-Reply-To: <20230203050717.46914-1-jiaweiw@nvidia.com>
References: <20221221102934.13822-1-jiaweiw@nvidia.com/>
<20230203050717.46914-1-jiaweiw@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.126.231.37]
X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To
rnnvmail201.nvidia.com (10.129.68.8)
X-EOPAttributedMessage: 0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: BN8NAM11FT116:EE_|DM4PR12MB8521:EE_
X-MS-Office365-Filtering-Correlation-Id: b5d23bf5-d590-4859-9ca1-08db05a4a467
X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tKAeWTHTZYNS48+PS5fP1i57so0kC0rHYAGp0OjtNOLhEkRXrguPnhG7OV4N/3R5iQ8HfnzuUCSiqohA4EyRx3H4ZzoKYUPfj7OpUmICA/7ueFT18pS3Yn3kOCZFQ3Kf4FAvePvRhWWQhobM9AkF3xIfegVJAvXJR01KEWtffwp6FT4cJbLAnXHNXRhyZyWpVUFFS9CIH/3g2W0JzyIqm+H1hmps1+aDOHqSwyy2mDb1o9JmmgKQxtSDh/p6DQmEgkxthMZKpUsEXW9NhsLxnAdzVxwolE57OTWV1YGecDH8gHKDv4PgPRM5BmnNqCVDMqb7ANoDi2nBJ7REuOmtRPZWyNmsjSPj2tQYpOpjrm+NR7rRaI/RwJart9iVlV3LJkQ45cwn71y+nyWrRXweP/nGHLO/RA0L4g0HW1c39UikwTGWgcd+UnJX4gGVwDCp+hCFtwfN0SbKCBsoQ2hsZWXW89A391cG3bjficUGuW8iO+VTEIbg8jggDU10ge+NVwfd9G0Ldn81I7tDFXYvDPV897cbkQxx1xYZVBiTKX96fda9pRZTqvxS+jR1WBxoBBTbiDWfYZ7dR9uXeQBWn3A8TELwxHRCQL1namRrQ4C5aWtNyCOh6kEf+ZpalYJR71bzsvEdgQswu9hhlPC+ITySfn2eJhGPVTbVslyH2ZUBDzu9D+YHSDLCiAXmHQSTGElZ6uR02WYQnRKs77leLw==
X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;
SFS:(13230025)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199018)(46966006)(36840700001)(40470700004)(356005)(36860700001)(86362001)(7636003)(36756003)(82740400003)(70206006)(316002)(54906003)(70586007)(110136005)(5660300002)(8936002)(4326008)(82310400005)(8676002)(55016003)(426003)(6286002)(47076005)(2906002)(336012)(40480700001)(83380400001)(2616005)(478600001)(40460700003)(7696005)(26005)(186003)(1076003)(107886003)(41300700001)(16526019)(6666004);
DIR:OUT; SFP:1101;
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2023 05:08:09.2048 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b5d23bf5-d590-4859-9ca1-08db05a4a467
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];
Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT116.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8521
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
For the multiple hardware ports connect to a single DPDK port (mhpsdp),
currently, there is no information to indicate the packet belongs to
which hardware port.
Introduce a new phy affinity item in RTE flow API, and the phy affinity
value reflects the physical port of the received packets.
While uses the phy affinity as a matching item in the flow, and sets the
same phy_affinity value on the Tx queue, then the packet can be sent from
the same hardware port with received.
If tx_phy_affinity 0 is disabled then try to match on phy_affinity 0
will result in an error.
Add the testpmd command line to match the new item:
flow create 0 ingress group 0 pattern phy_affinity affinity is 1 /
end actions queue index 0 / end
The above command means that creates a flow on a single DPDK port and
matches the packet from the first physical port (assume the phy affinity 1
stands for the first port) and redirects these packets into RxQ 0.
Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
Acked-by: Ori Kam <orika@nvidia.com>
---
app/test-pmd/cmdline_flow.c | 29 ++++++++++++++++++
doc/guides/prog_guide/rte_flow.rst | 8 +++++
doc/guides/rel_notes/release_23_03.rst | 6 ++++
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 +++
lib/ethdev/rte_flow.c | 1 +
lib/ethdev/rte_flow.h | 33 +++++++++++++++++++++
6 files changed, 81 insertions(+)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 88108498e0..a6d4615038 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -465,6 +465,8 @@ enum index {
ITEM_METER,
ITEM_METER_COLOR,
ITEM_METER_COLOR_NAME,
+ ITEM_PHY_AFFINITY,
+ ITEM_PHY_AFFINITY_VALUE,
/* Validate/create actions. */
ACTIONS,
@@ -1355,6 +1357,7 @@ static const enum index next_item[] = {
ITEM_L2TPV2,
ITEM_PPP,
ITEM_METER,
+ ITEM_PHY_AFFINITY,
END_SET,
ZERO,
};
@@ -1821,6 +1824,12 @@ static const enum index item_meter[] = {
ZERO,
};
+static const enum index item_phy_affinity[] = {
+ ITEM_PHY_AFFINITY_VALUE,
+ ITEM_NEXT,
+ ZERO,
+};
+
static const enum index next_action[] = {
ACTION_END,
ACTION_VOID,
@@ -6443,6 +6452,23 @@ static const struct token token_list[] = {
ARGS_ENTRY(struct buffer, port)),
.call = parse_mp,
},
+ [ITEM_PHY_AFFINITY] = {
+ .name = "phy_affinity",
+ .help = "match on the physical affinity of the"
+ " received packet.",
+ .priv = PRIV_ITEM(PHY_AFFINITY,
+ sizeof(struct rte_flow_item_phy_affinity)),
+ .next = NEXT(item_phy_affinity),
+ .call = parse_vc,
+ },
+ [ITEM_PHY_AFFINITY_VALUE] = {
+ .name = "affinity",
+ .help = "physical affinity value",
+ .next = NEXT(item_phy_affinity, NEXT_ENTRY(COMMON_UNSIGNED),
+ item_param),
+ .args = ARGS(ARGS_ENTRY(struct rte_flow_item_phy_affinity,
+ affinity)),
+ },
};
/** Remove and return last entry from argument stack. */
@@ -10981,6 +11007,9 @@ flow_item_default_mask(const struct rte_flow_item *item)
case RTE_FLOW_ITEM_TYPE_METER_COLOR:
mask = &rte_flow_item_meter_color_mask;
break;
+ case RTE_FLOW_ITEM_TYPE_PHY_AFFINITY:
+ mask = &rte_flow_item_phy_affinity_mask;
+ break;
default:
break;
}
diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
index 3e6242803d..3b4e8923dc 100644
--- a/doc/guides/prog_guide/rte_flow.rst
+++ b/doc/guides/prog_guide/rte_flow.rst
@@ -1544,6 +1544,14 @@ Matches Color Marker set by a Meter.
- ``color``: Metering color marker.
+Item: ``PHY_AFFINITY``
+^^^^^^^^^^^^^^^^^^^^^^
+
+Matches on the physical affinity of the received packet, the physical port
+in the group of physical ports connected to a single DPDK port.
+
+- ``affinity``: Physical affinity.
+
Actions
~~~~~~~
diff --git a/doc/guides/rel_notes/release_23_03.rst b/doc/guides/rel_notes/release_23_03.rst
index c15f6fbb9f..029b57316c 100644
--- a/doc/guides/rel_notes/release_23_03.rst
+++ b/doc/guides/rel_notes/release_23_03.rst
@@ -69,6 +69,12 @@ New Features
``rte_event_dev_config::nb_single_link_event_port_queues`` parameter
required for eth_rx, eth_tx, crypto and timer eventdev adapters.
+* **Added rte_flow support for matching PHY affinity fields.**
+
+ For the multiple hardware ports connect to a single DPDK port (mhpsdp),
+ Added ``phy_affinity`` item in rte_flow to support physical affinity of
+ the packets.
+
Removed Items
-------------
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 856fb55005..e9f20607a2 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -3725,6 +3725,10 @@ This section lists supported pattern items and their attributes, if any.
- ``color {value}``: meter color value (green/yellow/red).
+- ``phy_affinity``: match physical affinity.
+
+ - ``affinity {value}``: physical affinity value.
+
- ``send_to_kernel``: send packets to kernel.
diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c
index 7d0c24366c..0c2d3b679b 100644
--- a/lib/ethdev/rte_flow.c
+++ b/lib/ethdev/rte_flow.c
@@ -157,6 +157,7 @@ static const struct rte_flow_desc_data rte_flow_desc_item[] = {
MK_FLOW_ITEM(L2TPV2, sizeof(struct rte_flow_item_l2tpv2)),
MK_FLOW_ITEM(PPP, sizeof(struct rte_flow_item_ppp)),
MK_FLOW_ITEM(METER_COLOR, sizeof(struct rte_flow_item_meter_color)),
+ MK_FLOW_ITEM(PHY_AFFINITY, sizeof(struct rte_flow_item_phy_affinity)),
};
/** Generate flow_action[] entry. */
diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h
index b60987db4b..785a56a405 100644
--- a/lib/ethdev/rte_flow.h
+++ b/lib/ethdev/rte_flow.h
@@ -624,6 +624,13 @@ enum rte_flow_item_type {
* See struct rte_flow_item_meter_color.
*/
RTE_FLOW_ITEM_TYPE_METER_COLOR,
+
+ /**
+ * Matches on the physical affinity of the received packet.
+ *
+ * @see struct rte_flow_item_phy_affinity.
+ */
+ RTE_FLOW_ITEM_TYPE_PHY_AFFINITY,
};
/**
@@ -2103,6 +2110,32 @@ static const struct rte_flow_item_meter_color rte_flow_item_meter_color_mask = {
};
#endif
+/**
+ * @warning
+ * @b EXPERIMENTAL: this structure may change without prior notice
+ *
+ * RTE_FLOW_ITEM_TYPE_PHY_AFFINITY
+ *
+ * For the multiple hardware ports connect to a single DPDK port (mhpsdp),
+ * use this item to match the physical affinity of the packets.
+ */
+struct rte_flow_item_phy_affinity {
+ uint8_t affinity;
+ /**
+ * Affinity defines the phy affinity value to match the physical
+ * port of received packet. The value starts from 1 and uses 1 to
+ * match the first physical port.
+ */
+};
+
+/** Default mask for RTE_FLOW_ITEM_TYPE_PHY_AFFINITY. */
+#ifndef __cplusplus
+static const struct rte_flow_item_phy_affinity
+rte_flow_item_phy_affinity_mask = {
+ .affinity = 0xff,
+};
+#endif
+
/**
* Action types.
*
--
2.18.1