DPDK patches and discussions
 help / color / mirror / Atom feed
From: Conor Walsh <conor.walsh@intel.com>
To: bruce.richardson@intel.com, thomas@monjalon.net
Cc: dev@dpdk.org, Conor Walsh <conor.walsh@intel.com>
Subject: [PATCH] dma/ioat: remove printf within ioat driver
Date: Fri,  3 Feb 2023 16:35:14 +0000	[thread overview]
Message-ID: <20230203163514.621178-1-conor.walsh@intel.com> (raw)

rte_log should be used instead of printf within the drivers this patch
changes a printf within the ioat dma driver's start function to an rte log.
The printfs within ioat's dump function will be retained.

Signed-off-by: Conor Walsh <conor.walsh@intel.com>
---
 drivers/dma/ioat/ioat_dmadev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/ioat/ioat_dmadev.c b/drivers/dma/ioat/ioat_dmadev.c
index 5906eb45aa..3fe50ea4a4 100644
--- a/drivers/dma/ioat/ioat_dmadev.c
+++ b/drivers/dma/ioat/ioat_dmadev.c
@@ -146,9 +146,9 @@ ioat_dev_start(struct rte_dma_dev *dev)
 	/* Prime the status register to be set to the last element. */
 	ioat->status = ioat->ring_addr + ((ioat->qcfg.nb_desc - 1) * DESC_SZ);
 
-	printf("IOAT.status: %s [0x%"PRIx64"]\n",
-			chansts_readable[ioat->status & IOAT_CHANSTS_STATUS],
-			ioat->status);
+	IOAT_PMD_DEBUG("channel status - %s [0x%"PRIx64"]\n",
+		       chansts_readable[ioat->status & IOAT_CHANSTS_STATUS],
+		       ioat->status);
 
 	if ((ioat->regs->chansts & IOAT_CHANSTS_STATUS) == IOAT_CHANSTS_HALTED) {
 		IOAT_PMD_WARN("Device HALTED on start, attempting to recover\n");
-- 
2.25.1


             reply	other threads:[~2023-02-03 16:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 16:35 Conor Walsh [this message]
2023-02-03 17:07 ` Bruce Richardson
2023-02-07 10:47   ` Walsh, Conor
2023-02-07 10:48 ` [PATCH v2] " Conor Walsh
2023-02-20  0:38   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230203163514.621178-1-conor.walsh@intel.com \
    --to=conor.walsh@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).